Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <f56f29bb82be4dcb752cf392a09f8c74db6a9d49.camel@nxp.com>
Subject: Re: [PATCH v9 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp
 display pixel link binding
From:   Liu Ying <victor.liu@nxp.com>
To:     Rob Herring <robh@kernel.org>
Cc:     dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        linux-media@vger.kernel.org, andrzej.hajda@intel.com,
        narmstrong@baylibre.com, robert.foss@linaro.org,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org,
        s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com,
        linux-imx@nxp.com, lee.jones@linaro.org, mchehab@kernel.org,
        marcel.ziswiler@toradex.com
Date:   Wed, 15 Jun 2022 09:56:16 +0800
In-Reply-To: <20220614201146.GA2344044-robh@kernel.org>
References: <20220611141421.718743-1-victor.liu@nxp.com>
         <20220611141421.718743-6-victor.liu@nxp.com>
         <20220614201146.GA2344044-robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZHV5UEJyV2MwRWxQOHZQNE5RTmN0WkhITUpVTDNzbUZmeFlhZWsvK2lhWlM1?=
 =?utf-8?B?K00wWFVmemIydm1LN2Y5aWhkOXNNR3FHL3hkcERZTmRhWC9IY3hDMjhZVlk0?=
 =?utf-8?B?cWY4MkNUWWw3VW9LZm9jTTJTbldnRkUyaDczNDlCdnhKb0NUaHdYdm1raUR1?=
 =?utf-8?B?OUpUMmFkaHRjRWI2dGczUzVJbkZNdTdENTF2azN0bXFWKzZXVXlBWjlOYW1P?=
 =?utf-8?B?ZTdLeWlrNkIxSkQ0Y3lQcjFmc3U4WkVxdlYxd0dNb3B2QWUvOGhFeHMxUGVx?=
 =?utf-8?B?dHRaQ014K0toZjZUTU5zczlyaG1WaUN3eWc3RGI2SGpBRTFrMjB0MmpCdnRJ?=
 =?utf-8?B?M3FLYzcxYVVNYmlyb2RqZ1AzeHBFbmRZSXlGTDhtcnhUSlJsT2t0MlJuT21U?=
 =?utf-8?B?RUF4TmZEdjVBU3JQaW15MkU5V2VyNmU2YkZtWUdNT2VZcmtDeFpMbDc3YThV?=
 =?utf-8?B?L3J0WEM2bFJvaWJPRU80YzBXaldiYjAxT0ZCanFXR21QK1VZZnBaOXBVUHk0?=
 =?utf-8?B?c3RtOE1JY09GYnhlRTRrUDRNOTJ2OWdvYlp2cEZ5R1VwWmJCNGVJVTBNY1RZ?=
 =?utf-8?B?R0hEQ1loc2ErR0M5S2VTUC9EMk9UT3RyWWFPcVhhMnBoNGtMVzVmZlZjTXdR?=
 =?utf-8?B?UnBSblpIZGZ3LzVaRUJ4VTFtZ2JCL2JzQUoyMjZvQ1VxM2NvTFl0Rmpud0xL?=
 =?utf-8?B?ZWhET0wxOElhUjZmK2xTVnlzV0hyTTVQNnZxWVBzQUU2dVV6b0JMREhSWXJJ?=
 =?utf-8?B?SVg2TjNrUWhjaEFYNGMyejMzMGtmR3lqK3pRSy9FQXdxUVMvcWVtYzl2cmky?=
 =?utf-8?B?dGdPK2NlVTVNdU9iT21xaHlMWW80SVNwY0pUTVUxdmZHNWhTOGUwMVpzYnhE?=
 =?utf-8?B?SlZDb1AxVlBheXNnSHE5VW56dG1zR2xXV0RaTFVyMkRabHdVVGY5UWEzZnd5?=
 =?utf-8?B?THhaaXEydldkM21sK0JGSTFDS1RWazlRcHpFT3k2Nk8vcXZCOFJvNXhFWEdu?=
 =?utf-8?B?cU1SRG9HQytja1dFa1Z0ZXNSOGdNZ2lEYWxrZDBaUmZYT3Z3a2RkakdkREgz?=
 =?utf-8?B?UmVLdm56d1JxTzcyaHVtcUNTRHZReHlaYkJkY2lTZHNRVlB4ZWZVMzdBbXJH?=
 =?utf-8?B?WG5pbzNGSmRFTCttekk4TDJ0RGF4RlBDemk2aFZDVkI3clFPeSsrUUJpUXhN?=
 =?utf-8?B?OXJNRzBvdGZMcFY2NHFkMnZxSXBZZzdwMEFQM0pqam5nQ0FhQkFBOVZFZUpE?=
 =?utf-8?B?KzZQdUorTW1RSzZtcWcxRDNBRFNGVTNaYjFsRDZXK0dEd094MVVJWVNGZ3BY?=
 =?utf-8?B?b25raDBrNExYTEprZTBmQ3F4NWR2RkdacFd5UllqbzRaWjlaOHFmck5wRmd2?=
 =?utf-8?B?eUhFNWJOYWUzVFE5NFlzTlFMbnFtcGVtUEY5N3o2QWVtRURGOCtKMlpWSHFq?=
 =?utf-8?B?RXVtYy95SzBtSGtQc2RiTE5kUkgyeUlMU25pRG9KaXIyYytUTW9CdDZYQlJa?=
 =?utf-8?B?UnkyVE4rT1FDR3lUdXY4ODhkdXdWY1hBTVNIRXF6eGFZZ243QXhRZjRNZ3lw?=
 =?utf-8?B?cFdzbm5NdFhRSjJNNFM1NFk1MzRvY2RzV0lYblN6ZVR6R3BneFNvQUVlRjcr?=
 =?utf-8?B?NXJDRmZiTkZQenhaVk56RTJ0bzdENHVvZStYalhiVkVwNDBGR1JkUEhneXNw?=
 =?utf-8?B?Y1NLQnBtVWVXMHRVUG1HaC9TOWpmcWlOdzdJNGl3OWxlTGZjNGRaV1FaOHdD?=
 =?utf-8?B?dVM4aENPWnloV0JVT0NrOUprY2FoWXZZV0NERWx5ZEgvWnpFNXBvQWVlM2F1?=
 =?utf-8?B?ODZBb0Z0ZGxCWEtCZ0dVa2N1eThPNnFqdklFYkEyUm9KL1Zpd2dQK2pnREJK?=
 =?utf-8?B?Z3ZzVHNDa3QyNGg1YTF6Tk1UZytrU2VqNzN2eW9JWGI4OUFXc2lVWURWMnBI?=
 =?utf-8?B?SGNxaDAzalRqQS9Ib1NBdUptZVN2amlLamZVSG5CSWZ1N3J3d1ZTUXBQOUVU?=
 =?utf-8?B?L2ROdGxUcWZLY1dOMGlzOG9Ed0dNNHFyR2lybXdXcUtNV1lXSS9IV2RlU1E4?=
 =?utf-8?B?K2NlaDNsZlRnQVU3eVFyVGN6aUtCNHlJd2Zqa3Awejl6UWo4b2dGTmUyTzF6?=
 =?utf-8?B?RjcvU3p4THc1WHpVQkFsTkRMcGVZTG94SEFHN2RrUTJLQ2VYMkNNcDFKQTNP?=
 =?utf-8?B?UHUvQ0tMQ1B6WkJwWTJiMkgrcER5NkRVZ0JhbXd1VDc5amF2QkNWVjVvQXda?=
 =?utf-8?B?Q3l0ZGpxK0N1aHhFaVE0eU1oQTBIR21uVUlzUndGWXF3aTNOenkyOWFjOVhF?=
 =?utf-8?B?RGxDUlRTTEtXTGc4MGFhTnorYlU4bmJBYXJLNUh6bWJ2SmtnZnNwdz09?=
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-Network-Message-Id: dbf527be-4078-4784-b4cd-08da4e72438b
X-MS-Exchange-CrossTenant-AuthSource: AM7PR04MB7046.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 01:56:29.4844
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: nQGhAfZBxE/Q4WHmx0NT1zzLOTYu8giQn9pLAaeZmPfNeWBwFk/QGTuug/ruH4FO77TuMzdkR+OLsp+jMdExnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR04MB6280
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, 2022-06-14 at 14:11 -0600, Rob Herring wrote:
> On Sat, Jun 11, 2022 at 10:14:12PM +0800, Liu Ying wrote:
> > This patch adds bindings for i.MX8qm/qxp display pixel link.
> > 
> > Signed-off-by: Liu Ying <victor.liu@nxp.com>
> > ---
> > v8->v9:
> > * Add 'fsl,dc-id' and 'fsl,dc-stream-id' properties. (Laurent)
> 
> Why? Isn't the graph sufficient for determining the connections?
> That's 
> what it is for.

'fsl,dc-id' determines the SCU resource IMX_SC_R_DC_{0,1} used by the
pixel link. 'fsl,dc-stream-id' determines the SCU control codes, like
IMX_SC_C_PXL_LINK_MST{1,2}_ADDR.

The pixel combiner stands between the Display Controller(DPU) and the
pixel link. I doubt it'll be good to go through the graph in pixel link
driver to get DPU's output port index to set 'dc-stream-id'. 

The graph doesn't tell 'dc-id' unless DPU's or pixel link's OF alias
ids are used. It looks that people don't like the idea of using the
pixel link's OF alias id in pixel link driver to set 'dc-id'(and 'dc-
stream-id'), just like previous versions do.  

> 
> > * Drop Rob's R-b tag.
> > 
> > v7->v8:
> > * No change.
> > 
> > v6->v7:
> > * No change.
> > 
> > v5->v6:
> > * No change.
> > 
> > v4->v5:
> > * No change.
> > 
> > v3->v4:
> > * No change.
> > 
> > v2->v3:
> > * Add Rob's R-b tag.
> > 
> > v1->v2:
> > * Use graph schema. (Laurent)
> > * Require all four pixel link output ports. (Laurent)
> > * Mention pixel link is accessed via SCU firmware. (Rob)
> > 
> >  .../bridge/fsl,imx8qxp-pixel-link.yaml        | 144
> > ++++++++++++++++++
> >  1 file changed, 144 insertions(+)
> >  create mode 100644
> > Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-pixel-
> > link.yaml
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-
> > pixel-link.yaml
> > b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-
> > pixel-link.yaml
> > new file mode 100644
> > index 000000000000..38ecc7926fad
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/display/bridge/fsl,imx8qxp-
> > pixel-link.yaml
> > @@ -0,0 +1,144 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: 
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fschemas%2Fdisplay%2Fbridge%2Ffsl%2Cimx8qxp-pixel-link.yaml%23&amp;data=05%7C01%7Cvictor.liu%40nxp.com%7Cc8ba0853ca6446514fb408da4e421ec0%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637908343136669762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=ZLdEqO84HZMwOIjyo5t%2Fy%2BlcfliLr3J5mV2akOxPU5c%3D&amp;reserved=0
> > +$schema: 
> > https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevicetree.org%2Fmeta-schemas%2Fcore.yaml%23&amp;data=05%7C01%7Cvictor.liu%40nxp.com%7Cc8ba0853ca6446514fb408da4e421ec0%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637908343136669762%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=yL5Xi%2BWz4aX3yniTy8Jq0EhB%2FbLz59QOaCQpxP0AmDM%3D&amp;reserved=0
> > +
> > +title: Freescale i.MX8qm/qxp Display Pixel Link
> > +
> > +maintainers:
> > +  - Liu Ying <victor.liu@nxp.com>
> > +
> > +description: |
> > +  The Freescale i.MX8qm/qxp Display Pixel Link(DPL) forms a
> > standard
> > +  asynchronous linkage between pixel sources(display controller or
> > +  camera module) and pixel consumers(imaging or displays).
> > +  It consists of two distinct functions, a pixel transfer function
> > and a
> > +  control interface.  Multiple pixel channels can exist per one
> > control channel.
> > +  This binding documentation is only for pixel links whose pixel
> > sources are
> > +  display controllers.
> > +
> > +  The i.MX8qm/qxp Display Pixel Link is accessed via System
> > Controller Unit(SCU)
> > +  firmware.
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - fsl,imx8qm-dc-pixel-link
> > +      - fsl,imx8qxp-dc-pixel-link
> > +
> > +  fsl,dc-id:
> > +    $ref: /schemas/types.yaml#/definitions/uint8
> > +    description: |
> > +      u8 value representing the display controller index that the
> > pixel link
> > +      connects to.
> > +
> > +  fsl,dc-stream-id:
> > +    $ref: /schemas/types.yaml#/definitions/uint8
> > +    description: |
> > +      u8 value representing the display controller stream index
> > that the pixel
> > +      link connects to.
> > +    enum: [0, 1]
> > +
> > +  ports:
> > +    $ref: /schemas/graph.yaml#/properties/ports
> > +
> > +    properties:
> > +      port@0:
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description: The pixel link input port node from upstream
> > video source.
> > +
> > +    patternProperties:
> > +      "^port@[1-4]$":
> > +        $ref: /schemas/graph.yaml#/properties/port
> > +        description: The pixel link output port node to downstream
> > bridge.
> > +
> > +    required:
> > +      - port@0
> > +      - port@1
> > +      - port@2
> > +      - port@3
> > +      - port@4
> > +
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: fsl,imx8qxp-dc-pixel-link
> > +    then:
> > +      properties:
> > +        fsl,dc-id:
> > +          const: 0
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            const: fsl,imx8qm-dc-pixel-link
> > +    then:
> > +      properties:
> > +        fsl,dc-id:
> > +          enum: [0, 1]
> > +
> > +required:
> > +  - compatible
> > +  - fsl,dc-id
> > +  - fsl,dc-stream-id
> > +  - ports
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    dc0-pixel-link0 {
> > +        compatible = "fsl,imx8qxp-dc-pixel-link";
> > +        fsl,dc-id = /bits/ 8 <0>;
> > +        fsl,dc-stream-id = /bits/ 8 <0>;
> > +
> > +        ports {
> > +            #address-cells = <1>;
> > +            #size-cells = <0>;
> > +
> > +            /* from dc0 pixel combiner channel0 */
> > +            port@0 {
> > +                reg = <0>;
> > +
> > +                dc0_pixel_link0_dc0_pixel_combiner_ch0: endpoint {
> > +                    remote-endpoint =
> > <&dc0_pixel_combiner_ch0_dc0_pixel_link0>;
> 
> Isn't dc0 and link0 here the same information (if you get the port 
> number from the remote end).

The remote end is the pixel combiner's channel@0 port@1.
Then, from the pixel combiner, we can reach DPU's output port.

Granted that dc0 and link0 here is the same information, but it seems
to be hard to get the 'dc-id' and 'dc-stream-id' information in the
pixel link driver.

Do you mean that we can parse the name of
'dcX_pixel_linkY_dc0_pixel_combiner_ch0' directly to get 'X' and 'Y' in
the pixel link driver? How??

Regards,
Liu Ying