Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Imran Khan <imran.f.khan@oracle.com>
To:     tj@kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk
Cc:     linux-kernel@vger.kernel.org
Subject: [PATCH v7 3/4] kernfs: Introduce interface to access global kernfs_open_file_mutex.
Date:   Wed, 15 Jun 2022 12:10:58 +1000
Message-Id: <20220615021059.862643-4-imran.f.khan@oracle.com>
In-Reply-To: <20220615021059.862643-1-imran.f.khan@oracle.com>
References: <20220615021059.862643-1-imran.f.khan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?uQGCB7cXFPYv1FdLaD/017nMkOyfWcX4PbWcVQF22xmOwDfmb/0gjCAQw7pv?=
 =?us-ascii?Q?GzWUZi+0FIr4XQ753Bi0WANtkq3bP6C7fVFrk7TEcySLEI2E26mp9c7xZI6A?=
 =?us-ascii?Q?ArfiitM9QjhtjXSwJRPOQws03tpkQaqTMH2S1oI+bjUG3YqRdwuttebDqHo0?=
 =?us-ascii?Q?i3W1OQfZQP3oY9geOLC87j5zf07UEOrrwXUXUR7OKBV11drgt0Iz/A8HpOyU?=
 =?us-ascii?Q?6/H+9t/y5RhGf4eSZEnOR1eIQjGsJN2upnZl1UfnYpuVjVeSDbNLDba2dSRO?=
 =?us-ascii?Q?uOZ824OIkGb7mVJ+EeSddpHH3CZAobrYIHLddhW6YslR9+yTtwBFTwrs+mPX?=
 =?us-ascii?Q?aTMaLQesAOi7A3Nu90xDjuJVA7JYYK+Ls9JGqvr/x1hEny+KNkvVM5mNUHya?=
 =?us-ascii?Q?5XbnIxcQPnCg4S/Xa3QdDkyJFJx4448opZBXPkzQTLljTdgyAFXwp9upwqKG?=
 =?us-ascii?Q?2CBYfN8HmQFEaAMCtqw9qV1S0tHREUCE8EK+0PEE655nBHnMptSt3olxmVT0?=
 =?us-ascii?Q?SY7l/3quPFcY3bkZMIik00Ac4ByhB96VC9hC4Obx6gvClo3wadso7VSDbE83?=
 =?us-ascii?Q?Ml+cW6/Jm04/Z/zAVTR2RLiYVjYusXLfRYftGhBjPCXczW5v4cheaKQpZNlF?=
 =?us-ascii?Q?H+TqN6uf8zveY5z9QQu8jr5MAK2CwGTbYX2rU1vEaM3GOy25YqVV61gorATX?=
 =?us-ascii?Q?zvhQgxLt4XMqYjHJqh623LXRCiNjMzeP8xtv+0wJBFScJuEwoZkdbnNPrlB4?=
 =?us-ascii?Q?OYfhHesWEIN4C8myzGMvqRCjZ01I9JlNHGdcHifNHWQDpjjMpUuXg9Q94QVC?=
 =?us-ascii?Q?lFfPi/1sD5JNVJFpq2EGfBRuNvD7fUtbOQfLduMbnomZ3wKf6dcGpkxW9VZW?=
 =?us-ascii?Q?sMSFpvbGYyHXlccvVMGL8u4ZNaE3AZ4qnxsBlbBmHCOAy8Q9gZ2nLRe2KrGN?=
 =?us-ascii?Q?o+xYuqnXdbK3I2MQ4Di55BcuD28pIzNwbjyj9NrFh5oFjfQthkaf8PAE5d+P?=
 =?us-ascii?Q?VI2NcmKB+Yq1IjAy963IzVxIGwMLNl6fPH4C150xlNsb3jaxsET98CDPpdlC?=
 =?us-ascii?Q?n00zldRNxgkZ3BoEtmHEDDuZhPxYTjBMMi5mA1aTnLLK80zA9eI6P7Sw9PoV?=
 =?us-ascii?Q?srVlBAAY2wmnSBKZLr7+v5Wr6NucTIhwZs2lCJOiWyOUmMTSzQIOvd1cVrnF?=
 =?us-ascii?Q?vlokLV2KjlZOzMI5QcR9cEDgSlYkgrI8Vu0/wvKpkyreP4D49WWZYczthAUi?=
 =?us-ascii?Q?85xkJ/FbKA5vnTUq7GGL6oeYjL6RnrtLw9zHaNFALDIneWLTCoPIZKouOLJ0?=
 =?us-ascii?Q?/nb5tUTfZpOW2bRS6TC4UCjcTNKoRJFarknbSzzRZqKTDyirzZQvenRa+/cx?=
 =?us-ascii?Q?IO4uhcH7UWis4sFGX8xhWjL7Wh97+nF/rrm0eMBK+0gu/++1sIit5WE9JBIH?=
 =?us-ascii?Q?eTprl9CPvwspVUQQg2Sf9clXEIZaqf8JH3g/J8JKcBSus/X2l3mUVcA36WmF?=
 =?us-ascii?Q?h9J6ymRA5DDENzY8RgbioRRZISt4aEJca9fNco2b9EQo6K8qAPczZWtvJJcs?=
 =?us-ascii?Q?1Sm/aNHBd1MOB1V7N3rf4Lag07zXRilrYYlcSyLgRk95swjG1a/rhW76TVlg?=
 =?us-ascii?Q?Yk0zECBHx8bsAQ7Bj8+BetpygY3LYThS6PAV9nreQSSPptGWR3szGEZpQ3xs?=
 =?us-ascii?Q?huhdTSaXczysChbl7jpDiHAYzdBQAn8tmyA2xpo7g0dTAKGlnHkMyRYgbeg3?=
 =?us-ascii?Q?i+Woy49nM47p+5SRZkhIoJF0w68yIy0=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fe8445cf-ed40-449f-49b3-08da4e745532
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 02:11:17.9971
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: q+R5r+DfVKQV4KfosC5c1Xlmh3B46ZxRLtFHHJiH6UUtgAw6Qk07fPEQoSqRUJazjKGSVKPQ7IXgMSbXPEKYng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3800
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-15_01:2022-06-13,2022-06-14 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxscore=0 phishscore=0 bulkscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206150004
X-Proofpoint-ORIG-GUID: bpy3uf-a5qdRiNfPIpj_YHRMHsgZmvIO
X-Proofpoint-GUID: bpy3uf-a5qdRiNfPIpj_YHRMHsgZmvIO
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

This allows to change underlying mutex locking, without needing to change
the users of the lock. For example next patch modifies this interface to
use hashed mutexes in place of a single global kernfs_open_file_mutex.

Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
---
 fs/kernfs/file.c | 56 ++++++++++++++++++++++++++++++++----------------
 1 file changed, 38 insertions(+), 18 deletions(-)

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index dce654ad2cea9..fa0154211076d 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -49,6 +49,22 @@ struct kernfs_open_node {
 
 static LLIST_HEAD(kernfs_notify_list);
 
+static inline struct mutex *kernfs_open_file_mutex_ptr(struct kernfs_node *kn)
+{
+	return &kernfs_open_file_mutex;
+}
+
+static inline struct mutex *kernfs_open_file_mutex_lock(struct kernfs_node *kn)
+{
+	struct mutex *lock;
+
+	lock = kernfs_open_file_mutex_ptr(kn);
+
+	mutex_lock(lock);
+
+	return lock;
+}
+
 /**
  * kernfs_deref_open_node - Get kernfs_open_node corresponding to @kn.
  *
@@ -79,9 +95,9 @@ kernfs_deref_open_node(struct kernfs_open_file *of, struct kernfs_node *kn)
  * @kn: target kernfs_node.
  *
  * Fetch and return ->attr.open of @kn when caller holds the
- * kernfs_open_file_mutex.
+ * kernfs_open_file_mutex_ptr(kn).
  *
- * Update of ->attr.open happens under kernfs_open_file_mutex. So when
+ * Update of ->attr.open happens under kernfs_open_file_mutex_ptr(kn). So when
  * the caller guarantees that this mutex is being held, other updaters can't
  * change ->attr.open and this means that we can safely deref ->attr.open
  * outside RCU read-side critical section.
@@ -92,7 +108,7 @@ static struct kernfs_open_node *
 kernfs_deref_open_node_protected(struct kernfs_node *kn)
 {
 	return rcu_dereference_protected(kn->attr.open,
-				lockdep_is_held(&kernfs_open_file_mutex));
+				lockdep_is_held(kernfs_open_file_mutex_ptr(kn)));
 }
 
 static struct kernfs_open_file *kernfs_of(struct file *file)
@@ -575,19 +591,20 @@ static int kernfs_get_open_node(struct kernfs_node *kn,
 				struct kernfs_open_file *of)
 {
 	struct kernfs_open_node *on, *new_on = NULL;
+	struct mutex *mutex = NULL;
 
-	mutex_lock(&kernfs_open_file_mutex);
+	mutex = kernfs_open_file_mutex_lock(kn);
 	on = kernfs_deref_open_node_protected(kn);
 
 	if (on) {
 		list_add_tail(&of->list, &on->files);
-		mutex_unlock(&kernfs_open_file_mutex);
+		mutex_unlock(mutex);
 		return 0;
 	} else {
 		/* not there, initialize a new one */
 		new_on = kmalloc(sizeof(*new_on), GFP_KERNEL);
 		if (!new_on) {
-			mutex_unlock(&kernfs_open_file_mutex);
+			mutex_unlock(mutex);
 			return -ENOMEM;
 		}
 		atomic_set(&new_on->event, 1);
@@ -596,7 +613,7 @@ static int kernfs_get_open_node(struct kernfs_node *kn,
 		list_add_tail(&of->list, &new_on->files);
 		rcu_assign_pointer(kn->attr.open, new_on);
 	}
-	mutex_unlock(&kernfs_open_file_mutex);
+	mutex_unlock(mutex);
 
 	return 0;
 }
@@ -618,12 +635,13 @@ static void kernfs_unlink_open_file(struct kernfs_node *kn,
 				 struct kernfs_open_file *of)
 {
 	struct kernfs_open_node *on;
+	struct mutex *mutex = NULL;
 
-	mutex_lock(&kernfs_open_file_mutex);
+	mutex = kernfs_open_file_mutex_lock(kn);
 
 	on = kernfs_deref_open_node_protected(kn);
 	if (!on) {
-		mutex_unlock(&kernfs_open_file_mutex);
+		mutex_unlock(mutex);
 		return;
 	}
 
@@ -635,7 +653,7 @@ static void kernfs_unlink_open_file(struct kernfs_node *kn,
 		kfree_rcu(on, rcu_head);
 	}
 
-	mutex_unlock(&kernfs_open_file_mutex);
+	mutex_unlock(mutex);
 }
 
 static int kernfs_fop_open(struct inode *inode, struct file *file)
@@ -773,11 +791,11 @@ static void kernfs_release_file(struct kernfs_node *kn,
 	/*
 	 * @of is guaranteed to have no other file operations in flight and
 	 * we just want to synchronize release and drain paths.
-	 * @kernfs_open_file_mutex is enough.  @of->mutex can't be used
+	 * @kernfs_open_file_mutex_ptr(kn) is enough. @of->mutex can't be used
 	 * here because drain path may be called from places which can
 	 * cause circular dependency.
 	 */
-	lockdep_assert_held(&kernfs_open_file_mutex);
+	lockdep_assert_held(kernfs_open_file_mutex_ptr(kn));
 
 	if (!of->released) {
 		/*
@@ -794,11 +812,12 @@ static int kernfs_fop_release(struct inode *inode, struct file *filp)
 {
 	struct kernfs_node *kn = inode->i_private;
 	struct kernfs_open_file *of = kernfs_of(filp);
+	struct mutex *mutex = NULL;
 
 	if (kn->flags & KERNFS_HAS_RELEASE) {
-		mutex_lock(&kernfs_open_file_mutex);
+		mutex = kernfs_open_file_mutex_lock(kn);
 		kernfs_release_file(kn, of);
-		mutex_unlock(&kernfs_open_file_mutex);
+		mutex_unlock(mutex);
 	}
 
 	kernfs_unlink_open_file(kn, of);
@@ -813,6 +832,7 @@ void kernfs_drain_open_files(struct kernfs_node *kn)
 {
 	struct kernfs_open_node *on;
 	struct kernfs_open_file *of;
+	struct mutex *mutex = NULL;
 
 	if (!(kn->flags & (KERNFS_HAS_MMAP | KERNFS_HAS_RELEASE)))
 		return;
@@ -822,16 +842,16 @@ void kernfs_drain_open_files(struct kernfs_node *kn)
 	 * ->attr.open at this point of time. This check allows early bail out
 	 * if ->attr.open is already NULL. kernfs_unlink_open_file makes
 	 * ->attr.open NULL only while holding kernfs_open_file_mutex so below
-	 * check under kernfs_open_file_mutex will ensure bailing out if
+	 * check under kernfs_open_file_mutex_ptr(kn) will ensure bailing out if
 	 * ->attr.open became NULL while waiting for the mutex.
 	 */
 	if (!rcu_access_pointer(kn->attr.open))
 		return;
 
-	mutex_lock(&kernfs_open_file_mutex);
+	mutex = kernfs_open_file_mutex_lock(kn);
 	on = kernfs_deref_open_node_protected(kn);
 	if (!on) {
-		mutex_unlock(&kernfs_open_file_mutex);
+		mutex_unlock(mutex);
 		return;
 	}
 
@@ -845,7 +865,7 @@ void kernfs_drain_open_files(struct kernfs_node *kn)
 			kernfs_release_file(kn, of);
 	}
 
-	mutex_unlock(&kernfs_open_file_mutex);
+	mutex_unlock(mutex);
 }
 
 /*
-- 
2.30.2