Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <89ca35ba-0290-b155-b290-5e70efafa9bb@oracle.com>
Date:   Wed, 15 Jun 2022 12:13:48 +1000
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH v6 1/4] kernfs: make ->attr.open RCU protected.
Content-Language: en-US
To:     Tejun Heo <tj@kernel.org>
Cc:     gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk,
        linux-kernel@vger.kernel.org
References: <20220614070346.810168-1-imran.f.khan@oracle.com>
 <20220614070346.810168-2-imran.f.khan@oracle.com>
 <Yqi1RVRK2XahPWlg@slm.duckdns.org>
From:   Imran Khan <imran.f.khan@oracle.com>
In-Reply-To: <Yqi1RVRK2XahPWlg@slm.duckdns.org>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cEhPQVB1Q0NNSGMzb2hQMjN3dzhPTVo4SjFNV3cwNTY2VW4yaXFoR2ZyclBT?=
 =?utf-8?B?MjlqNzVDQUh2ZDdHWnNGQjU5WndMaVpJZEZCUmF0RWFOcTNLczNVcUF2RHlF?=
 =?utf-8?B?SUk5Si9NcStiUHVkQ3o2QUFSWnprRytCa3NSN21YVHJ5ZVdqb0pCcWU1bWVx?=
 =?utf-8?B?YWZSSXJvdkRNZmZDVTBRVU4yN3J3Y0RsdHU0cmU3ajZrcElCRTBSM2dnMHcx?=
 =?utf-8?B?MzdJR1BZaHJ3UXQwT0hwb29WVldBV25RTm1BNWIycE5PNnVlbHRhTkY0L0pr?=
 =?utf-8?B?NWhtUFFNZ1plQWdPMHN4Vlo5TUdvSk9rdm4yQXNwU25ORUdXaUhtK1JKN084?=
 =?utf-8?B?K29EWVp3MHpxeVVPc05iNmRtbFg2UTZGZmJDbHZrYWN0UXZIWDlRNzFieHF3?=
 =?utf-8?B?L3psc05yV1pBTWQxajIwRXFEZ3RwTFhQQWdRRTlrTSs1VmFkOHk2c09mRlRw?=
 =?utf-8?B?UVdJRVRyaUpvQ1pVUVBSTG9NZml1VDBXdC9vWEM1QUY0SFhubTkzRTBrVDQz?=
 =?utf-8?B?eGF2REdTRlliT09NYzRpVHBPK2Jud3F2SUx4bmtURHYvVG5aTTRhK2s3WGw0?=
 =?utf-8?B?NFBjK3RVY3JRZ3gzSDFHcWd3Mll1Ukl3Y01tWitIQjNpdktCWWlnWHFrc2sz?=
 =?utf-8?B?T0ozbU51cGl3SW1kTGNkNTMxQW5udGFvN0tiWEozNmk0ZWlVMmptQ2kvaHBB?=
 =?utf-8?B?Ny9sV2grSGpyZUgrd1BGdDFrMWpkYjVGYU1xQUNHZFo2aXJyN1YyYlAvVVN6?=
 =?utf-8?B?VGlESnJhdXUxQlIvdkpDdlpRSUFlRnF4Q00vZm5HandwZlJKTVp6S0diOXhO?=
 =?utf-8?B?NExmT1ZEczBDTGNEUnd2Q2J5V3JwV1kzM1NCU1RVcGt2a0xzNXJYc0t5eTl3?=
 =?utf-8?B?T2MyeUlObzRheXhlN29yQUpvMmNtdE5GaG5zSGFodzRSVDhBNERGazlkdnE2?=
 =?utf-8?B?MW51UGRES2lHQVNMZld0RnZjTXdMaUdqQklaQ1VpWEVhdTVLbEtJeWVWdlBZ?=
 =?utf-8?B?ZVArcTJVODRBekJQZElPY3ZyQkZIS09ONGU1ZGhQQWlwU1RJN2lFVWxaRWJ5?=
 =?utf-8?B?TlptS3VEQlFuU1VLQWZtaFBDTHVOODdndkdiRDlhc21NTEQzZFg5WnM0Y3M1?=
 =?utf-8?B?UU5IT2xJQWQ5bkRJdFJscGNxTERON3cxclFHcUtWdXJmU0k2ampKb3JrMnd1?=
 =?utf-8?B?UXI2dzB2SENoWjdJNUxod3AvWkhoSGdsMzI0S3h1a3RXTW9jQUlTSDRvNkF0?=
 =?utf-8?B?SHZPQjlLWkhkQXNTSmtVRGoxQ051N1NOZTVYMWx3ZTZ2T2Q1WmwvVU55RjJL?=
 =?utf-8?B?U2Fib1BHbzIyZWpmOVliTVcvb0VMVXorWTNFc2R3NUZOMlhHNDdDNHNiZWF2?=
 =?utf-8?B?K21rejFMUXcyM1ptekxLblNoZk5UdHd0cE51YWFmVWg3bFdMaTQ5RDQ1SmZ2?=
 =?utf-8?B?b3pWeWVXZVZ1ckVMVmpYditKb2dneE1yUVFLenZWWkZTWGZoeWhUdVJKd0Rm?=
 =?utf-8?B?THBZYnE4aFhla0MzRkN5MVB4aGNQanFtRlhTZDNQRDdlVG5YSGcwdmZJbmVB?=
 =?utf-8?B?OTdFaURYR3FlbFpwbi9JMTdDV0xGZ0lzZDFaOUNVSXlpTWpmWUpwbXM4UHlY?=
 =?utf-8?B?VCtmK1l5cXVyZTBBTEFPWEVHV3V4Y0xQTlQ0UDNoVnNFV0M0bmNRTGF4cXgw?=
 =?utf-8?B?aWFwN3JlaXlsWmE3TWFrbkp6R1M0SFBKcXRPNm84ZzdhQ2Z3U2wyeHpSZExu?=
 =?utf-8?B?dmVwTE52TlFzU3RFWmJCV1l1dWQxcFp4QzlRQUErL25XUHpwR2ZXNSt5TDhV?=
 =?utf-8?B?c0VJSFBpQkNTZnU1akYvZ0lhRWFQdm92ZWZWaVdqUUNsaEk2a1JKSEtRa0dq?=
 =?utf-8?B?Umdxb3BTbGxrc0VkVkU5Z0pKRmlMZ0lkNGdqMnFtdzFuazdUVVVNMm45UTEx?=
 =?utf-8?B?bHpGUm9jSU9Vc0ttWWFuUXNtTGNLUHpFWEczNXZINTdabmxjUkZhVDJESkZp?=
 =?utf-8?B?SkhBRG5UZGZ4S3ZLd0FXU0F0cUNhNFBIMzRXUTBlRnFDNnNxRERNRkwvdGZI?=
 =?utf-8?B?by9zaXgrWm9mRGQ1UGhJS3ExTDJOekE3bDZ2MVFsTlIwZitGQUw2cmlVTWNF?=
 =?utf-8?B?UkdZczJjck1tZE9kK3EwZ1pHSGwyVm8wU041K3NYcmRPMHJsMG9QTm5MTVRw?=
 =?utf-8?B?dGpFMisyZkZiQW9raEZNZHg3T0VkWmhyYVJiK2xxRWZXM1BwRlIvQUNwa1Bm?=
 =?utf-8?B?eEJkeUNVbFFLLzEvL0pQeWhwak4veThtTjJWUGp5RW81RWQvNy9vdzUveUNq?=
 =?utf-8?B?Z1djK0dhbG1ITStZMEx4ZDVOUVlVZUExWHJvQ29BelZaZzd6K29tSCtib1pF?=
 =?utf-8?Q?2j1Mzzn2QS89Bwic=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1efd08a9-7c80-4925-7245-08da4e74b331
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 02:13:55.9005
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WjetKwzzQpB3vyGxQagmN0Nng0SF87fJK/Du/EqBgdBsVErYmDzsPKVMJqcwaH7nAKAGWWxG35siZYlNQeRyJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR10MB3636
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-15_01:2022-06-13,2022-06-14 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 malwarescore=0 mlxlogscore=999
 bulkscore=0 spamscore=0 phishscore=0 adultscore=0 suspectscore=0
 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206150004
X-Proofpoint-GUID: ynSkOynTa-YhYvOi2EtYgFQOuJLiX3FK
X-Proofpoint-ORIG-GUID: ynSkOynTa-YhYvOi2EtYgFQOuJLiX3FK
X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hello Tejun,

On 15/6/22 2:20 am, Tejun Heo wrote:
> On Tue, Jun 14, 2022 at 05:03:43PM +1000, Imran Khan wrote:
>> +/**
[...]
> 
> Hey, so, the difference between rcu_dereference_check() and
> rcu_dereference_protected() is that the former can be called either with rcu
> read locked or under the extra condition (here, open_file_mutex held) while
> the latter can't be used under rcu read lock. The two can generate different
> codes too - the former enforces dependency ordering which makes accesses
> under rcu read lock safe, while the latter doesn't.
> 
> In the above, you're saying that the accessor is only to be used while
> holding kernfs_open_file_mutex but then using rcu_dereference_check() which
> is odd. There are two ways you can go 1. ensure that the accessor is always
> used under the mutex and use rcu_dereference_protected() or 2. if the
> function can be used under rcu read lock, rename so that the differentiation
> between the two accessors is based on the parameter type, not whether
> they're protected or not.
> 
I am going with option 1 suggested above, since the accessor will always operate
under kernfs_open_file_mutex.

> Can you please post the updated patch as a reply to this one? No need to
> post the whole thing over and over again.
> 
I am sending the full patch-set because after modifying
PATCH-1 we will get a conflict like below when applying previous version of PATCH-3

static struct kernfs_open_node *
kernfs_deref_open_node_protected(struct kernfs_node *kn)
{
<<<<<<< HEAD
        return rcu_dereference_protected(kn->attr.open,
                                lockdep_is_held(&kernfs_open_file_mutex));
=======
        return rcu_dereference_check(kn->attr.open,
                               lockdep_is_held(kernfs_open_file_mutex_ptr(kn)));
>>>>>>> 80411dbfe1890 (kernfs: Introduce interface to access global
kernfs_open_file_mutex.)

Full patch-set will avoid this small conflict. I hope sending full
patch-set is okay for this time. The full patch-set (v7) is available at [1]

Thanks
 -- Imran

[1]:https://lore.kernel.org/lkml/20220615021059.862643-1-imran.f.khan@oracle.com/