Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 14 Jun 2022 18:52:21 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     Oleksij Rempel <o.rempel@pengutronix.de>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Paolo Abeni <pabeni@redhat.com>,
        Jonathan Corbet <corbet@lwn.net>,
        Michal Kubecek <mkubecek@suse.cz>, kernel@pengutronix.de,
        linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/1] net: phy: add remote fault support
Message-ID: <20220614185221.79983e9b@kernel.org>
In-Reply-To: <YqdQJepq3Klvr5n5@lunn.ch>
References: <20220608093403.3999446-1-o.rempel@pengutronix.de>
        <YqS+zYHf6eHMWJlD@lunn.ch>
        <20220613125552.GA4536@pengutronix.de>
        <YqdQJepq3Klvr5n5@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 13 Jun 2022 16:56:37 +0200 Andrew Lunn wrote:
> That would suggest we
> want a ETHTOOL_LINK_MODE_REMOTE_FAULT_BIT, which we can set in
> supported and maybe see in lpa?

Does this dovetail well with ETHTOOL_A_LINKSTATE_EXT_STATE /
ETHTOOL_A_LINKSTATE_EXT_SUBSTATE ?

That's where people who read extended link state out of FW put it
(and therefore it's read only now).

In case I'm just confused and this is different we should prolly
add a paragraph in docs to disambiguate.