Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Imran Khan <imran.f.khan@oracle.com>
To:     tj@kernel.org, gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk
Cc:     linux-kernel@vger.kernel.org
Subject: [PATCH v7 0/4] kernfs: make ->attr.open RCU protected.
Date:   Wed, 15 Jun 2022 12:10:55 +1000
Message-Id: <20220615021059.862643-1-imran.f.khan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Kk3llf0cRGb9y7y56NTWRAdDTQ5Oy/jJj87SdtlltDFz7rXqAFcQs40bYK6M?=
 =?us-ascii?Q?chHppDHcnYywm3LT1nkZcsHB2PWgEwtemUtSld3dGowKDRM3Ctu5xMmSBlTQ?=
 =?us-ascii?Q?17G3jdW6Zpz92MCfdds4X0jQ9nKL54PD/cLGaFFi11dwgoWkEf6cShh3HQzj?=
 =?us-ascii?Q?P0X3BTbZBV6ysc66Lh4folahOxL+IBt8odyxTW1Yoi3aq4Zzc4A5QfSU3SS7?=
 =?us-ascii?Q?APvnLRFGaXHDyqzSt2jBN3IJvLvL/X5jJA8sMJ3Fpls3H1b310p1497yOZI9?=
 =?us-ascii?Q?2WVq10wks6IIV6kl2MK9I+Vv20elw0LyzzpdMujUNR0jnF3JYQzmCgq3Vg/k?=
 =?us-ascii?Q?4eiW5hdTdDxnvR70FXyXhka3eJ+Eq55ZNEkf1Z3gMBA9g9LZvuvNGsaups1T?=
 =?us-ascii?Q?7D4nIz8PU0scViE4ZXmZbXgAZzaHS6pKNLzjWAmBB/N7gaQPkJgedx/Su4lN?=
 =?us-ascii?Q?prAoP4gyIcmjPPLUUHWbY9khb+aIPPGGwGMiGQnl7S1XATeOiKG5D3tYv5Mj?=
 =?us-ascii?Q?KO6tTz0ivAss5EWXIbYz/IQfMWYEUuimZglbw8yBcYdu4IkCqj06N3ulOGt2?=
 =?us-ascii?Q?54qodjoh8Wrj7kpsX5IbYC4KahgCOTaQISQM1M0IIQ28ghxKixob/PYDdL7G?=
 =?us-ascii?Q?R7nsBqMzFG4bdQtsoniFHC/aMcadpp9FnP9XHSbzBVCIYO89C+uNKciP9Ze/?=
 =?us-ascii?Q?Kh9IhDPAlxjcJ8zT1euYRimL6U2kJ6ODBc/VpqRB7pLsP5yy9boHg+9oqMU5?=
 =?us-ascii?Q?bbw5VYLVeaRZAN0jx8t2llV2POl9NvHiHs8PHb4jvwwwUXDR2k2R1WfmF+Ci?=
 =?us-ascii?Q?7aiwOhOxge3T13wyzzqZ/vhFU/nT7DTh8ItppZ2d16dyL+Ws/qBKkV6cjTfK?=
 =?us-ascii?Q?ONkUWBm8FEehscctaOkG6+5gDMvNPbOohQhMhz0wjomOhvo+tVX8MFe5LVnK?=
 =?us-ascii?Q?IOKceo9mqeSa8le5vGbmBB4F8Aepr7ccXypDjZk/hRyDG3ncr1naxVUSPkPr?=
 =?us-ascii?Q?8V2KXNWX1823UYtZNGuJrn1cQwzo9LFG3HVd4TxFmca7Qgq4mLB3+183j/9o?=
 =?us-ascii?Q?o+HePGL5zePhIX+fj2XXuxzEPNbLWQbTh15UFQ+/Pf8vK83GESvY8W1gigrp?=
 =?us-ascii?Q?QeQ24nAr0ZAY+CgM/HwegCKp/HWyfXw5SQpOfAdVr983vV8Sfkdp7NvaYYiT?=
 =?us-ascii?Q?Dfo91gv5I4D/oAZOx8mh9o+Zumt9KCjrScehsftXISoPJC8B8OT8Rwm6BQjF?=
 =?us-ascii?Q?tvPklsWqlUqDLdpeIY/Ws+ykP79IO5BG2q5xj9kYErmGFalHSBOBZdmDboEh?=
 =?us-ascii?Q?zkj/WtAB/b99n4srizTjQmNAOK4v0PDa7sCLM2quvFZp/6JybnPL/gykAW0J?=
 =?us-ascii?Q?+PS4hqm89e97VQt2kLzy/D+MwTJQszzgCkZa4HGZbT0asB3PkkTic5MEKbI0?=
 =?us-ascii?Q?N0vehemGwCnp7O2u7B8CCpZOv1InXJGqeKXxFoXFxm7qCHM2rWq9b8SGzpnT?=
 =?us-ascii?Q?rahlPtqg1Vzbw5LV0L2AnNVX8e48s4RlQ1l4B/dQ8Q1j7EumYxsLdSIYDTnm?=
 =?us-ascii?Q?v+RgPwglHA5LrnkKL1ae/bg/PyEQluWAn7OEJ12q7DP86+4Kv/C1QhONQgK+?=
 =?us-ascii?Q?8iC6MU6HrKpmKfWqcF3yUZyKCHeePgg7IysUWOqLQIkEUhAPgIgsW8/0Q8zc?=
 =?us-ascii?Q?Xra+DfQzDNyuH67H6H+VX2p/QNljYb6xuNjivpm920JhpZ1ZMZQARxN6+imW?=
 =?us-ascii?Q?Cq3xPJELmSgqhVFF7Q7n7pyO5x834h4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 5874de77-5fdb-4931-2bd0-08da4e745205
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 02:11:12.7777
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jcF6rjSxIvgBySDDOBXRXuRrTNVHc1a1oxuoE8f6SiE8/QeOXH9cEZcQoLAH9XGyuZaAbunUieZOXVmGYOqE6A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR10MB3800
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-15_01:2022-06-13,2022-06-14 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 malwarescore=0
 suspectscore=0 spamscore=0 mlxscore=0 phishscore=0 bulkscore=0
 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206150004
X-Proofpoint-GUID: N04tFN86-nudHS4Fxd90edmrWGXouRmf
X-Proofpoint-ORIG-GUID: N04tFN86-nudHS4Fxd90edmrWGXouRmf
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

The patches in this version of the patch set are as follows:

PATCH-1: Make kernfs_open_node->attr.open RCU protected.

PATCH-2: Change kernfs_notify_list to llist.

PATCH-3: Introduce interface to access kernfs_open_file_mutex.

PATCH-4: Replace global kernfs_open_file_mutex with hashed mutexes.

Changes since v6:
 - Use rcu_dereference_protected for ->attr.open dereferencing under
   kernfs_open_file_mutex

Changes since v5:
 - Use 2 helpers for ->attr.open dereferencing

Changes since v4:
 - Rebase on tag next-20220610
 - Use one helper for all ->attr.open dereferencing.

Changes since v3:
 - Rebase on tag next-20220601
 - Rename RCU access related helpers and update their description
 - Address errors reported by kernel test robot
 - Include Acked-by tags from Tejun for the acked patches (PATCH-2,3,4)

Changes since v2:
 - Rebase on tag next-20220510
 - Remove PATCH-1 of v2 because it is present in tag next-20220510
 - Include Acked-by tags from Tejun for the acked patches (PATCH-2 and PATCH-3)


Cover letter for v2:
--------------------------------------------------------------------------

I have not yet received any feedback about v1 of this patchset [2] but
in the meantime an old version of first patch from [3] has been integrated in
linux-next. Functionally first patch in both [2] and [3] are identical.
It's just that [2] has renamed one of the functions to better reflect the fact
that we are no longer using reference counting for kernfs_open_node.

In this version, I have just modified first patch of v1 so that we use the
modified function name as done in [2] and avoid those parts that are already
present in linux-next now. The remaining 4 patches (PATCH-2 to PATCH-5) are
identical in both v1 and v2 albeit v2 has been rebased on tag next-20220503.

Changes since v1:
 - Rebase on tag next-20220503

[2]: https://lore.kernel.org/lkml/20220428055431.3826852-1-imran.f.khan@oracle.com/
[3]: https://lore.kernel.org/lkml/20220324103040.584491-1-imran.f.khan@oracle.com/

Original cover letter
-------------------------------------------------------

This patchset contains subset of patches (after addressing review comments)
discussed at [1]. Since [1] is replacing multiple global locks and since
each of these locks can be removed independently, it was decided that we
should make these changes in parts i.e first get one set of optimizations
integrated and then work on top of those further.

The patches in this change set introduce following changes:

PATCH-1: Remove reference counting for kernfs_open_node.

PATCH-2: Make kernfs_open_node->attr.open RCU protected.

PATCH-3: Change kernfs_notify_list to llist.

PATCH-4: Introduce interface to access kernfs_open_file_mutex.

PATCH-5: Replace global kernfs_open_file_mutex with hashed mutexes.

[1] https://lore.kernel.org/lkml/YmLfxHcekrr89IFl@slm.duckdns.org/

----------------------------------------------------------------

Imran Khan (4):
  kernfs: make ->attr.open RCU protected.
  kernfs: Change kernfs_notify_list to llist.
  kernfs: Introduce interface to access global kernfs_open_file_mutex.
  kernfs: Replace global kernfs_open_file_mutex with hashed mutexes.

 fs/kernfs/file.c            | 249 ++++++++++++++++++++++--------------
 fs/kernfs/kernfs-internal.h |   4 +
 fs/kernfs/mount.c           |  19 +++
 include/linux/kernfs.h      |  61 ++++++++-
 4 files changed, 235 insertions(+), 98 deletions(-)


base-commit: 6d0c806803170f120f8cb97b321de7bd89d3a791
-- 
2.30.2