Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762648AbXEWIF2 (ORCPT ); Wed, 23 May 2007 04:05:28 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755640AbXEWIFN (ORCPT ); Wed, 23 May 2007 04:05:13 -0400 Received: from mtagate2.de.ibm.com ([195.212.29.151]:43560 "EHLO mtagate2.de.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754723AbXEWIFL (ORCPT ); Wed, 23 May 2007 04:05:11 -0400 Subject: RE: 2.6.22-rc1-mm1 - s390 vs. md From: Martin Schwidefsky Reply-To: schwidefsky@de.ibm.com To: "Williams, Dan J" Cc: Cornelia Huck , Andrew Morton , linux-kernel@vger.kernel.org, NeilBrown , linux-s390 In-Reply-To: <0C7297FA1D2D244A9C7F6959C0BF1E5201E39968@azsmsx413.amr.corp.intel.com> References: <0C7297FA1D2D244A9C7F6959C0BF1E5201E39968@azsmsx413.amr.corp.intel.com> Content-Type: text/plain Organization: IBM Corporation Date: Wed, 23 May 2007 10:05:39 +0200 Message-Id: <1179907539.17849.16.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.10.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1339 Lines: 30 On Tue, 2007-05-22 at 17:25 -0700, Williams, Dan J wrote: > The approach I have taken is to add the missing definitions to > include/asm-s390/dma-mapping.h [ a non-outlook-mangled version of the > patch is pushed out in my rebased git tree ]. I was not able to fully > compile-test this change as the three s390-cross-toolchains I tried > each We are trying to get rid of dma-mapping.h, see the last change to the file with commit 411f0f3edc141a582190d3605cadd1d993abb6df. I don't think we should reintroduce dma related definition but split the async_tx in a way that allows to compile it on an architecture with CONFIG_NO_DMA=y (yes I know that is harder that to just add the dma stubs). You've said that there is a software implementation if there is no dma engine present. This software implementation should be independent of dma-mapping.h. Without having looked at the code, isn't it possible to isolate that software implementation into its own C file? That would be the only one that gets compiled for s390. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/