Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 14 Jun 2022 20:30:05 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     <alison.schofield@intel.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        "Steven Rostedt" <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, <linux-cxl@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] cxl/core: Add sysfs attribute get_poison for list
 retrieval
Message-ID: <YqlSPYBdOfTaXW6Q@iweiny-desk3>
References: <cover.1655250669.git.alison.schofield@intel.com>
 <57644934bb7af8e1c692735f53c2c415a1ba16d1.1655250669.git.alison.schofield@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <57644934bb7af8e1c692735f53c2c415a1ba16d1.1655250669.git.alison.schofield@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?FJb0aysNiSe5KvqGTjbxQGNi2WUMH+/1ghFKPeSUBWbxb2nLhsr9ReLBXWWn?=
 =?us-ascii?Q?xqsygjP+I+53mJJg8ClKhGCanTaqVaDA5Lgf0iDrtgAfeNXfS7XPDVx7Kkmr?=
 =?us-ascii?Q?4SaZR2hSsV6kr3SREgRpEw2WALDqtrVFStd0rQPfhT5NtZe0MBhP5N1396UQ?=
 =?us-ascii?Q?LxLo++tDx6qnXRCMfwcXoo9jJiw+v5vs/70tlGFELovGXG0mAUYnAgCf+qBa?=
 =?us-ascii?Q?tLBmxRhZsP60KPpJoolQXeQa0so2OvXI8oRQ3JXbVA680qvVQvrx1v6sgwLu?=
 =?us-ascii?Q?THliFdaONUDHDVl/b9kFxDkwYEV2JjXiOv4XT+qAGVWXITwK5ckUZwrSlr4L?=
 =?us-ascii?Q?CPT0LrhOyPQJbeK0N5CV+Ehlp8BgMnFF9kqfPRhmaGo6hSlLkxoG/a9XYEvS?=
 =?us-ascii?Q?/oGrgkqt2PVY738AcWhO0kNcjQQnTYpqKrqgvseUQ2AJyTwjvdg2Dd/9BRjh?=
 =?us-ascii?Q?wuuZQFB1LlNkgxzndmsrN24iR1wqSMjjhXIpiGKk7SdgxGFPAK2AlWDPm0Ew?=
 =?us-ascii?Q?rXiNT9yMLUTzv2uSmrPRIiPqhXCHlqSLGJzTtTJ4ORbrd2GJuHAHI4KZTZBq?=
 =?us-ascii?Q?BZZUPbfZJ0keV4KL9BFhxVeWMIIXbtqAEMdZRW1x06QSQX2EOmVaNePciF0S?=
 =?us-ascii?Q?N8wxhkWImNkloKkpaxobgwlMOafQJllYRd49vFewTxKIvzV3FXTEgL5xBh3P?=
 =?us-ascii?Q?v09WwBu0rKoprW95f8j99yoRvnlAZfFpSCSFAcmptYJyb+2BMI++L2izZ2tu?=
 =?us-ascii?Q?xwm1gMLZ3ZIvdY/BU2WdM7j8f+b7K2Y4jAHzQyAR06veSjkvRTSSyIXJf9Tj?=
 =?us-ascii?Q?qwhoLt61ophGvMIdRV66WcguLLrK/UPkHu6pdHMzJkp+Fbkc9tDN+Xh54yXq?=
 =?us-ascii?Q?hlphDK4In5hSBC/XxicoB83Topn9NvmmFeXmh7PYOmlyM21CU3UbgGVgnf9d?=
 =?us-ascii?Q?4H9UnSnTR/huMQP8j5m7R24RuQnVgbplTWFj8obWXd4kWaROuGGkxuqyuDIg?=
 =?us-ascii?Q?2bX+o3cD8MYSR9RVesg2OuYSGsBKPZtXHpHTzE7RQ8yetZuBghj5WddtCMbQ?=
 =?us-ascii?Q?iFnZUfVpmr5jeom33PmOGyK4F32y/njrLQGzhy0BS4hgCXLwTcXTmYgF2AP3?=
 =?us-ascii?Q?EIYUOhPqKRpIdilJWR/wpXyP5y9XjSpiE/2oKWgsHsEkjFpOKvIqBktIK4xo?=
 =?us-ascii?Q?UbhcolxorFpe1NDlgCG91RUfrkehio+SWQ5fitVhWNy0vEuZvW2JmzamvekR?=
 =?us-ascii?Q?1V1UoOc1xgRktjQa2ypDD6TjEjgrGaHp4SgG/6HMfgsPT49po7M9aKWvFPd4?=
 =?us-ascii?Q?7Nsj0hEE7ygK7V4QCr0vDC6IotorGuPVFRDv4khuMbN3GFJIZKeEmhHb3fVE?=
 =?us-ascii?Q?c62dy0GLafAWYDDmXFRF+ednUoX7PBPSqZ3XaxqO/naWnyAjgduKnushz5YZ?=
 =?us-ascii?Q?Q4RhtfEcWtTt/SfWJJI5MpR5rbZfoo/aCQ5yD59axBQSvjN9b5vMnoZBi0Ou?=
 =?us-ascii?Q?MPbFdbJuZ1XUKgpmgfcfcEaR2sDXqbXQgZr6FWB0FEznuC8o2DDxiGfXhP08?=
 =?us-ascii?Q?syhrZduMBtdbMxpZEhzZBy9BkjPVEtVUuBX5hnV+tJlcr/0KaMBeP9kQZdtC?=
 =?us-ascii?Q?83iq7KWp8ALsjv/DkQYZaJ7UzJkYYYuWuR5byZyRBT4u4FtwS1oPwIAndITe?=
 =?us-ascii?Q?AhBAgARI6RSucBE23HvkWUojr7CuzaS2wLRqtEps0uJp6dnW8h+LjczOX+sn?=
 =?us-ascii?Q?acWw9MzpkNdrz8k9l3wzX+CfeAwMKpo=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 03197a63-c345-4ad0-3579-08da4e7f5e5e
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 03:30:17.8641
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: pA5YuZCuMnOWF6VvtuF1SzI4wtKaevETHuHMtqDDwmlHigmR1h5RNtTZFJzZAPUSHK4jVUK6UlT3C1k7segSnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4458
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 14, 2022 at 05:10:28PM -0700, Alison Schofield wrote:
> From: Alison Schofield <alison.schofield@intel.com>
> 
> The sysfs attribute, get_poison, allows user space to request the
> retrieval of a CXL devices poison list for its persistent memory.
> 
> From Documentation/ABI/.../sysfs-bus-cxl
>         (WO) When a '1' is written to this attribute the memdev
>         driver retrieves the poison list from the device. The list
>         includes addresses that are poisoned or would result in
>         poison if accessed, and the source of the poison. This
>         attribute is only visible for devices supporting the
>         capability. The retrieved errors are logged as kernel
>         trace events with the label: cxl_poison_list.
> 
> Signed-off-by: Alison Schofield <alison.schofield@intel.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
>  Documentation/ABI/testing/sysfs-bus-cxl | 13 ++++++++++
>  drivers/cxl/core/memdev.c               | 32 +++++++++++++++++++++++++
>  2 files changed, 45 insertions(+)
> 
> diff --git a/Documentation/ABI/testing/sysfs-bus-cxl b/Documentation/ABI/testing/sysfs-bus-cxl
> index 7c2b846521f3..9d0c3988fdd2 100644
> --- a/Documentation/ABI/testing/sysfs-bus-cxl
> +++ b/Documentation/ABI/testing/sysfs-bus-cxl
> @@ -163,3 +163,16 @@ Description:
>  		memory (type-3). The 'target_type' attribute indicates the
>  		current setting which may dynamically change based on what
>  		memory regions are activated in this decode hierarchy.
> +
> +What:		/sys/bus/cxl/devices/memX/get_poison
> +Date:		June, 2022
> +KernelVersion:	v5.20
> +Contact:	linux-cxl@vger.kernel.org
> +Description:
> +		(WO) When a '1' is written to this attribute the memdev
> +		driver retrieves the poison list from the device. The list
> +		includes addresses that are poisoned or would result in
> +		poison if accessed, and the source of the poison. This
> +		attribute is only visible for devices supporting the
> +		capability. The retrieved errors are logged as kernel
> +		trace events with the label: cxl_poison_list.
> diff --git a/drivers/cxl/core/memdev.c b/drivers/cxl/core/memdev.c
> index f7cdcd33504a..5ef9ffaa934a 100644
> --- a/drivers/cxl/core/memdev.c
> +++ b/drivers/cxl/core/memdev.c
> @@ -106,12 +106,34 @@ static ssize_t numa_node_show(struct device *dev, struct device_attribute *attr,
>  }
>  static DEVICE_ATTR_RO(numa_node);
>  
> +static ssize_t get_poison_store(struct device *dev,
> +				struct device_attribute *attr,
> +				const char *buf, size_t len)
> +
> +{
> +	int rc;
> +
> +	if (!sysfs_streq(buf, "1")) {
> +		dev_err(dev, "%s: unknown value: %s\n", attr->attr.name, buf);
> +		return -EINVAL;
> +	}
> +
> +	rc = cxl_mem_get_poison_list(dev);
> +	if (rc) {
> +		dev_err(dev, "Failed to retrieve poison list %d\n", rc);
> +		return rc;
> +	}
> +	return len;
> +}
> +static DEVICE_ATTR_WO(get_poison);
> +
>  static struct attribute *cxl_memdev_attributes[] = {
>  	&dev_attr_serial.attr,
>  	&dev_attr_firmware_version.attr,
>  	&dev_attr_payload_max.attr,
>  	&dev_attr_label_storage_size.attr,
>  	&dev_attr_numa_node.attr,
> +	&dev_attr_get_poison.attr,
>  	NULL,
>  };
>  
> @@ -130,6 +152,16 @@ static umode_t cxl_memdev_visible(struct kobject *kobj, struct attribute *a,
>  {
>  	if (!IS_ENABLED(CONFIG_NUMA) && a == &dev_attr_numa_node.attr)
>  		return 0;
> +
> +	if (a == &dev_attr_get_poison.attr) {
> +		struct device *dev = container_of(kobj, struct device, kobj);
> +		struct cxl_memdev *cxlmd = to_cxl_memdev(dev);
> +		struct cxl_dev_state *cxlds = cxlmd->cxlds;
> +
> +		if (!test_bit(CXL_MEM_COMMAND_ID_GET_POISON,
> +			      cxlds->enabled_cmds))
> +			return 0;
> +	}
>  	return a->mode;
>  }
>  
> -- 
> 2.31.1
>