Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Tue, 14 Jun 2022 21:18:34 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     "Li, Ming" <ming4.li@intel.com>
CC:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>,
        "Alison Schofield" <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ben Widawsky <bwidawsk@kernel.org>,
        <linux-kernel@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
        <linux-pci@vger.kernel.org>
Subject: Re: [PATCH V11 3/8] PCI: Create PCI library functions in support of
 DOE mailboxes.
Message-ID: <Yqldmmqdh0HU5/NP@iweiny-desk3>
References: <20220610202259.3544623-1-ira.weiny@intel.com>
 <20220610202259.3544623-4-ira.weiny@intel.com>
 <d67f9d0f-e4c8-35e5-e115-745516655e3b@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <d67f9d0f-e4c8-35e5-e115-745516655e3b@intel.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?AVMD+GRDa3DZx5KJRucHEu+282m1v+LpeSm0EJ7RJHl5BmcId8/h9rbkh3hh?=
 =?us-ascii?Q?T4gLuX2W354+l9vbbWZFaMg8s1w8Jrro/7fH/LMAoc4TxLk3xSbjHKQMkPGL?=
 =?us-ascii?Q?/rbMKIXpXj4T7sfMsnFz/24mzqU+z2DY5PkV69YFhglj0MITmWxnznI59PSW?=
 =?us-ascii?Q?EAzeMOhjWzjaDlevcoDFbpASiIKbVE8xSSkgIFDCN5vEEm7m/uW/6+59QF0a?=
 =?us-ascii?Q?TnL8k60UW7AFmFxmuTX4xC8ICC1jyXIAACqIz9XEiExsrZ1DcuSVs6uIgrmI?=
 =?us-ascii?Q?rPW2+7HoIu9p8aIrMTtcWLDhTW7AM7tOXESJn0tzHtkHnX51AhQqYU005f6e?=
 =?us-ascii?Q?j3BWVEX2pbt+kJpRH8it2mBkNWfjPUszNewY+Xx5UAeDbqcim7osvAK46tl7?=
 =?us-ascii?Q?GWDtU1/N3BR6kXAMZ51k87ougYeTGK0QbMjwzo/lb+aY97LaGBfGxnAm5t1b?=
 =?us-ascii?Q?9HD+plbUaejj7MDSIm/kKTEYJ4LMDhtNqR01WOPVnAQSDgaBxeukC9mgiWJF?=
 =?us-ascii?Q?Ie38insrFBJwQEr8wwldYQLjFhjuRQ8TYB+TxQsMGoDtnXOHnyXWubd7K9hJ?=
 =?us-ascii?Q?WghNSEbpiYnru4mHG+TiwPEEknvQoZdkd3vgvJ764dpiYchDrEe7t5BFhCse?=
 =?us-ascii?Q?zxxFOwyXzW3NJz9xBrXmMuxDs9xGNy3zYpz4iCjM+UVhRgnDx/VN5M0LywuF?=
 =?us-ascii?Q?YPglLLT506JFTIrIUqS/W+jSbSr4RSIJyI+0BqXHsEDfcMyESqjVeVG+2Dh0?=
 =?us-ascii?Q?DdjM0op9QS3TWDVy49qVpUKMnSoFpI2JZRi3tZoRswa62EPyfZY+7t7c+7QI?=
 =?us-ascii?Q?+UYYglinfh5C0q1YL5sf7aJvnHKDYRP1Wy5KqILmBTcyQMszXS/DoO2+HT/g?=
 =?us-ascii?Q?dHPKE9T4jTLWqTzuThxCu0RPiZH+mnSGVvrkQHvDQTIbCQB4uOovCqdvz4T3?=
 =?us-ascii?Q?KJhlP4Hw1vI8ruqYiKIL1ZxhzLkKltOevalMuuAlzJNObol/8ylz/ib2Zp52?=
 =?us-ascii?Q?pmNpsM0HzuDQgSaO3GEKHk23DgnxsCivebg0xNO4oLyLatNY/eIODQljj9c5?=
 =?us-ascii?Q?MClk04KpigGuEOjVHb6pQU8Yq6FOhtxPob9uIgDgPUMewBtWAYYAudHUC21b?=
 =?us-ascii?Q?Ei0YIId1KbMT6DKvZr8Vjqn0e9qZtiU4bGH5fHRj2znjwzt39YcyU3xDgWsq?=
 =?us-ascii?Q?0feKFxlQLtgOYHQ0HGuSAED1WbMxJ5UNcgIEMTYRT0V3v/MFhyH9UFEljj6d?=
 =?us-ascii?Q?MWKkxjlMx2ALWu/GquxnWRjut+TwewoscX5+iNqrxKRiN2zAwx8xbmFPhNg8?=
 =?us-ascii?Q?TlZd4CgDu8rx5NZql5ZXs01axibKLI7MQ92uHnfOdcQ2pMGSGKPfrjYXhvfO?=
 =?us-ascii?Q?zYniOSw2ISDeBIPq2jyJP9Nb7qE//41mZfhnBBic2KaC/DelURZd2CmAeJow?=
 =?us-ascii?Q?cMc1uFVpKKy5IezhBnXiI/I/+Ah6CySHSbo7vhh3ZUwP7KQrxmWtBFZ1++cM?=
 =?us-ascii?Q?/uKB5seqmVLqI5mJ8YWBpNAl7lg40EieD5ODUH0K/aMdY83R3tlDmlzRfWxt?=
 =?us-ascii?Q?WPgSMlvAPWALSaZ29PmZxM58ZAJw+8tniN/kD42i3Tn9d1H6NISamcHyFYBH?=
 =?us-ascii?Q?wIUa4AI8tnMh8AOlof1dDWNtjlUXcGN+BEaD/ukUQLZNhS/X7l3zrRu3jc+5?=
 =?us-ascii?Q?EK/FHKu1eNnIYDep3G/vyKsIkvDbPZ5mTgndy8hWYU0a/tQhxMrVVL2cuaiM?=
 =?us-ascii?Q?POsJ5vTxgKlxzb20LGPRlTOYfi1ZVeM=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 0a6d9d76-f9d2-4bb3-cd88-08da4e86206a
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB6311.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 04:18:40.4363
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: z1ppAwR2V5FaXmQZnbTZAp3epf82154rtqJPIhk9pNokEW/Yf70PuKQtb6wKHF/XSMlLHFvgmCohRVP92xyLbg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR11MB3632
X-OriginatorOrg: intel.com
X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
        SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham
        autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 14, 2022 at 11:53:29AM +0800, Li, Ming wrote:
> 
> 
> On 6/11/2022 4:22 AM, ira.weiny@intel.com wrote:
> > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > 

[snip]

> > +
> > +/**
> > + * pci_doe_submit_task() - Submit a task to be processed by the state machine
> > + *
> > + * @doe_mb: DOE mailbox capability to submit to
> > + * @task: task to be queued
> > + *
> > + * Submit a DOE task (request/response) to the DOE mailbox to be processed.
> > + * Returns upon queueing the task object.  If the queue is full this function
> > + * will sleep until there is room in the queue.
> > + *
> > + * task->complete will be called when the state machine is done processing this
> > + * task.
> > + *
> > + * Excess data will be discarded.
> > + *
> > + * RETURNS: 0 when task has been successful queued, -ERRNO on error
> > + */
> > +int pci_doe_submit_task(struct pci_doe_mb *doe_mb, struct pci_doe_task *task)
> > +{
> > +	if (!pci_doe_supports_prot(doe_mb, task->prot.vid, task->prot.type))
> > +		return -EINVAL;
> > +
> > +	/* DOE requests must be a whole number of DW */
> > +	if (task->request_pl_sz % sizeof(u32))
> > +		return -EINVAL;
> > +
> > +again:
> > +	spin_lock(&doe_mb->task_lock);
> > +	if (doe_mb->cur_task) {
> > +		spin_unlock(&doe_mb->task_lock);
> > +		wait_event_interruptible(doe_mb->wq, doe_mb->cur_task == NULL);
> Hi,
> do we need to check the returned value of wait_event_interruptible() here? if the returned value is -ERESTARTSYS, I think we should not try it again, just return.
> 

I'm not 100% sure it is necessary.  However, I don't think there is a point in
trying to continue if a system thread is interrupted.  So yea I think this is
a good idea.

Ira