Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp140876iog; Tue, 14 Jun 2022 21:56:51 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vGUKE3fEtJ4XV/tPALwljs9yECMFAYwCwsZwjywASl9T8VInrjb/5bZf8DrOkTOaCcsnJS X-Received: by 2002:a17:907:16a4:b0:711:c9a7:dc75 with SMTP id hc36-20020a17090716a400b00711c9a7dc75mr6891199ejc.542.1655269011459; Tue, 14 Jun 2022 21:56:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655269011; cv=none; d=google.com; s=arc-20160816; b=RMlX5EbgSXQ2Fft0bXMsQhWYgMz1dU8G9AOW8WTLDuw2Ad3NSq0iA+6o5Orr76yo67 hXaH7dIMNjdP/iRTdNDhSr57WM8FHk+t78M8iU7Si4pUTO9ajj6NCyexXMOF6k5XOzuP 3m8oacLDXYXpGrdXrgi8CxGK1vUx6CkmvFCNRunkID3yS5YLEvQKK0LMKOHdWMAP8AW7 rwG3usNBitG+V570OC4LJXGMoFX8zB4wCot0kLMlfGPKdM5/2kIDazPobUYHS1HS40gW GrKL5/7Y7LucF7gE55tQEMdfiTTrbvToz0P3WQ5GjEyuCsdoFJREa/2cg5zx6JxiPJsw XSng== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=ODnEFjhb4yi3dxNHweB/FuzwlCaUy1FxCUv93kTJCtY=; b=em8YgTXbC46RZIxs19u+THyZ+X3iSnfkBi550zCdBoaCE/t2OM+O1bk9uI+fpmztzn rBdFZYC5jzM0o1N49OMskCY73YgZ58+5ILGizXmhiV2qi8qGzgSFCRJ1xkTqWr0D0XNO +MQ+7MNBg6xnvSGfWqZIgbMgXnNcR1Q7YglEJnoNKJEI81RVPO7n1riFounkBdaEx8JI KCRcFLJOOl5GQMqsaNrMAwdtOl1Iofk5wJZJnC4K8Ns+OzlkdehBA+0jeNk6lPU4R9Ra DAGY4EPHQw5/oA9mv64uUb/rNICuIUvf7Hd3TyjYKffZMfRVN8IMFKK0ub0pyf1JN+Vu qNrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eN6ClbFv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id k1-20020a17090627c100b006e81dd29c00si11954361ejc.569.2022.06.14.21.56.24; Tue, 14 Jun 2022 21:56:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=eN6ClbFv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237398AbiFOEuQ (ORCPT + 99 others); Wed, 15 Jun 2022 00:50:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48712 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229579AbiFOEuM (ORCPT ); Wed, 15 Jun 2022 00:50:12 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 42E092C647; Tue, 14 Jun 2022 21:50:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id E0D33B81BF5; Wed, 15 Jun 2022 04:50:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4FBBC34115; Wed, 15 Jun 2022 04:50:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655268608; bh=82TOJasF/muXbREfaUDPGBV9l+FQHMiVRx8XVZhvBDU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eN6ClbFvtBOBDoGCEOtQkJJRbyKIdfNmmd7ZNy0V40+srmZ/PPJjKUluwiAPNzx8L NKk0NnP+0NqM0jyU6wGUu5PuNqt9qOACssbHNnHL4MvSbpIjOjlSouxY0y/kfjGH+5 2YFs239k+qSs0aG8xhPtx7XpusSiglzSKwCvaTEmMCJO2DoMMiogFu3i/ExOe/yA2y YrrI90rtvNRjkRvzFlYZh0n0aGUC7QHJKA2Q4nspBeEXln0Ims+V3AYc7unDFp9BmU 9wWXKaNN5MrqFDOMZzn7Ns6IMgKcIup+r5hrAsLDyv6GqIDywiQzozENYf0evz123a 03STYYhIpuT6g== Date: Tue, 14 Jun 2022 21:50:06 -0700 From: Jakub Kicinski To: Sieng Piaw Liew Cc: davem@davemloft.com, edumazet@google.com, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] bcm63xx_enet: reuse skbuff_head Message-ID: <20220614215006.67893ec1@kernel.org> In-Reply-To: <20220614021009.696-1-liew.s.piaw@gmail.com> References: <20220614021009.696-1-liew.s.piaw@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 14 Jun 2022 10:10:09 +0800 Sieng Piaw Liew wrote: > Subject: [PATCH] bcm63xx_enet: reuse skbuff_head Please improve the subject. One verb and one vaguely correct noun is not good enough. > napi_build_skb() reuses NAPI skbuff_head cache in order to save some > cycles on freeing/allocating skbuff_heads on every new Rx or completed > Tx. > Use napi_consume_skb() to feed the cache with skbuff_heads of completed > Tx so it's never empty. > > Signed-off-by: Sieng Piaw Liew Please keep Florian's Ack when posting v2.