Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp161276iog; Tue, 14 Jun 2022 22:38:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uVrwsWP/nhG88DeBOfETh+P9HKnM5gQMIHk/C/aCCxDHIHFM8EUePfOJ/dKS1AW+e6EWAJ X-Received: by 2002:a17:90b:464b:b0:1e8:7881:b238 with SMTP id jw11-20020a17090b464b00b001e87881b238mr8397869pjb.166.1655271511017; Tue, 14 Jun 2022 22:38:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655271511; cv=none; d=google.com; s=arc-20160816; b=cyHTkO8jXPolBSGhwsymZ9VIT7yVzmQ2om6b1i+AIAvoNY9tnTwwstfoHSPo+NJNhw 4/Yi+86dZkvyWkbEXqOiGUUlUCV97xM6mX8L1h93AK4kpduk+T2ixJRRk2ShpEyR84n1 9WYEy8ravPAva7U6thW4OsVASNRmwIfOujCgRyhHkGRiGuuJAm2nlfIwEAJb9viM7lcS P7hL8bVUtKEGasJh352O7jlkMLxj9PFfe1Z0YaeVRGEliUa5Io6ctChLX2lmyR9l86/2 XYDIksi4Y/6siPOXb6/bryBbtPwvaQtQErGlbDKDs192lolAbZJJY/ucI9oHOJ65abS7 EniA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2mfxXdcO1dK4et6ykRFAjrd6+Ggs6ho4yU0Ep3+Palw=; b=radPrHUTCg94o229DXX7TjCzi9vvzPNUiTrb0TVZJBkorhH0LOzWkURzdGQHJ8H5eF Kz0jME2yiAun97sJw9fBu6tcuoFfZi54hiKWrvkNjL18w5lrl0nnRxlGxD7N74okXs9F XX7VK3Otf5TFXvhhyOc3HYH/8R/tyuFfj2CB2iAL2yS05/YumBHaRjzNMjNBNp5yLH9L nCiLlJ+kxY2paVeLRV6FPD9BdJ/HRm2rrTL3BqGN7DojMi0uY3H0KMaoA1BSvqcv3vjY aGKmZkgx49lups9+iWNNCADBKVbyvOXmpQi0AXQ3SsoIfys+8t3Jw2cRXcXm9rWRFQTL mZWQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f5sOmv6F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y18-20020a17090322d200b00168af344903si18296936plg.583.2022.06.14.22.38.14; Tue, 14 Jun 2022 22:38:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=f5sOmv6F; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345946AbiFOFN2 (ORCPT + 99 others); Wed, 15 Jun 2022 01:13:28 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37214 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245729AbiFOFNM (ORCPT ); Wed, 15 Jun 2022 01:13:12 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 31E0D27B0A for ; Tue, 14 Jun 2022 22:13:12 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B1D0C6164D for ; Wed, 15 Jun 2022 05:13:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 424DDC3411B; Wed, 15 Jun 2022 05:13:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655269991; bh=5SLS/K/WO5NPoG6nosQIx5zbsicGDMXiC+LrsQiUdaE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f5sOmv6FSap7n32AGDTO3VcIvuGYBym1VQoFHYYEymvyDUZcEuoWozMtlHsxNhvQD TFAYl9kmtOsBiBeRS6quY6woXPiFPrrrs45zEYpVlqdYI8KeCrCkeyUxbUiCVvePzn IrO/9psvEMHZJmzpNAEwGG04INLPyAlBZPbOOdTROG4ZNgaDOt1r9+PiI+YZca+mlS eL+g8emG9HtHD/YKONkbQSrl5bRWF70qD3m6AHhQr/VXOtdEjLFfWYyx2S24gEeI7n 9OvLw0YxluuK5cvfasF2dDzI7KnSos6vlHTCsPDLt/tshK8f3eIt66R8nq9QFAxLA8 r/7rddHzXC0Gw== From: Tzung-Bi Shih To: bleung@chromium.org, groeck@chromium.org Cc: chrome-platform@lists.linux.dev, tzungbi@kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/11] platform/chrome: cros_ec_proto: change Kunit expectation when timed out Date: Wed, 15 Jun 2022 05:12:43 +0000 Message-Id: <20220615051248.1628156-7-tzungbi@kernel.org> X-Mailer: git-send-email 2.36.1.476.g0c4daa206d-goog In-Reply-To: <20220615051248.1628156-1-tzungbi@kernel.org> References: <20220615051248.1628156-1-tzungbi@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While EC_COMMS_STATUS_PROCESSING flag is still on after it tries EC_COMMAND_RETRIES times for sending EC_CMD_GET_COMMS_STATUS, cros_ec_wait_until_complete() doesn't return an error code. Change the expectation to an error code. Signed-off-by: Tzung-Bi Shih --- drivers/platform/chrome/cros_ec_proto_test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/platform/chrome/cros_ec_proto_test.c b/drivers/platform/chrome/cros_ec_proto_test.c index 64100fd81c6a..fbb872040711 100644 --- a/drivers/platform/chrome/cros_ec_proto_test.c +++ b/drivers/platform/chrome/cros_ec_proto_test.c @@ -1870,9 +1870,7 @@ static void cros_ec_proto_test_cmd_xfer_in_progress_retries_status_processing(st } ret = cros_ec_cmd_xfer(ec_dev, &msg); - KUNIT_EXPECT_EQ(test, ret, sizeof(struct ec_response_get_comms_status)); - - KUNIT_EXPECT_EQ(test, msg.result, EC_RES_SUCCESS); + KUNIT_EXPECT_EQ(test, ret, -EAGAIN); /* For EC_CMD_GET_COMMS_STATUS EC_COMMAND_RETRIES times. */ KUNIT_EXPECT_EQ(test, cros_kunit_ec_pkt_xfer_mock_called, 51); -- 2.36.1.476.g0c4daa206d-goog