Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp174783iog; Tue, 14 Jun 2022 23:05:51 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uWUuwi1D/O89v4vmaALHTg3+aycTqDVV6qh5n7cEss8enwdCiFwN9WEpURCV57Ty+YIyDg X-Received: by 2002:a17:906:1501:b0:715:76d0:862a with SMTP id b1-20020a170906150100b0071576d0862amr7338209ejd.681.1655273151381; Tue, 14 Jun 2022 23:05:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655273151; cv=none; d=google.com; s=arc-20160816; b=OIRUwIKlZ2kYUaewP5SsFPPCgQozWhzLSSAjhkEHfO4lW+iYzcqgrkmOfDZPCuL/ku C4Fx6dkOasVdTt9CtHPfaB5YrDLACmtXXSeOGdeLYpiB+Lq8dXNR5Hg7qkOovNpkeMo2 0KYdKzdFYLq6qrIAWJEd3duSBTgeXb34ywnazwhMZtLZHHy0BmF2iFs6CCDTlxKa0MBl UDRN6eyVx+wpCj42QZKhcN1K1HSCbyM/H1NTIsIXxXY6No3bS0/tMr0xiSvlzb6DmQWG J20h5Upgs09Uvm+7DPHt+AaZ2PFadeM1fyLs6WA4rlLqxHmBYmGU71kVuCwsSB19BYNM VV9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=e1Vf5ybmWHMCCare0qDg8SwPPoQD0QhbtYBYyxeUrq8=; b=MhQRSggwc9vIEthlPoEXmKjb90GsRK0KhQHhF3h5JpllFSC2LpA/E62vuKTDnDHN6+ 9gAjYuWYyx7ikqm0tmX+kEYTRkP93i00nC1cHQHcoumRWOp4XfClyFonV1YKRhgBTQTf 8iJwl/Vwb4XOMEIapDyC3P6o3wZIsZo2gPCT6bLWdKHKH4W3v6WAVF07aPQeTUtusTgr GgQ8WHqtrcR+ND76aM0hKdHPv+7ehY9BqUt2OG/iGjsMHQT1VifLXsG63bvowR61Jl7g ctmDNll/XpEUFQnkamnL7d9RzwiyJ7MylcQJRvyn/FKZvHWPA/a6jgOXTaLaLeyWe81+ U7nw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Ag1aXw2j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sa35-20020a1709076d2300b00711d89b831esi14206448ejc.721.2022.06.14.23.05.25; Tue, 14 Jun 2022 23:05:51 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=Ag1aXw2j; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344650AbiFOFuh (ORCPT + 99 others); Wed, 15 Jun 2022 01:50:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41366 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245020AbiFOFud (ORCPT ); Wed, 15 Jun 2022 01:50:33 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6955B33EB3 for ; Tue, 14 Jun 2022 22:50:31 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id x5so14540232edi.2 for ; Tue, 14 Jun 2022 22:50:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=e1Vf5ybmWHMCCare0qDg8SwPPoQD0QhbtYBYyxeUrq8=; b=Ag1aXw2jvTVA7zj000m0mm7g4v9LClriU8HKZSHDqkV7VWJ6TW0872btwmRL8YOhHv /h0UTPqYTWMypwvjlp7HFBfG74+NiYztO1x+sVfz4FEI6DuU4uxDrtoNMI9vIL7+pkLT KBJyXI31qr4bl59ihqAqPeS5UGX2uWtkyAwyw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=e1Vf5ybmWHMCCare0qDg8SwPPoQD0QhbtYBYyxeUrq8=; b=dCSRFD4LJB7HoHQeXxTOq4wGhoQDjXxVQg6rzi8tmsvMY1xt3ghjP7ncq9FNSWv/p6 wYHjVgXbrRv+9aWVwp5wG4JqP27zJoieYnPQGUgCaS3cQNy6qkcZa7dAdM/BurFNckvO Y+WZraN10lWwFvmMClsYIeu7s1kZY3+Z2WfOORBgZVkDkkshz9n52foDg5Ddh9YIrt/q pNfxRsuFM6Uw/QGtAobi8XwZUr9jO2qkP/9SyrkGs7OuPd98ReRLzjh8jPg9pPQszB37 Wceu9dwAzngLfIZa7eDeZ14LzMLzLs8hLowt+pEPvXc41YnIlRzsr9zxlqArs/rn6pEW jI8Q== X-Gm-Message-State: AOAM532fQTXrnB8TKd+84mL/JoFzBzN35+cwDDLLESdq0c6Ubr2uWgQX oCO2SQjdCM0YcMRJI1kME1JX2MuXjxFtgkF1npv/Ug== X-Received: by 2002:a05:6402:1941:b0:413:2b5f:9074 with SMTP id f1-20020a056402194100b004132b5f9074mr10516814edz.414.1655272229642; Tue, 14 Jun 2022 22:50:29 -0700 (PDT) MIME-Version: 1.0 References: <20220609072722.3488207-1-hsinyi@chromium.org> In-Reply-To: <20220609072722.3488207-1-hsinyi@chromium.org> From: Hsin-Yi Wang Date: Wed, 15 Jun 2022 13:50:03 +0800 Message-ID: Subject: Re: [PATCH v7 0/8] Add a panel API to set orientation properly To: Hans de Goede , Sam Ravnborg , Stephen Boyd , Douglas Anderson Cc: Thierry Reding , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , Philipp Zabel , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, Rob Clark , Rob Herring , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 9, 2022 at 3:27 PM Hsin-Yi Wang wrote: > > Panels usually call drm_connector_set_panel_orientation(), which is > later than drm/kms driver calling drm_dev_register(). This leads to a > WARN()[1]. > > The orientation property is known earlier. For example, some panels > parse the property through device tree during probe. > > The series add a panel API drm_connector_set_orientation_from_panel() > for drm/kms drivers. The drivers can call the API to set panel's > orientation before drm_dev_register(). > > Panel needs to implement .get_orientation callback to return the property. > > [1] https://patchwork.kernel.org/project/linux-mediatek/patch/20220530081910.3947168-2-hsinyi@chromium.org/ > > Hsin-Yi Wang (8): > drm/panel: Add an API to allow drm to set orientation from panel > drm/panel: boe-tv101wum-nl6: Implement .get_orientation callback > drm/panel: panel-edp: Implement .get_orientation callback > drm/panel: lvds: Implement .get_orientation callback > drm/panel: panel-simple: Implement .get_orientation callback > drm/panel: ili9881c: Implement .get_orientation callback > drm/panel: elida-kd35t133: Implement .get_orientation callback > drm: Config orientation property if panel provides it > hi Maintainers, All the patches are reviewed. If there's no other comments, will this series be picked? Thanks. > drivers/gpu/drm/bridge/panel.c | 34 +++++++++++++++++++ > drivers/gpu/drm/drm_bridge_connector.c | 8 ++++- > drivers/gpu/drm/drm_connector.c | 31 +++++++++++++++++ > .../gpu/drm/panel/panel-boe-tv101wum-nl6.c | 12 +++++++ > drivers/gpu/drm/panel/panel-edp.c | 13 ++++++- > drivers/gpu/drm/panel/panel-elida-kd35t133.c | 12 +++++++ > drivers/gpu/drm/panel/panel-ilitek-ili9881c.c | 12 +++++++ > drivers/gpu/drm/panel/panel-lvds.c | 13 +++++++ > drivers/gpu/drm/panel/panel-simple.c | 14 +++++++- > include/drm/drm_bridge.h | 14 ++++++++ > include/drm/drm_connector.h | 4 +++ > include/drm/drm_panel.h | 9 +++++ > 12 files changed, 173 insertions(+), 3 deletions(-) > > -- > 2.36.1.255.ge46751e96f-goog >