Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp185807iog; Tue, 14 Jun 2022 23:26:17 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tYIcicbzxb/sgO6lr6w/pxP+vQ5xFfArlaOJqhuIMqm7s8Zu3hiNnCxHTD8uO5AU5at3oM X-Received: by 2002:a17:90b:3ec2:b0:1e8:9ca4:8d55 with SMTP id rm2-20020a17090b3ec200b001e89ca48d55mr8511138pjb.123.1655274377300; Tue, 14 Jun 2022 23:26:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655274377; cv=none; d=google.com; s=arc-20160816; b=TqcyAQM4uqeAU/y+ZRExmvwnC/wqAf7+GFo0f7hEyMKNnnNj+9TlAoQRVdg2i+TCwF QJs7x8ibQx0tq7fmm2cV4k8owTdDeugkQe+yYdxoBsd1xSnk6LXY1M8otmAZ2IMqlwlq 8LAjrPFctCVVVj246USTCmFoZSn9Nqmlygd3Gr+41LI0Gf3TlVtGRfBOAjZDlv2H+Jow P/XyHeOLImOqJulJaicIYPWPca21lHikGmibdxeOJ24NRkf0xHwRrwwRPTDIyuY+fYOP 84PAfy7IYs1Fb4xXDRiVdpY7iT6W3A19dCkY3q1UzM401kVBY90hLMs+2Yk23H3iLTXW 7/xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:sender:dkim-signature; bh=hnoGBQrPK85JCgl7rQ6imQVPKzB/FybzwpvvNmXqIKY=; b=SGOgzJPxX8JjlQBjzuHBlA1S8hFIUGriLkSjKrgzn+mG3Hw8Kts+z0F68+zQUxR9pJ 3XZ3AR1frdym87NcoYAOu9AUosBZWTL8eBKY++1SPuQMCz2FQpfyrU2NBdbBxVOmPqzy 50jhjRmW29orYncgioxYA7HB72K8Id6bHP2q/hHmOgdzP8rY3dcVqHiLUA4DtDuJz+6Q LzA6OwajqschrMC8x4YaBmoI5NWk6SSFej2+vR+we9r9991d22V8xVsvHoTZQyXxBX0e 2/K3hFHVcMxNe8FpM2HL15MysPcF8p953+jdnTdS65LpJwblQxyx5aW1cqIGubyguqkV KHCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WLMMRgsX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r2-20020a635142000000b0040330b0c147si15146440pgl.95.2022.06.14.23.26.05; Tue, 14 Jun 2022 23:26:17 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=WLMMRgsX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1351828AbiFOGNG (ORCPT + 99 others); Wed, 15 Jun 2022 02:13:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60524 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235477AbiFOGNE (ORCPT ); Wed, 15 Jun 2022 02:13:04 -0400 Received: from mail-pj1-x1031.google.com (mail-pj1-x1031.google.com [IPv6:2607:f8b0:4864:20::1031]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7017FF02 for ; Tue, 14 Jun 2022 23:13:00 -0700 (PDT) Received: by mail-pj1-x1031.google.com with SMTP id gc3-20020a17090b310300b001e33092c737so1080124pjb.3 for ; Tue, 14 Jun 2022 23:13:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hnoGBQrPK85JCgl7rQ6imQVPKzB/FybzwpvvNmXqIKY=; b=WLMMRgsXjHgKczW//3IeInWXQPBfsmbj+BXYrzWq92EClweHfYIR7eZ6NbuyFl62/Y 6oRSnst+XAYUKcSaRqCmUnV0H5e5WH+cePk+Q5HY5pD9eWTZwE+sATWal8X03i8LUTTh oimN8v4xKvy6HnJLNYVloGbg229q5KZJTh3cCR5M2FeP0Y02AAJBf6AGfiazK0vjFoqe i5dxA6h83+ADSomF53F88KjY+ITVcB6z5GJVz+Sh5Fn1AM1eID8fv3QlEnWGKtcrm/Lx FQkQzd7PNbiXvjQP5J8XfdiDdQDTQHQ/FwiD2vupF0AAb0VrFGPCak4vsOlXd34xjm+p eHQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :references:mime-version:content-disposition:in-reply-to; bh=hnoGBQrPK85JCgl7rQ6imQVPKzB/FybzwpvvNmXqIKY=; b=KXAqX1kZT9wjU7vsdI8sBlPkdHusQj7wtMo/6/+tBok/va1iKthPVk0+Xsc955SsC+ FwVid58vGG42NPkEZxiKRxnteohvcNcPcnpyrpaPDda2VXHQa5dsheFOEPpNyxk4Wuek //dW6TmlN+FoLsS3Io1KBwv77XQCE5kpRoIT9738GisnD1O9k4KMKEDYC0JJdp2zHCai O0dWOSua3RxpF0r+vcmSt6meEZ59h+WqDRvKXTPVxvk+CZH1mVkQc4mY0tSGqW2OI0Z3 6X6NJ0uxOaBVgYCJ7OsUnv806+15lZqgDkrF5AdQd4g/MNr2rwyuiIdoPFgdDvmfJfjw 5nQQ== X-Gm-Message-State: AJIora+lBIg53vHYo88xlZ6n3I4gD2w3ofegXQ3zFYp8RMdnyPqNzKxh 4HAvYZvAhG3iFVReVuAG15k= X-Received: by 2002:a17:902:b689:b0:167:8b69:d1a7 with SMTP id c9-20020a170902b68900b001678b69d1a7mr7654020pls.156.1655273579783; Tue, 14 Jun 2022 23:12:59 -0700 (PDT) Received: from localhost ([2620:10d:c090:400::4:7e4d]) by smtp.gmail.com with ESMTPSA id w62-20020a628241000000b0051bfd13809fsm8808247pfd.119.2022.06.14.23.12.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Jun 2022 23:12:59 -0700 (PDT) Sender: Tejun Heo Date: Tue, 14 Jun 2022 20:12:57 -1000 From: Tejun Heo To: Imran Khan Cc: gregkh@linuxfoundation.org, viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org Subject: Re: [PATCH v7 1/4] kernfs: make ->attr.open RCU protected. Message-ID: References: <20220615021059.862643-1-imran.f.khan@oracle.com> <20220615021059.862643-2-imran.f.khan@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220615021059.862643-2-imran.f.khan@oracle.com> X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_EF,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 15, 2022 at 12:10:56PM +1000, Imran Khan wrote: > After removal of kernfs_open_node->refcnt in the previous patch, > kernfs_open_node_lock can be removed as well by making ->attr.open > RCU protected. kernfs_put_open_node can delegate freeing to ->attr.open > to RCU and other readers of ->attr.open can do so under rcu_read_(un)lock. > > Suggested by: Al Viro > Signed-off-by: Imran Khan Acked-by: Tejun Heo Thanks. -- tejun