From: Alistair John Strachan <s0348365@sms.ed.ac.uk>
To: richard.griffiths@windriver.com
Subject: Re: [PATCH 2.6.21] cramfs: add cramfs Linear XIP
Date: Wed, 23 May 2007 09:21:32 +0100
User-Agent: KMail/1.9.6
Cc: Linux-kernel@vger.kernel.org
References: <1179871779.24163.11.camel@localhost.localdomain>
In-Reply-To: <1179871779.24163.11.camel@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200705230921.32974.s0348365@sms.ed.ac.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1534
Lines: 45

On Tuesday 22 May 2007 23:09:39 Richard Griffiths wrote:
> Venerable cramfs fs Linear XIP patch originally from MontaVista, used in
> the embedded Linux community for years, updated for 2.6.21. Tested on
> several systems with NOR Flash. PXA270, TI OMAP2430, ARM Versatile and
> Freescale iMX31ADS.

> +#else /* CONFIG_CRAMFS_LINEAR */
> +        /*
> +         * The physical location of the cramfs image is specified as
> +         * a mount parameter.  This parameter is mandatory for obvious

You've used spaces here instead of tabs, probably worth replacing.

> +/*
> + * We hold the mm semaphore for reading and vma->vm_mm->page_table_lock
> + */
> +static inline void break_cow(struct vm_area_struct * vma, struct page * 
new_page, unsigned long address,
> +                pte_t *page_table)
> +{
> +        pte_t entry;

Here again.

> +                        /*
> +                         * Handle COW of XIP memory.
> +                         * Note that the source memory actually isn't a ram
> +                         * page so no struct page is associated to the 
source
> +                         * pte.
> +                         */

This whole section too.

-- 
Cheers,
Alistair.

Final year Computer Science undergraduate.
1F2 55 South Clerk Street, Edinburgh, UK.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/