Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 15 Jun 2022 09:33:22 +0200
From:   Marc Kleine-Budde <mkl@pengutronix.de>
To:     Max Staudt <max@enpas.org>
Cc:     Wolfgang Grandegger <wg@grandegger.com>, linux-can@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Vincent Mailhol <vincent.mailhol@gmail.com>,
        Oliver Neukum <oneukum@suse.com>, linux-kernel@vger.kernel.org,
        Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Subject: Re: [PATCH v8] can, tty: can327 CAN/ldisc driver for ELM327 based
 OBD-II adapters
Message-ID: <20220615073322.6nbdumfcztnybsgz@pengutronix.de>
References: <20220612152601.142314-1-max@enpas.org>
 <20220612155654.ij53kpw7cscj53nk@pengutronix.de>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="b7j72yanl6ow7ifw"
Content-Disposition: inline
In-Reply-To: <20220612155654.ij53kpw7cscj53nk@pengutronix.de>
Precedence: bulk


--b7j72yanl6ow7ifw
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello Max!

On 12.06.2022 17:56:54, Marc Kleine-Budde wrote:
> > diff --git a/include/uapi/linux/tty.h b/include/uapi/linux/tty.h
> > index 9d0f06bfbac3..68aeae2addec 100644
> > --- a/include/uapi/linux/tty.h
> > +++ b/include/uapi/linux/tty.h
> > @@ -38,8 +38,9 @@
> >  #define N_NULL		27	/* Null ldisc used for error handling */
> >  #define N_MCTP		28	/* MCTP-over-serial */
> >  #define N_DEVELOPMENT	29	/* Manual out-of-tree testing */
> > +#define N_CAN327	30	/* ELM327 based OBD-II interfaces */
> > =20
> >  /* Always the newest line discipline + 1 */
> > -#define NR_LDISCS	30
> > +#define NR_LDISCS	31
> > =20
> >  #endif /* _UAPI_LINUX_TTY_H */
>=20
> Greg, do you want the include/uapi/linux/tty.h changes in a separate
> patch and upstream it?

Please make this a separate patch and send it to Greg similar to the
N_DEVELOPMENT patch.

Once this change is in net-next/master I'll merge the can327 driver.

regards,
Marc

--=20
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

--b7j72yanl6ow7ifw
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEBsvAIBsPu6mG7thcrX5LkNig010FAmKpiz8ACgkQrX5LkNig
012WVwf/R4eTxzSLZXjfph/6QT8XMx5pdIgG281OtBPuG+8b+u2++o6g/6sKpvEc
dqz4I55UfLMEOHVK6SBlpMf1QFnpZ/34PhnZppPAOrqqh1peBJ8+qTHq6jvVApMt
La5d4KSkD/XN1ZRbRP3pzTw1Wyzq5+0MIGS9biZedLO8V8mGx7JhlKoU2FjJGLdd
ti9KSwR8oxcemzK43LLHjNqNds/H0F2LxVcTXbY+1ndx0MZmLfT0rmwEjx2oIHYl
+UzeXbf9YOPkXtKnCaibeDCjMnddo3/2LjPoSLs7M4gU8df6Z3KovlGDFaMx7Te/
5z2z9vhFWraDKSQgMEKQVNAMmcZypg==
=ud73
-----END PGP SIGNATURE-----

--b7j72yanl6ow7ifw--