Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 15 Jun 2022 11:29:41 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Nam Cao <namcaov@gmail.com>
Cc:     gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
        linux-staging@lists.linux.dev, phil@philpotter.co.uk,
        Larry.Finger@lwfinger.net, paskripkin@gmail.com
Subject: Re: [PATCH v3 0/2] get rid of confusing macros
Message-ID: <20220615082941.GL2146@kadam>
References: <YqhWIiXadDC3hzel@kroah.com>
 <cover.1655220367.git.namcaov@gmail.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <cover.1655220367.git.namcaov@gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?GuyaMEFmxPUE4L6dLfa5VCnx4a1pbO+miX39bOwXOq8f3wPX9NPhot3P34zG?=
 =?us-ascii?Q?jbJfPkGlAoKwWsnQlnwoJqSVWdhoOb1MshyBtbS5rvucpMC3HBdyRiHAp9Hn?=
 =?us-ascii?Q?ov5N3q9+ONxv77yN64CGjHKle3q2k/Zu/kZHUTmrscehMPLz8TjDJsW6vlJZ?=
 =?us-ascii?Q?FsnwmmvH1te4ht2+F8lzopw4koNNLHi6fvkzJN9WGg1irG+qk5jaaZ2snkDD?=
 =?us-ascii?Q?YmpyKbcFUPq6eRchzttoZSxChbu/vlhwr6QyLeTvNSvgCG/dYTeBJf2s+Mf4?=
 =?us-ascii?Q?AfiP7xblFyi7oPIQZFuo3k4q6ZGhBqk6DmsKAvNYb+Z/HVkW97wrOHbWGd93?=
 =?us-ascii?Q?ln3DQi+Au+SUN9ssq9LCK0SV0Ry1XtlH5SHjFJ5i2D9z/+4NeKoZCo5EP/PA?=
 =?us-ascii?Q?+OK1yrQtadKCw7KNkUdePVIYmKkELhIbKinguID0vHeSNG9njxNgz9RuTSCK?=
 =?us-ascii?Q?qnpgZnf/XqJP4vFx6ohQYSl86TpSOYI3fYxFjlXcoBykbxBAaqyVjNT8nyzd?=
 =?us-ascii?Q?MctVaD2Unn/i4THtHKCRHtw6v0PS5WkQz+dxRBzBjOAA6nVCi2beW9wRu7kK?=
 =?us-ascii?Q?Wqxzut8WoshaxHYCPD1CULSt5b3+3UdmLaFi7VKWvGqAdmiCHwQChObLqDEz?=
 =?us-ascii?Q?YE8iHKZUn5kL2qARdImVDnd6FtYjZqLKkb65u6LuBKDPS4mmhNcNymhjkHf1?=
 =?us-ascii?Q?mNKioPE4XYRCosaP7uG4q1exVF6kRR7h28Zk7ahe6Z1ufJQ/p8Ie5O2yhG2Q?=
 =?us-ascii?Q?Sk5rQ0Iag+ZDXZ2d0A3VUe9sxnUKao5Wzl7njqNh/+1UIErB7FvinCA9UffM?=
 =?us-ascii?Q?i/azi8AcjFrewvbscE/VyfruJJxBGWUVKrmPpnjrmigEbvABHucX2OIX7pG2?=
 =?us-ascii?Q?cPLgo5CZzAxgguVXKFTnPZOl15pqoGWFyyVBnJ/s3pa0vLHczF45aHkzbJ63?=
 =?us-ascii?Q?5e4I5942NT8vLU/Diw0kEX+f8sU7edfYZmj0SWX3kIPBYo8xmCoCWiFjqFGB?=
 =?us-ascii?Q?/ArKBAqQmUbARiBG3k0Ll/EAwNJa4i8s1gEIXSs+McOMmRl9wg35Ytngwvq2?=
 =?us-ascii?Q?c+krJqtiJy6rvQO8gE0Iuezn5SbonhNPibUpAbMzXr02JfRfe4uZRA9n8xh8?=
 =?us-ascii?Q?RkOyRMeLjhnULaQpNHuxE6xRrh9SrwV9n5ovjbRMTAIn67gw9ApjQAudHVv8?=
 =?us-ascii?Q?oUXSmOeEZsgd+JSTuE1A0kCEamf/PRWmQmERHqqd53/80FUFxsqOoF6H7HxA?=
 =?us-ascii?Q?Js/ltfDCKA1iyQ/DXwLgxCC0FF/Cx7yB+Dva2c8K10Nq2pmJRE8qEDV63zKY?=
 =?us-ascii?Q?ESDfDNClIOKtuHDfaWvI/tAYzGpkZK6YXz9n6mzh8w3tEHARQXHAzL/pk81I?=
 =?us-ascii?Q?1qrBDfuswoZzse1PXQSJR3I2dYc03eHlksHawxYJXtY6NGbnayzxMO098X+1?=
 =?us-ascii?Q?VviEFN7MZ1vSLf3OR2Jt/X+VoB/4IndbUGnj9GX2eYtxtEF/zPxOVa9lirJm?=
 =?us-ascii?Q?Flea0BsD2LFnBqfZzxhLXWsTSby/q4oSjaYR59qOZShel6lT8xyCAxIbgbRS?=
 =?us-ascii?Q?ZnsqBQyyJaHuTju4hzkaUsTbM5QMvZO51wOW5k2iNA+WJT89pgEh6Aaxxp/E?=
 =?us-ascii?Q?XGKDE09buRCh4/yXgpsp0c8XxSycM/Yyseq3JfEghiZTYtCWsVYPThsiXWSQ?=
 =?us-ascii?Q?uOq1uoGUPPpzbCeELp+mlxwxC+PzP3/sTjbqkpsJPb1FGhMJ3wTt8FrMsUOe?=
 =?us-ascii?Q?J8xNnISf9jCjnMdy0aLT/4aZ6Sx8pSI=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 0de2cdfd-2a6e-496e-51ce-08da4ea93d97
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 08:30:01.7519
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 2wuhuHLoR8UyJUINWyoMAgyUdQRJC3v5Qfj3SWWdeN7Y0WuWt75CHRTwY7sYIKif3K7GpNGdO9N84pU6pVoqhCDjhvk7+kIUh/vkIMkwrME=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5612
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-15_03:2022-06-13,2022-06-15 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 spamscore=0 adultscore=0
 mlxlogscore=965 phishscore=0 malwarescore=0 bulkscore=0 suspectscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2206150030
X-Proofpoint-ORIG-GUID: 11xptC2oMjihfnfphX6J5rDtQO6L4ybM
X-Proofpoint-GUID: 11xptC2oMjihfnfphX6J5rDtQO6L4ybM
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 14, 2022 at 05:58:43PM +0200, Nam Cao wrote:
> Replace some confusing macros with more explicit codes.
> 
> V3:
>   - Get rid of GET_TX_REPORT_TYPE1_RERTY_0 and similar
> V2:
>   - Split into smaller commits so that it's easier to review
> 
> Nam Cao (2):
>   staging: r8188eu: replace confusing macros
>   staging: r8188eu: remove unused macros

So much better!  Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>

regards,
dan carpenter