Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp317922iog; Wed, 15 Jun 2022 02:55:45 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uPJIpjqzVWKRn1Snj1/oyr0GFNzcDHZ/itNqPc/dLxPdhPR95PNGTeb9EyivthukBV5cQx X-Received: by 2002:a17:902:f54e:b0:166:3b30:457c with SMTP id h14-20020a170902f54e00b001663b30457cmr8523711plf.1.1655286945244; Wed, 15 Jun 2022 02:55:45 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655286945; cv=none; d=google.com; s=arc-20160816; b=Or9b4YXMitOqBC9uyDX9kGwIfZranzZaRP+QFp3SijDoEb5JdKc0dPAd1EgaatfAfv O+/bbGn3urgBMIH9hBjpsEuICsggVWlco9fZO/THGUSermbzYmHavmNTgoTn+0drzVby p6VTRF7SR5kF/BO0zbPQbz2Yuz8BgX5bVdOb1V+rVpH7yvzVHZWUv6icIkSFjsmtf74f z5RAV463EJlzxE/BsLG3799EtFiSBZbMARhUFqvY3xXQR3Xob4SFlVX8QmsuT74P8N7X xqQAPBWHw4U+UAUT3/5aoKXEJXe2yXiUQ3OBBGy6tRpypo4/X5wD5k9JKXYEz+96/L5z IYWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=Az0IhgLrluMj3GRMffnnHU8dn9q2U05jVmkW4Ha7TmE=; b=EFjTEKTN9Uoe+dtavonG0RRvQYNtItBQckTjzPXawJRLJqPjRExcY89fFKBJc5RJkA 6xuMMeoNOv3Z2023YsxRdux9MP14IqoT4HCNpyju9kYxJasptW1l52L4xLKNN9qcqb06 jSEf1b6KNErm6YqWFOY6Asg/JtkWPHoXyIGGSStSAxMLL5DJVcCAedyLNxRQd+FvvPXu GkanVpW+0GMsERp0j0DVQm3BvcAQN22fWa2zQ3CWSdASDH1el2wcygkkccjwlXHI8H4i a3Hfqm0Gsm2yaP2Xe8jVkfSCahtCPBgl8HFjuywbADw0mOMchF+lqd8p24wAVGLdR4Pd qyoQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AAdkjP7l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id ge8-20020a17090b0e0800b001eac98dbaedsi1868239pjb.78.2022.06.15.02.55.32; Wed, 15 Jun 2022 02:55:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=AAdkjP7l; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347402AbiFOJpe (ORCPT + 99 others); Wed, 15 Jun 2022 05:45:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1346676AbiFOJpd (ORCPT ); Wed, 15 Jun 2022 05:45:33 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D164A457A4; Wed, 15 Jun 2022 02:45:32 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id x5so15307014edi.2; Wed, 15 Jun 2022 02:45:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Az0IhgLrluMj3GRMffnnHU8dn9q2U05jVmkW4Ha7TmE=; b=AAdkjP7lcrPBx8gbayY/ZnxUVDiPwnG7RR/E+4eAm/ZkE5RPmKMfJILidca5QQG9Pp 0xxBOBvj5R5ENPB0HcUNSO2lqBA32wLjJgbyhQKiNM9HVCJiC8wxO3GMATzu8EaEQS+O 0IJVXu8bnIUmjuHC5D5t6HvBzdo4l2jOLpSqBYBMLSiWzRdYj+RyXSIMGgTomCw/A7dc NoNOI5vlPg3qYbBtXhrE1rNIwprT3x6WT9lbI3rTIjXDmp03khoVmMIflnqHuz80eCMc hC15UYCHEZftLZ4bf2G6WVJKnfQoHx2B6AxXIhXVt70pf7t1tnRjysjSU4rjAeHtBgUw wHJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Az0IhgLrluMj3GRMffnnHU8dn9q2U05jVmkW4Ha7TmE=; b=x1F7eh0DvLtNpB9pzL+q7A4cZ6qmYTxi7HUBnpS5416tB8vMBPvmQu7m1TZ10LuVLS h/+jHau+DmBcy2K52U1eLLbyDGNiTyFN+Danm1m2x60FUXxVLZh+FoUd83y+kyE3v58m tWn8kUt06BZWSCmflKTU+sqxHPrX7KGbLMTm5sr3R5leEs7gDHzVbKvxCAVDQZzYPdtc 0VC5q9CiegZeA1OMeW2yKDxbwxBdAuPWaprmDX25rtLuI7/z+YMq/dwa3h16lG/MdZsZ HXqNQjEhw0W7dwDTkOmkNeu+RBZmfLZ3FlnxyaI1Od8510RhC7CL4QBUePWpXT02WdLl YEVw== X-Gm-Message-State: AOAM533t4JDOx7Q5ZGDhI86GD7bmdtHKTuH1d//3iu/wGoh1Y/LLsPCQ QAkZq0feaqumtH4++Twe1VI2DZ5VO1272FQP3eU= X-Received: by 2002:aa7:d481:0:b0:42d:d5fd:f963 with SMTP id b1-20020aa7d481000000b0042dd5fdf963mr11526488edr.209.1655286331287; Wed, 15 Jun 2022 02:45:31 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Andy Shevchenko Date: Wed, 15 Jun 2022 11:44:54 +0200 Message-ID: Subject: Re: [PATCH 1/2] iio: adc: stx104: Implement and utilize register structures To: William Breathitt Gray Cc: Jonathan Cameron , Lars-Peter Clausen , linux-iio , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jun 6, 2022 at 4:27 PM William Breathitt Gray wrote: > > Reduce magic numbers and improve code readability by implementing and > utilizing named register data structures. Can we consider using regmap APIs instead? -- With Best Regards, Andy Shevchenko