Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 15 Jun 2022 13:13:16 +0200
From:   Claudio Imbrenda <imbrenda@linux.ibm.com>
To:     Janosch Frank <frankja@linux.ibm.com>
Cc:     kvm@vger.kernel.org, borntraeger@de.ibm.com, thuth@redhat.com,
        pasic@linux.ibm.com, david@redhat.com, linux-s390@vger.kernel.org,
        linux-kernel@vger.kernel.org, scgl@linux.ibm.com,
        mimu@linux.ibm.com, nrb@linux.ibm.com
Subject: Re: [PATCH v11 14/19] KVM: s390: pv: cleanup leftover protected VMs
 if needed
Message-ID: <20220615131316.6336eb6d@p-imbrenda>
In-Reply-To: <44b2b227-9757-b7a2-41a0-cbea0e2bbbdc@linux.ibm.com>
References: <20220603065645.10019-1-imbrenda@linux.ibm.com>
        <20220603065645.10019-15-imbrenda@linux.ibm.com>
        <0a13397a-86e0-7c25-0044-7a5733f61730@linux.ibm.com>
        <20220615121916.77b039af@p-imbrenda>
        <44b2b227-9757-b7a2-41a0-cbea0e2bbbdc@linux.ibm.com>
Organization: IBM
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Wed, 15 Jun 2022 12:57:39 +0200
Janosch Frank <frankja@linux.ibm.com> wrote:

[...]

> >> I think we should switch this patch and the next one and add this struct
> >> to the next patch. The list work below makes more sense once the next
> >> patch has been read.  
> > 
> > but the next patch will leave leftovers in some circumstances, and
> > those won't be cleaned up without this patch.
> > 
> > having this patch first means that when the next patch is applied, the
> > leftovers are already taken care of  
> 
> Then I opt for squashing the patch.
> 
> Without the next patch prepared_for_async_deinit will always be NULL and 
> this code is completely unneeded, no?

correct. I had split them to make them smaller and easier to review

I will squash them if you think it's better

> 
> >   
> >>>    static void kvm_s390_clear_pv_state(struct kvm *kvm)
> >>>    {
> >>>    	kvm->arch.pv.handle = 0;
> >>> @@ -158,23 +171,88 @@ static int kvm_s390_pv_alloc_vm(struct kvm *kvm)
> >>>    	return -ENOMEM;
> >>>    }
> >>>        
> >>  
> >>>        
> >>  
> >   
>