Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 15 Jun 2022 07:32:04 -0400
From:   William Breathitt Gray <william.gray@linaro.org>
To:     Zhi Song <zhi.song@bytedance.com>
Cc:     gregkh@linuxfoundation.org, rafael@kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] isa: put_device after failing to device_register
Message-ID: <YqnDNL/ComIpYYe1@fedora>
References: <20220614164710.1744680-1-zhi.song@bytedance.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="MX931KHt9URK+Zru"
Content-Disposition: inline
In-Reply-To: <20220614164710.1744680-1-zhi.song@bytedance.com>
Precedence: bulk


--MX931KHt9URK+Zru
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 15, 2022 at 12:47:10AM +0800, Zhi Song wrote:
> device_register() is used to register a device with the system.
> We need to call put_device() to give up the reference initialized
> in device_register() when it returns an error and this will clean
> up correctly.
>=20
> Signed-off-by: Zhi Song <zhi.song@bytedance.com>

Hi Zhi,

Would you add a Fixes tag line specifying the commit where this bug was
introduced. That will help us get this fix into previous kernel versions
as well.

Thanks,

William Breathitt Gray

> ---
> V1 -> V2: Fix up the changelog text correct.
> ---
>  drivers/base/isa.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>=20
> diff --git a/drivers/base/isa.c b/drivers/base/isa.c
> index 55e3ee2da98f..cf88f3d77b7d 100644
> --- a/drivers/base/isa.c
> +++ b/drivers/base/isa.c
> @@ -173,8 +173,10 @@ static int __init isa_bus_init(void)
>  	error =3D bus_register(&isa_bus_type);
>  	if (!error) {
>  		error =3D device_register(&isa_bus);
> -		if (error)
> +		if (error) {
> +			put_device(&isa_bus);
>  			bus_unregister(&isa_bus_type);
> +		}
>  	}
>  	return error;
>  }
> --=20
> 2.30.2
>=20

--MX931KHt9URK+Zru
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCYqnDNAAKCRC1SFbKvhIj
K0QiAP9L6auH2eAVJESQER3EQmCmoRYlI+VkaUGscIs7m2A80QD6A70Y2fgat+EL
/ZyITyJ61LlUPc6EEf7nKpV2/6GwNg8=
=A2d+
-----END PGP SIGNATURE-----

--MX931KHt9URK+Zru--