Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 15 Jun 2022 12:23:21 +0100
From:   "Russell King (Oracle)" <linux@armlinux.org.uk>
To:     Ong Boon Leong <boon.leong.ong@intel.com>
Cc:     Alexandre Torgue <alexandre.torgue@foss.st.com>,
        Jose Abreu <Jose.Abreu@synopsys.com>,
        Andrew Lunn <andrew@lunn.ch>,
        Heiner Kallweit <hkallweit1@gmail.com>,
        Paolo Abeni <pabeni@redhat.com>,
        "David S . Miller" <davem@davemloft.net>,
        Eric Dumazet <edumazet@google.com>,
        Jakub Kicinski <kuba@kernel.org>,
        Vladimir Oltean <olteanv@gmail.com>,
        Vivien Didelot <vivien.didelot@gmail.com>,
        Florian Fainelli <f.fainelli@gmail.com>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Giuseppe Cavallaro <peppe.cavallaro@st.com>,
        netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Emilio Riva <emilio.riva@ericsson.com>
Subject: Re: [PATCH net-next v5 3/5] net: pcs: xpcs: add CL37 1000BASE-X AN
 support
Message-ID: <YqnBKTpbhx+quBIc@shell.armlinux.org.uk>
References: <20220615083908.1651975-1-boon.leong.ong@intel.com>
 <20220615083908.1651975-4-boon.leong.ong@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220615083908.1651975-4-boon.leong.ong@intel.com>
Sender: Russell King (Oracle) <linux@armlinux.org.uk>
Precedence: bulk

On Wed, Jun 15, 2022 at 04:39:06PM +0800, Ong Boon Leong wrote:
> For CL37 1000BASE-X AN, DW xPCS does not support C22 method but offers
> C45 vendor-specific MII MMD for programming.
> 
> We also add the ability to disable Autoneg (through ethtool for certain
> network switch that supports 1000BASE-X (1000Mbps and Full-Duplex) but
> not Autoneg capability.
> 
> v4: Fixes to comment from Russell King. Thanks!
>     https://patchwork.kernel.org/comment/24894239/
>     Make xpcs_modify_changed() as private, change to use
>     mdiodev_modify_changed() for cleaner code.
> 
> v3: Fixes to issues spotted by Russell King. Thanks!
>     https://patchwork.kernel.org/comment/24890210/
>     Use phylink_mii_c22_pcs_decode_state(), remove unnecessary
>     interrupt clearing and skip speed & duplex setting if AN
>     is enabled.
> 
> v2: Fixes to issues spotted by Russell King in v1. Thanks!
>     https://patchwork.kernel.org/comment/24826650/
>     Use phylink_mii_c22_pcs_encode_advertisement() and implement
>     C45 MII ADV handling since IP only support C45 access.
> 
> Tested-by: Emilio Riva <emilio.riva@ericsson.com>
> Signed-off-by: Ong Boon Leong <boon.leong.ong@intel.com>

Reviewed-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk>

Thanks!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!