Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20200821181433.17653-8-kenneth.t.chan@gmail.com>
 <20220612090507.20648-1-stefan.seyfried@googlemail.com> <20220612090507.20648-3-stefan.seyfried@googlemail.com>
In-Reply-To: <20220612090507.20648-3-stefan.seyfried@googlemail.com>
From:   Kenneth Chan <kenneth.t.chan@gmail.com>
Date:   Wed, 15 Jun 2022 18:53:52 +0800
Message-ID: <CAPqSeKuubG0Q2BhsYz+MbLi_ViU97whTzwVaUQOf7OvLSb4bFg@mail.gmail.com>
Subject: Re: [PATCH 2/2] platform/x86: panasonic-laptop: allow to use all hotkeys
To:     stefan.seyfried@googlemail.com
Cc:     platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org,
        Stefan Seyfried <seife+kernel@b1-systems.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

I'm resending it due to reported spam. I forgot to turn off HTML
formatting. My bad.

Thanks for the patches.

> From: Stefan Seyfried <seife+kernel@b1-systems.com>
>
> commit ed83c9171829 broke the hotkeys on my Toughbook CF-51.
> I'm questioning the general validity of that commit, but as I only
> have a single machine to test, add a module parameter to allow making
> it work at runtime.

I can confirm that as soon as the hotkey_input option is enabled (at
least on my aged CF-W5) it reports the ACPI event twice. Unfortunately
it's the only machine I have for testing. Unless we have a bigger
sample base, making it a module_param is a safe choice.

Otherwise the patches look good to me.

Reviewed-by: Kenneth Chan <kenneth.t.chan@gmail.com>

--
Kenneth