Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: EibKC1SpqjvzTxN1AODsueuZHGI2hAKZcDWEq3URc+uz8+Lzs74D1NAf7PpVFuLWJuAWWwptcT
 snXMX2ailfqc82+md00l1FuZRyAnWtwgc2OXftj8NBqFr5vyllvSIK7yLayAqaEYDRLR7/G2co
 ILntOBoZ5N3o3x4LeXhTbyCKwkeqWCkt33g+CFLisfVW8oPQzXPrRWQHOo79dHToaf+lxc8nRO
 orMT8LyoHiun1UHsPiCT5BEyiCG19yFLDGqTEIGX85l45xX5kZd9MeZNuIdn66yaj5dhBmsV9h
 bi4oOOayKj2YMBIwn1aIOa+M
IronPort-SDR: Jm1wZQyMisEkBiSelUacdx83uKyBU+omv6hMcSQGKLM6RXeLLoqAanka+PzfYEF1oEjXZ8sPsd
 LjYrOj76IU8RG7vjky4tNNY6Ubjs4cnZ4zGrcP0nPjqzLLJhJhANwHi7pkzdD4poH2OAwfkt21
 iT2yxZzBR/eNK//MfWoodFSb7ngDWezLVk3pUFRXEjvfv9eR6ng2pbbcsYwjD0GiHJzMYL5xxs
 cXhVCES8v/f+Iyyb2fFufpkBc57PAM00sM5It+6ezM3UZFMwgKgC/0DNrtP7qVccnXgeG/n29w
 M3o=
WDCIronportException: Internal
Message-ID: <064551fa-4575-87cb-d9da-90a34309f634@opensource.wdc.com>
Date:   Wed, 15 Jun 2022 20:53:56 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v7 10/13] dm-table: use bdev_is_zone_start helper in
 device_area_is_invalid()
Content-Language: en-US
To:     Pankaj Raghav <p.raghav@samsung.com>, hch@lst.de,
        snitzer@redhat.com, axboe@kernel.dk
Cc:     bvanassche@acm.org, linux-kernel@vger.kernel.org,
        jiangbo.365@bytedance.com, hare@suse.de, pankydev8@gmail.com,
        dm-devel@redhat.com, jonathan.derrick@linux.dev,
        gost.dev@samsung.com, dsterba@suse.com, jaegeuk@kernel.org,
        linux-nvme@lists.infradead.org, Johannes.Thumshirn@wdc.com,
        linux-block@vger.kernel.org, Luis Chamberlain <mcgrof@kernel.org>
References: <20220615101920.329421-1-p.raghav@samsung.com>
 <CGME20220615102000eucas1p27720aaa3c309327b2b9a33c5f840f498@eucas1p2.samsung.com>
 <20220615101920.329421-11-p.raghav@samsung.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220615101920.329421-11-p.raghav@samsung.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/15/22 19:19, Pankaj Raghav wrote:
> Use bdev_is_zone_start() helper that uses generic calculation to check
> for zone alignment instead of using po2 based alignment check.
> 
> Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
> Reviewed-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>  drivers/md/dm-table.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/md/dm-table.c b/drivers/md/dm-table.c
> index bd539afbf..b553cdb6d 100644
> --- a/drivers/md/dm-table.c
> +++ b/drivers/md/dm-table.c
> @@ -251,7 +251,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
>  	if (bdev_is_zoned(bdev)) {
>  		unsigned int zone_sectors = bdev_zone_sectors(bdev);
>  
> -		if (start & (zone_sectors - 1)) {
> +		if (blk_queue_is_zone_start(bdev_get_queue(bdev), start)) {

This is wrong. And you are changing this to the correct test in the next
patch.

>  			DMWARN("%s: start=%llu not aligned to h/w zone size %u of %pg",
>  			       dm_device_name(ti->table->md),
>  			       (unsigned long long)start,
> @@ -268,7 +268,7 @@ static int device_area_is_invalid(struct dm_target *ti, struct dm_dev *dev,
>  		 * devices do not end up with a smaller zone in the middle of
>  		 * the sector range.
>  		 */
> -		if (len & (zone_sectors - 1)) {
> +		if (blk_queue_is_zone_start(bdev_get_queue(bdev), len)) {
>  			DMWARN("%s: len=%llu not aligned to h/w zone size %u of %pg",
>  			       dm_device_name(ti->table->md),
>  			       (unsigned long long)len,


-- 
Damien Le Moal
Western Digital Research