Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <442c7cb4-7ec5-bf34-b9d6-ce9480b4b491@amd.com>
Date:   Wed, 15 Jun 2022 17:34:46 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH V2] selftests/vm: Add protection_keys tests to run_vmtests
Content-Language: en-US
To:     Shuah Khan <skhan@linuxfoundation.org>, akpm@linux-foundation.org,
        shuah@kernel.org, linux-mm@kvack.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220610090704.296-1-kalpana.shetty@amd.com>
 <8e7fca3a-096c-7d6c-e43b-9292995ab970@linuxfoundation.org>
 <e1703fcf-c5e2-70b1-cae2-30330108ad26@amd.com>
 <2f157493-02ed-4bc8-6624-b7d077c0d5af@linuxfoundation.org>
From:   "Shetty, Kalpana" <kalpana.shetty@amd.com>
In-Reply-To: <2f157493-02ed-4bc8-6624-b7d077c0d5af@linuxfoundation.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eG9FbFkyb2FGK0drczFtb0syTG00YXUzRk1zV0R0elo0WHBHSE9EZjNwQzFj?=
 =?utf-8?B?eGhIb0lvaElRVEx0VzlWRzFNWmxBa1VEVG9iZXRyeTJyTU5ML2NJRlQvRU4x?=
 =?utf-8?B?N1Q2RFFKSVdPdTVvbnY5NFVzcyt0SXU2T1AxZ1hFYUtxRlhWVXNlM3RiaHhX?=
 =?utf-8?B?VkNMbkttT3h3clRKbG5BcnRONlgva0ZPYVJPTnN6d0U0TU9KL1oyd29aMWJ3?=
 =?utf-8?B?QXAxKzJsVGd4NjB6ZFNXdlFIWEt4R3VrSm1zRGNiTUFUTlhOUktYL2NHaGxG?=
 =?utf-8?B?b2RCZy94cjJ1SXoxZ282SythTzJQelhTZ2NFLzQvR2EzU1puRW8xN2VmUVRu?=
 =?utf-8?B?V0diN3hGelQ5TTM3SzhESzU5dUZlbnhEbjdoZkcweWtrYkZ4VHlTa1NYRDFN?=
 =?utf-8?B?M1BXMTcwcjZQSEFEeXNTOGwvUWVzNmFySXZpRzhVb2ZyT1hvQ3NXTTAwaElk?=
 =?utf-8?B?S2JacEc1ZzNqd1NDKy9lOHNseCs5cFJXUGxYZ2M4TURhQ2ozbFYzd28waGt5?=
 =?utf-8?B?ZlAwYXFaa2ZQREs4Q1R5Yk04Z1hOK21LaXdBQmovVTJ2L3NDdlNtMERwaFR3?=
 =?utf-8?B?OHZkUmtETFcrUjUzbkJ0TzB5S2I0bFV5NzBRR3VaZVQrazVHaGpCQzYwWU1O?=
 =?utf-8?B?TmJ6OU4wU0orSVJRZEljNzJuSnp3QTU1dmRnM0xTMlo0OVFNcG10ZkY0ZkdY?=
 =?utf-8?B?VDBHTFZOWUx0NCtQSGROdzg2aU4yZGx3QzY3TUxDbkhTWjNobnlpVFRwZkQv?=
 =?utf-8?B?d09rYXNtcGZ6ZkplMmlESFhKZTVtSmt2WU02aldWdFB3UUlRM3hPSXJCTTRa?=
 =?utf-8?B?eG8ySmxHVTZ1RXNZcjlUSkpOUFRnQ2JhYjFsc2JTQ3pDWHo0Rjc3dHBMREtT?=
 =?utf-8?B?T2hRRlRsYjhiV2NCb3owNy9laXM3WmZCa2ZUNm9iVVZMeUVoSGNPNmxxQnpk?=
 =?utf-8?B?L2hSazN4RVRud0RrZklUMHQrdFIwR1lKK2VJSjJybE9CU0k4cVlxTHFWemVW?=
 =?utf-8?B?Rk1yNzVVZUhjWEpOTnNvUkdqN1VHUTZQMlFHWXF5QmVZaEtkWlhUdFYyUGxD?=
 =?utf-8?B?d1BNZTM3ZkF2dGYybmZsVmtPMjNhTHNmMTRWdFA5ZHpWY3IyMU43UGcvNGtP?=
 =?utf-8?B?cTVFRkNTWUJrakZLK3VyWVRwUDUzVklkY25kSU1KcXdQUi9QZ29KNUFoRmxt?=
 =?utf-8?B?V3FUYTdiNDhkWjI3YnUwa3FDOUczN0dPMElDdTFVbXBCTHFYdk53a2NUYXN0?=
 =?utf-8?B?Nm0xTU1vcjl3VlVYaS9NK1NhNWVqWWdPQVJXeFJKQ2l3SG5nelR3TDhXRXEv?=
 =?utf-8?B?c3g0Mm1IVEJmMmo5RlRHQXk0UGVHclZiVFUwOXcvekJiUlZGcnJpajErRGFQ?=
 =?utf-8?B?U2NiM21aNlRqemVQSEVFSUZZQ1F0aG93bUtzNzhjS25oYmtJUVlOZ1pGWHJr?=
 =?utf-8?B?UlllR29rbGlEWmRxV3YxUUpFOXM5M0tIUUNmMXR6WldBQkFjbDRtZ1QzT3RN?=
 =?utf-8?B?QTVHVW94QXBseVc3aWJsaTBDYWkxOEFLajdRVU9kVEFPbW9yOTB3Vm1YVXhz?=
 =?utf-8?B?VkVIM2xLbVVrcG5KZlhDNlJIOWMyRHhDdmJXdmFuMCtSSEw4ZmttWGlXL2ZB?=
 =?utf-8?B?cVhIZ3pQd0IyTG5XZDVoQmtIenloOEUwY3pVY1lhZEE4cXhmamoxK1RqeVB6?=
 =?utf-8?B?Y3VSSTYzQ0FpaU9rMFNSVHJicWc0dnZFV2RsRVU3Ni9ERkI0aFI5S3ZXcGZU?=
 =?utf-8?B?Y0RaTzU2S3F1Y1VYbG1oRDJsYWxwRkphVCtkSjBYTzYzTHU4bTNUZXNVb25M?=
 =?utf-8?B?bnVHVjFCRDFyWFkwQW9LMkxKOURUMzRRcnNiWkVDNU9LVFl5K1NjYW92Y2dx?=
 =?utf-8?B?OW05RGhWcXFTTGN6cFdTNlJLaU4yS0VURzZoOVZ0UU9iakpIZFhUcWthaS9O?=
 =?utf-8?B?Qm9wbm8yUHk0QUs3azNGa2l1bjJGZDV2L3NQa1RMWmZmM1FSMGNNdDBUOHNB?=
 =?utf-8?B?WmQ4eGZvQ0E0bk9kb2pEV0ZwK2l2MW42SWw1VVcwS1ZLNnZmZW5QMjhTaFAv?=
 =?utf-8?B?WW0rTDhnWGJZLzNNclFTNzQyamdpcEJrQllRY283ZTZWMDBQRTE2UDVvOEM2?=
 =?utf-8?B?aDNKeUtNckVKQWtqeXpZdTZmMVlzWjA1cmFETms1Y2h3bCtZRFkwc2o1NFl1?=
 =?utf-8?B?TTlLUCtzdCtRQkdmTjlERzBZc1dmSXU2K0dyYnN2NVZhSUl0QUlsWmd0RGRo?=
 =?utf-8?B?dThSUFRwcHE3dzVibXRqR0g2cXovb3owb051cjRrdEJtdmkrNE9RaWFzWG5u?=
 =?utf-8?B?aitYRk1ocUVnK3hkU2lEaXBudVhBMFFCaThtVmhXUk9VSzRZWkZxUT09?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 1e6dc810-7cdc-4766-fd8c-08da4ec742b2
X-MS-Exchange-CrossTenant-AuthSource: BL3PR12MB6449.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 12:04:55.3799
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: kQSFUpAFFjR+TuT8OJj72+SPzLiDfIlqLR4RVyfkEKuzyaYFR+pmL3cUwrJ7SG4+tN+4CrnIlPQgR4v2En96Vg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1865
X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_PASS,
        SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/14/2022 10:50 PM, Shuah Khan wrote:
> On 6/14/22 6:15 AM, Shetty, Kalpana wrote:
>>
>> On 6/14/2022 3:14 AM, Shuah Khan wrote:
>>> On 6/10/22 3:07 AM, Kalpana Shetty wrote:
>>>> Adding "protected_keys" tests to "run_vmtests.sh" would help out to 
>>>> run all VM related tests
>>>> from a single shell script.
>>>>
>>>
>>> Makes sense - can you explain why you can't just run
>>> protection_keys_32 without checks? 
>>
>> Yes; we can run protection_keys_32 without check.
>>
>>
>>> Why are you checking for VADDR64? 
>>
>> The check is added to ensure if the system is in 64-bit mode before 
>> executing 64-bit binary.
>>
>>
>
> Okay. protection_keys_32 will only be built on 32-bit system and.
> protection_keys_64 on 64-bit system.

On 64-bit system, we get both 32-bit and 64-bit binary.


>
> Won't it be better to check if binary exists and run either _32 or
> _64 instead of checking for VADDR64?

makes sense;

In this case on 64-bit platform we would run both _32 and _64 and this 
should be fine.


> thanks,
> -- Shuah

Thanks,

Kalpana