Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp440755iog; Wed, 15 Jun 2022 05:34:06 -0700 (PDT) X-Google-Smtp-Source: AGRyM1tWdwwunSAHBoahNR7lCxbG1sVowHmamkGxJs2Uf8wn0np6Fsfe7u4GwPhxhUJvfIXfWgsS X-Received: by 2002:a17:906:c10:b0:6f4:6c70:b00f with SMTP id s16-20020a1709060c1000b006f46c70b00fmr8653694ejf.660.1655296446165; Wed, 15 Jun 2022 05:34:06 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655296446; cv=none; d=google.com; s=arc-20160816; b=ZyvUMDMDLDhMStMQ2Ej/uaGSDvSOcTiovmsgND+EiWIs2YIttvthE+E9oSXeEUI50B eOBpbJAHWyFvDAdtN95gtDVo16mX2hRUyPoIRJcfu+7Q6H/SLiI2g4HWJWB2LXqvLjA1 x9Lg4XI1Rw2rYfrkQ1OLChEtb2HyYS4FLtEpceSJbZPQaeDxPQDtY3bGdKm566r5l0zr VyYX3+owq+NNeTUnqwx6F47qKrbDwdFL4AaP43uEjxMelfjSFfbdxZEVrh27Ecfj5bT8 IvOlHFgfqZxT52O3upfah6kQUtQyOmmmFN2UzlENdlnZdLfZLiqJ618VHjZSAkvqLX6O cfeg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=MPOz4vgepz2ltUJZ6fEyvEaVgIdF4j+lXzNxdrCQ1W4=; b=Ng/j7yB/RRD5MkJwzlduguBYC1yCbxc4SB8QwRc+N59j+JPFVAo8CdUSjtCT3MLYn1 uB8g4V4+lgpu7INtlMvvTgm6DZIvsa/I5lnwmEdFOv1Vu2YqJRJ+C4t4O+t+xpeKKjYm an5tWL4cg1Dd+ERXD2cc9KHX/0tAluctujXXSvjxLbD9z/Grzz3NnOxFG1v4pSeU123J NTFac44Uo2w4x+U57uUZqGPLMDY1MVSCkzyOS0hPnBuyQ5tlVUgMkxiszGKKr4gCSpSc VHT6SQGEVndgK1UNPUpcH2P4FDMQCnhnPmzqSI0KLwegfx+V/T0RYxu4Pbh4WqIGrNWT wOqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Kv1/sBXQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id dt19-20020a170907729300b00711c8193ce8si12586660ejc.21.2022.06.15.05.33.39; Wed, 15 Jun 2022 05:34:06 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="Kv1/sBXQ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347560AbiFOLz7 (ORCPT + 99 others); Wed, 15 Jun 2022 07:55:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57052 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347021AbiFOLz6 (ORCPT ); Wed, 15 Jun 2022 07:55:58 -0400 Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 968B46470 for ; Wed, 15 Jun 2022 04:55:57 -0700 (PDT) Received: by mail-qv1-xf2e.google.com with SMTP id u8so8635564qvj.2 for ; Wed, 15 Jun 2022 04:55:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MPOz4vgepz2ltUJZ6fEyvEaVgIdF4j+lXzNxdrCQ1W4=; b=Kv1/sBXQy+VkaqfjY5/Yt1paxNw4IwE49hKbnnu4UqH8luwltTGeQ6HRlFn9chHIPH kj7417kDRfRvsgSOxPDs6mnjM1s+LpvFCf6b0I3EJnWeL5zJR6MHLHHHuJmb2eKtB2uB Xm9qMpVab9KKZ0YFri9hts+IWOMdO/3QigWYfzKTK3FyIW6sjLH1qdmKoIDvpqC7KD4p nTZSHDsN3ayn6gMT+eSpMRwyyQBYfpOibtwxf3CsiGIxlO5wMOzAkJ8R6yCXT2hyjJSZ JiCfhMrB5Qj9RhuIuIYRwoao0q/ktEUFUXwnoC414xL/DL1s4d8olS2trt41pI1wZ3qo 59bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MPOz4vgepz2ltUJZ6fEyvEaVgIdF4j+lXzNxdrCQ1W4=; b=w9q1CNvjRpIgLwVnMQ7bt8wI9GrxV+L/w33sPuJV49Ecxzy1sXC93EckCN0/hX+7JF Zha8gReaR186yHLVspsNtLz3B9+oqvzOfJa2471lYihwjJAoq6fOxCWOPY+CMNbzW0Xi 98jWQ75paOcXj0r3pR20vK6Umfs8HHyhAJyoO2GPgE3NIHLvnpuB2zqbGI6xGkszxTtM OzPc4ycKQqazgRPemU8Bdtr8TXIXJyhWe3xsvWMdcgMGstdEPOEq8GQ/YGkCfvEwqL/R cA3E+fO5LI3lo+jCRJ9KiWj0VT4e+SFFAaJJ5imqDaKIXTwrMhMMn3ORuIFDUDI7otLz suzQ== X-Gm-Message-State: AJIora/XURjjPCzw4DOLcPdJx6CbUZhYakwgKbth2/gKvAFqZ0//77cz YKO6dvcMaE4e5a1WQrPWri2xlQ== X-Received: by 2002:a05:6214:1025:b0:46e:5510:e764 with SMTP id k5-20020a056214102500b0046e5510e764mr7551774qvr.78.1655294156742; Wed, 15 Jun 2022 04:55:56 -0700 (PDT) Received: from fedora (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id p22-20020ac84616000000b003051f450049sm9393159qtn.8.2022.06.15.04.55.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 04:55:56 -0700 (PDT) Date: Wed, 15 Jun 2022 07:55:54 -0400 From: William Breathitt Gray To: Andy Shevchenko Cc: Jonathan Cameron , Lars-Peter Clausen , linux-iio , Linux Kernel Mailing List Subject: Re: [PATCH 1/2] iio: adc: stx104: Implement and utilize register structures Message-ID: References: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="LoQy7Axdwa0I3j9u" Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --LoQy7Axdwa0I3j9u Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jun 15, 2022 at 11:44:54AM +0200, Andy Shevchenko wrote: > On Mon, Jun 6, 2022 at 4:27 PM William Breathitt Gray > wrote: > > > > Reduce magic numbers and improve code readability by implementing and > > utilizing named register data structures. >=20 > Can we consider using regmap APIs instead? >=20 >=20 > --=20 > With Best Regards, > Andy Shevchenko The regmap API may be more appropriate here. I'll investigate and see if I can convert this over to it. William Breathitt Gray --LoQy7Axdwa0I3j9u Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYKAB0WIQSNN83d4NIlKPjon7a1SFbKvhIjKwUCYqnIygAKCRC1SFbKvhIj KyVdAP9p1cEf2MxISHsQN2H9PTN6/GHta0g18vZLUlDtVJbEIgEA+fO5VJ4K/vgD 0e0CDHy8qRSYdkBhsczHE5v0eC/Vnw8= =j35z -----END PGP SIGNATURE----- --LoQy7Axdwa0I3j9u--