Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain;
        charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.80.82.1.1\))
Subject: Re: [PATCH -next] dmaengine: apple-admac: Fix build on
 32-bit/non-LPAE platforms
From:   =?utf-8?Q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>
In-Reply-To: <20220614074915.1443629-1-geert@linux-m68k.org>
Date:   Wed, 15 Jun 2022 14:07:12 +0200
Cc:     Hector Martin <marcan@marcan.st>, Sven Peter <sven@svenpeter.dev>,
        Alyssa Rosenzweig <alyssa@rosenzweig.io>,
        Vinod Koul <vkoul@kernel.org>,
        linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org,
        linux-kernel@vger.kernel.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <4D5BB835-5DF0-4BBB-B073-A77F1A96EA19@cutebit.org>
References: <20220614074915.1443629-1-geert@linux-m68k.org>
To:     Geert Uytterhoeven <geert@linux-m68k.org>
Precedence: bulk


> On 14. 6. 2022, at 9:49, Geert Uytterhoeven <geert@linux-m68k.org> =
wrote:
>=20
> If CONFIG_PHYS_ADDR_T_64BIT is not set:
>=20
>    drivers/dma/apple-admac.c: In function =
=E2=80=98admac_cyclic_write_one_desc=E2=80=99:
>    drivers/dma/apple-admac.c:213:22: error: right shift count >=3D =
width of type [-Werror=3Dshift-count-overflow]
>      213 |  writel_relaxed(addr >> 32,       ad->base + =
REG_DESC_WRITE(channo));
>          |                      ^~
>=20
> Fix this by using the {low,upp}er_32_bits() helper macros to obtain =
the
> address parts.
>=20
> Reported-by: noreply@ellerman.id.au
> Fixes: b127315d9a78c011 ("dmaengine: apple-admac: Add Apple ADMAC =
driver")
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

Thanks! (TIL about the lower/upper_32_bits helpers)

Acked-by: Martin Povi=C5=A1er <povik+lin@cutebit.org>