Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220615071410.12499-1-piyush.mehta@xilinx.com>
In-Reply-To: <20220615071410.12499-1-piyush.mehta@xilinx.com>
From:   Rob Herring <robh+dt@kernel.org>
Date:   Wed, 15 Jun 2022 07:33:36 -0600
Message-ID: <CAL_Jsq+3oS=SB-TVH3JA7Jb8KDgQ8ek_KPJSQhL0mgiq4sjmyQ@mail.gmail.com>
Subject: Re: [PATCH V4] dt-bindings: ata: ahci-ceva: convert to yaml
To:     Piyush Mehta <piyush.mehta@xilinx.com>
Cc:     Damien Le Moal <damien.lemoal@opensource.wdc.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        "open list:LIBATA SUBSYSTEM (Serial and Parallel ATA drivers)" 
        <linux-ide@vger.kernel.org>, devicetree@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Michal Simek <michal.simek@xilinx.com>, git <git@xilinx.com>,
        Siva Durga Prasad Paladugu <sivadur@xilinx.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jun 15, 2022 at 1:14 AM Piyush Mehta <piyush.mehta@xilinx.com> wrote:
>
> Convert the ahci-ceva doc to yaml.
>
> Signed-off-by: Piyush Mehta <piyush.mehta@xilinx.com>
> ---
> Changes for V2:
> - Corrected the patch --prefix V3 to V2.
> - Added Required properties.
>
> Changes for V3:
> - Skip patch --prefix [PATCH V3] as already sent.
>
> Changes for V4:
> - Addressed Rob review comments:-
>  - Update params description
>  - Removed description from common properties.
>  - Deleted deprecated property.
> - Warning generated from: 'make dtbs_check'
>  - Thanks Rob: We are aware of these warnings,
>    but they are unrelated to this patch.

Huh? You are saying the dts files are wrong and should not have
'iommus' or 'phy-names' properties? That doesn't seem likely for
'iommus'. If the old binding was wrong, it is fine to add the
properties in the conversion. Just note that in the commit message.


> ---
>  .../devicetree/bindings/ata/ahci-ceva.txt     |  63 ------
>  .../devicetree/bindings/ata/ahci-ceva.yaml    | 182 ++++++++++++++++++
>  2 files changed, 182 insertions(+), 63 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/ata/ahci-ceva.txt
>  create mode 100644 Documentation/devicetree/bindings/ata/ahci-ceva.yaml

Also, rename to ceva,ahci-1v84.yaml for the filename.

Rob