Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 15 Jun 2022 13:51:47 +0000
From:   Yazen Ghannam <yazen.ghannam@amd.com>
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
        tony.luck@intel.com, x86@kernel.org,
        Smita.KoralahalliChannabasappa@amd.com, mpatocka@redhat.com
Subject: Re: [PATCH] x86/MCE/AMD: Decrement threshold_bank refcount when
 removing threshold blocks
Message-ID: <Yqnj88FPkZ6kBU7k@yaz-fattaah>
References: <20220614174346.3648305-1-yazen.ghannam@amd.com>
 <Yql9TqFtebd2h9Z9@kroah.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <Yql9TqFtebd2h9Z9@kroah.com>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?IsCQj0z9k4yA4O+oOvoY+IgXvcrQmENZZdHvAEv7S487/T4yTAZYIOidnr6B?=
 =?us-ascii?Q?aqXVjdPVNrpSwPqBnD8penGpFl9PdgVMNsaTIbzLjy8ZvJuyXObXYKJoNJ+d?=
 =?us-ascii?Q?/AR2/7VzcFilmPf/N2ieL3mtDGrcbmolLDWoFRiUxYj0hZ/13K819MuIr0Fz?=
 =?us-ascii?Q?xD779GMD/4aNpIrH1CAmA+uMOA3UC+zk65n3DiF1AMbvE9aqpOapKjdU5H/+?=
 =?us-ascii?Q?8bJsE7/FAhIhbU603fdC8aQ50rMqFTXT1phgxFzkr4iopexCHt4mXYox+mfF?=
 =?us-ascii?Q?ABwMnGUZs8bIClOZHEQuMAx+JiYNqhGwepAQwOgwzTV58mkj6F3rd1J5lVgd?=
 =?us-ascii?Q?TDBA/7aDqE8zgDRVDJII9fIyXlPcA0yD2v5XhJqYGVUrprE92knGB4IsM479?=
 =?us-ascii?Q?nIGDQ962q6GGGaBQLBPLHtzEeKT6TwZ4wF5y7iyCe9DNRAzi9vBOaK1VROsp?=
 =?us-ascii?Q?zlXTrZ8GY4h1ZKToVYwux9sQsGfn7FLMfU5XByUcTkdcfB8D81JUOCqwKWa0?=
 =?us-ascii?Q?3YS1gPesY0gxNMDDhpHnOv1TqVFxDf6QDX46iodhtcrphxHLeSJB8VE+Bjz6?=
 =?us-ascii?Q?OlgOXxqgMIx/c8ecVfqRQjvkYxF7ng6aBaOBizFdy7sr+rrz6ffFvZvoxWAq?=
 =?us-ascii?Q?nm2s5k1un2uprGOZFq4jtpVpdoE2hB2KG2EU6Lb7zrU4fhN0U1MgWCyfWjd+?=
 =?us-ascii?Q?iKLZqPFCkyYArpN9ho5ASinfm4/Q4i0uv7+F8LyikhgS6MEFR3ckpPxpMaLx?=
 =?us-ascii?Q?8bFQFRlZpZl/TN8ALE///CWZbo0nNMlvPaOD52RV95Ro0aZbkvrQoWpy8TN8?=
 =?us-ascii?Q?5oNPjwx7qwhzpeJN24tuxLygVS1BaRV9i04HriNDyVeGdr5jNSdBpWw8JQLD?=
 =?us-ascii?Q?CGQWCEOWFfKwVK33ihr/QPxdD4saI+qmYpkb07STJuqXv9MJrXUC5qwWHKH7?=
 =?us-ascii?Q?K/4azkl+TY5upcKzZPlDIDE16GrR9CTbyPp3uCM+m92elQhVNolwiPVBMFu/?=
 =?us-ascii?Q?Oa0UlZax3yz+rQQ+VRLwSjlWI2+rOlo37yLx7njquNaf8jVFi51dETcAkbRN?=
 =?us-ascii?Q?K0dAck0XqtoDO7/MDs6dKD644cA9O3qd9JuXHbzuN0G2ZOtQDMJ0YEL83n96?=
 =?us-ascii?Q?50Mf8qjU63nPso0aTKe3hGnrQ4p3tbx/WaHBU88vuTNHOVeDttxEnCZawDvZ?=
 =?us-ascii?Q?XcG9JZiNbaLzR7YzF15rdWmV5F4ccGTweu1F4GQrt/vjl7yoDnE/50eOY4Bn?=
 =?us-ascii?Q?1/O6Vm6CTUNM31qbWIEKUWTM7pXBDBuz3N6uw0gb/Ep04EhHnStregACHXpC?=
 =?us-ascii?Q?V4o9Tsx1jRCKAw3vymrh7PPbClxLSABXKLn7NBRWzRH+Fg3tCOJ4PUZy4YjN?=
 =?us-ascii?Q?kiNKj2OsSbHAiCvtiTu9dlkATQzbfrT7/y7aPa+QzIRfcxvyEh+g4KUI53E7?=
 =?us-ascii?Q?oJQR5iqF5hiMlzeG4lEqSI+84Zg3hSy1lEzLtZX8LK5m7h3UJpH0WkywFf/s?=
 =?us-ascii?Q?4/6Kod9FLkkquKCv6JWX7v/JKHOEqJpuVDFlxm3MfHBxVlccW3mIrDaNUpRb?=
 =?us-ascii?Q?J3/VmiEixes361G2O3LD2FPrTZR95S2YLfxNoRBgbNODAZGEvD2oemjR8RtC?=
 =?us-ascii?Q?hbxtlHNeni/U2tBQ9nVeyZAGT8mUAPe5Zj2aQzlOjhxglFCuZRCfbR2nWcdP?=
 =?us-ascii?Q?L5gFbki4tHYyVvNZduvYHzs3wUBTDf0W9NVK7oB5+lJpM5L6DLfftkPLPBPn?=
 =?us-ascii?Q?pBYNyuWnPg=3D=3D?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 306517a8-b20d-4c73-a935-08da4ed632e6
X-MS-Exchange-CrossTenant-AuthSource: BN8PR12MB3108.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jun 2022 13:51:51.1385
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: joDjQZHKi072M8n09xJry4EZdAjcoxCfG8kiAgXJEVfFEtac2yzJDZ6wJtvmtKB1PwW/12D1JWP2HKlBu5BMRg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB5296
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
        RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jun 15, 2022 at 08:33:50AM +0200, Greg KH wrote:
...
> > 
> > Fixes: 7f99cb5e6039 ("x86/CPU/AMD: Use default_groups in kobj_type")
> 
> This predates this fixup, this commit just exposed the root problem here
> so odds are it should be backported further, right?
>

Yes, I believe that's true based on code inspection. But I'm not aware of any
reported issues in this area before the commit listed above. So I decided to
switch the Fixes tag from what I had before (shown below). I can switch it
back if you think that's best.

Fixes: 019f34fccfd5 ("x86, MCE, AMD: Move shared bank to node descriptor")

Thanks,
Yazen