Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp535994iog; Wed, 15 Jun 2022 07:19:31 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v1aeH2BYw5BeOPOl3nI07zZXa4Rw3yuRxgu0DPy1/7ETJPpkOx96saKc2MeB8PNvaPA98j X-Received: by 2002:a63:242:0:b0:401:b84a:6008 with SMTP id 63-20020a630242000000b00401b84a6008mr81640pgc.100.1655302771428; Wed, 15 Jun 2022 07:19:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655302771; cv=none; d=google.com; s=arc-20160816; b=Zvi1auLMRKjHHW0ymOa6qfGL7h2N+78iaIW0T7OgjJNVI2k2cFReOiBvHVWFUSnvuD gINjAbhKz98twqp1gM9Noa7ZAkog2X7YTQ21KDje8HkYSRK/6nGIadZGpw46yU/uqFCF CFRxNRbta15tWqrOuV+GGVrM3+yAGKKSFG16XHKZwV4S+v71wXrFDbkAJe6x79ccVR/G R5Du/Alp3BZ2Dtt3dGIxyWAH2OSViQqZsRHDU15vuBBY1pxbM2QygVcy45BGH7aofF76 RRoh92bAGe7wQx/pP5pl6uv11UUDW05rw5VE08A+l5KuAI4pfjmD4Pyjm1os5CpGVGEp U4Ag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=mONcnYz+UzOM2FqAirFVMXvA1LDZQM3Ao3LXZabuA5g=; b=T2j2HmsL9ely1pteVb5LiR6+7PHTHfr+QmbPUW1NkAAYQg29rYK4s3UzOLZ3hkk9sw XWPzwPAil5ApKZCiFlTfbiBhwxOoQ80BIx25xbeziq/Oop+ULe5xCByS9t/p00v5jXh7 pJeIVAAiCxv+ab//msIeu5wrsa9X+aUc+EhSPyCNiWjdhju8RrjLUW8gMC0vstG5FKwT Z+IXzoML7zQ+sMHqwEnbWrthhVLNZQQ9dR2GNVqqVMg9uSF2aC8FoDWAOd51FTu5HOVb qu9azqgkRhYSE7teh3KF5fZSS5ixDQ//guF29G/FQB6xehIBXBEssHqJceWpjOTZ2fdX RXRQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tUFcYyDO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id c10-20020a056a000aca00b0051c50aa4266si17668362pfl.41.2022.06.15.07.19.18; Wed, 15 Jun 2022 07:19:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=tUFcYyDO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348964AbiFONrp (ORCPT + 99 others); Wed, 15 Jun 2022 09:47:45 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348939AbiFONri (ORCPT ); Wed, 15 Jun 2022 09:47:38 -0400 Received: from mail-yb1-xb2f.google.com (mail-yb1-xb2f.google.com [IPv6:2607:f8b0:4864:20::b2f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB7B42AEA for ; Wed, 15 Jun 2022 06:47:37 -0700 (PDT) Received: by mail-yb1-xb2f.google.com with SMTP id v81so20699330ybe.0 for ; Wed, 15 Jun 2022 06:47:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mONcnYz+UzOM2FqAirFVMXvA1LDZQM3Ao3LXZabuA5g=; b=tUFcYyDOZ+9Ur1jyUwdIVJM6cJhA6p54V/BQEEerpF+ZZaqqZ6SCG6EgnUNRjtxNg2 2mOxeXzfh+xiUGsy0W2LCQJL6NpBDAR4h1tFB3Ijv15nn7XH7egNqAKByj7vp3cpogWs D9Y6JADpvRSRMrSYn4GpLcblQEJ+Bx6WfQ/4OG6kpjnM3LGH3HhAmPphWt4dtWMx+GBI woTaT91TPoWeY/fXWDx1IVy8fmBjvwBJwE5nwqVGD1lW95tEX5w2AHc5CO41WkrQLfF9 7HP6ar7Nyf6ZbIYleWoi25Do2vf2sM0coAX4KI3vp3vMTBmFJ52CfyXGhfQDvqU44iB+ ljSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mONcnYz+UzOM2FqAirFVMXvA1LDZQM3Ao3LXZabuA5g=; b=jQBmkx754ttCEu8JkxdO8wcES2ZoVPnRL3iHYPKVV0pzjX5a1i8PVIjMvjeGk+WPCO gQPGvJ68nlc7njy/LKww9offMIo9D7AJlnXScI/2VE8+SAhUYW+XsvYH/EizK3kk6mZ2 CkFyGLF0XnusUyAxQ5rP2RT1kmukn9IeJfAV4zteYtHlvvnjNJGqtHbRYzZGXuPi2vNA 6+ePNGITy6q0ei1JcRTzDBA1czQR7mvVgXjnIJnGyj83Ih298TS+6QA4mjltAYuGZRfm HHHniUuIN0bREfoGh8ZTp9Iy9eh3a6/8DWU+QiJv2H2DGBccxJ0wkPC6uW8QJLi6V1M0 e52Q== X-Gm-Message-State: AJIora/pt/iEQyK15kZvpPBe2CRl5ANL2JG/NdIrCNJuFIxXA8UhBG9i 2EYjP2Kg9gG7YKZOV8Y+2m4PapomBMc+PCcBfDPJY53hF5A= X-Received: by 2002:a25:1256:0:b0:65d:6433:7993 with SMTP id 83-20020a251256000000b0065d64337993mr10101263ybs.626.1655300856998; Wed, 15 Jun 2022 06:47:36 -0700 (PDT) MIME-Version: 1.0 References: <20220605084854.29659-1-linmq006@gmail.com> In-Reply-To: <20220605084854.29659-1-linmq006@gmail.com> From: Linus Walleij Date: Wed, 15 Jun 2022 15:47:25 +0200 Message-ID: Subject: Re: [PATCH] ARM: versatile: Fix refcount leak in ap_init_of To: Miaoqian Lin Cc: Russell King , Arnd Bergmann , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=0.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,SUSPICIOUS_RECIPS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 5, 2022 at 10:49 AM Miaoqian Lin wrote: > of_find_matching_node() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: e67ae6be734d ("ARM: integrator: hook the AP into the SoC bus") > Fixes: df36680f1a71 ("ARM: integrator: core module registers from compatible strings") > Signed-off-by: Miaoqian Lin Patch applied! Yours, Linus Walleij