Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp536528iog; Wed, 15 Jun 2022 07:20:14 -0700 (PDT) X-Google-Smtp-Source: AGRyM1v/APbScC5oSVN+wdqH5z8d4ba2hKiz1/UO+S+z533IDnHn96PrdJVltGE3T0+Fyob/Sekm X-Received: by 2002:a63:b60a:0:b0:408:d61b:77ac with SMTP id j10-20020a63b60a000000b00408d61b77acmr62637pgf.432.1655302813937; Wed, 15 Jun 2022 07:20:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655302813; cv=none; d=google.com; s=arc-20160816; b=mU/TG9liz3/nHL/wdqzJyDU0Q+nwyRXeWDaFZUsw9kVnAnUBBF014J/qcAieXkBMWi bWwl/3L+4M7AaMykblJmJVJHgDfI9FRlx0Dx8Wld5i8wAm1RCiP7yF26xjcE+Aw2ZgZL j0Mn6jXjuhTRz1xE54BSn2gJq6UMCouxK9WFV6njA+t7t+LhxcEPkV80Qe6TVCz+PoBp o/iGmbFjK5s5IafDk6I9UVKIk9c2BlEfRo6XRzOxNCh9RcV6h2wKxMe0307dFqwSzjnV Y8vWxl/A+Y6B3g5704czScmMW7WuJlwnOhuDatwJfMNEEk3FXwx7mUc0AbM0zm+BJU9U /rzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=TKNmlelPMUUwEhyo/oW2GfDg9fGO0GWkAQdbd+usNG0=; b=S25LZkOYVxy5J0VbH3B5trIebKquwxlu/7ifvKdLuqnVrugHblZNpSw/HF58edXTOi /z2zH4rW4RpYdPD0f4acfkzAzj9FOgipIl35AYJhDEhAq3R3p3Tk42iE5QXULwBHsLEu 1IkC/T8Nm+v9y5XmvsjBe18koO1AAgJuGot8n0HKMg1qsRnyPvIXxnSNi78hdrrWfNru oYGEw8NROFO8OhDpZoilGYROi5sJsbzKExZiSyzYf9imbAGbSvyHJiYsLf95XwcI5Iwc RIN2p/MjDHB4SkJdGWem22lAQoprb9LAgGUXFsbNTjOh7aNKuQttNYOUbOVOAW45oj8h gJUw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hhk5ooKm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id iw6-20020a170903044600b00163d77ce6acsi15969558plb.615.2022.06.15.07.19.59; Wed, 15 Jun 2022 07:20:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Hhk5ooKm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244127AbiFOOEj (ORCPT + 99 others); Wed, 15 Jun 2022 10:04:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51320 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355971AbiFOOEh (ORCPT ); Wed, 15 Jun 2022 10:04:37 -0400 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADB6323BCB for ; Wed, 15 Jun 2022 07:04:36 -0700 (PDT) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-30ec2aa3b6cso61814727b3.11 for ; Wed, 15 Jun 2022 07:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TKNmlelPMUUwEhyo/oW2GfDg9fGO0GWkAQdbd+usNG0=; b=Hhk5ooKmiw/m4i7aPxBot9kGRRD4QfdArggzSzM1SVYadr1ayhHvdo0Lf2/Twv4K3v jYq2sbCVcfkaursJKcvjxYIOAOWgCibUIArbV5dqqKvm2HU1zksAyPgEsqoxpEr1dFxF TJS7ncF98C5hZIDPDc5Q0ao/FWu2b51fJxaOZS+7j3wdLgyARfPd21tN1FAjd37XByP1 tMxMNMaoRie1uKHl3QFXUlm4wqmLoRGmmCjvDpXCxP83wB9cgXLIhfqiQppMC76e8JNL xui5hyqZ4b8F2FsfjmoaZNDc3fuo8nDZrviLYt+kiNM7UaALnCXM5F053RXiWxk71KoG hpjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TKNmlelPMUUwEhyo/oW2GfDg9fGO0GWkAQdbd+usNG0=; b=ePI5wj5v3OjtmhY2KscQU5jaGc3YyAWPTG0kNN7mMP62XZgl+EnTYVG5zsTfM3fAV7 fqjkzRMyU7SfEsZX16eHVZCHOG5BwM/uQSE1PB3CBC69y89ILDLHtK0L5FgbmzRfBSnu 3LB/ei5H7BUR+GE6sOTlJj6l+2qjaScSltqzugbYS2TfPx4BiW2u0b8jNqMlcLgPBm/f ZHGid4cx6bC62ptodEf5hEgU3d+oUL/Ii4k4RYOAEUmBlE1h8uWLNqR+m93V1sOpE1Ei HrD3OQydkmk88G2WZPbpZq0gKgYmlAfKPste/z8NhVJ2tA4vkgMTCXXVNaR6I4sq3sP1 SnzA== X-Gm-Message-State: AJIora9Nl2lNdO+Q03rhg2SCFXTL/TDyIetpVVhultAndv9k+2Q4Mjuy Cpo9HVPW6ybPRnpW7nhUnwjRJq9Tpkkoy8UcjEWeSQ== X-Received: by 2002:a81:830f:0:b0:313:3918:5cf with SMTP id t15-20020a81830f000000b00313391805cfmr11990562ywf.126.1655301875869; Wed, 15 Jun 2022 07:04:35 -0700 (PDT) MIME-Version: 1.0 References: <20220607111602.57355-1-linmq006@gmail.com> In-Reply-To: <20220607111602.57355-1-linmq006@gmail.com> From: Linus Walleij Date: Wed, 15 Jun 2022 16:04:24 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: nomadik: Fix refcount leak in nmk_pinctrl_dt_subnode_to_map To: Miaoqian Lin Cc: linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 7, 2022 at 1:16 PM Miaoqian Lin wrote: > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak." > > Fixes: c2f6d059abfc ("pinctrl: nomadik: refactor DT parser to take two paths") > Signed-off-by: Miaoqian Lin Patch applied! Yours, Linus Walleij