Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <6e1f0081-5f1c-4865-cb66-dd2cf9a5c868@foss.st.com>
Date:   Wed, 15 Jun 2022 16:42:34 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH] dmaengine: stm32-mdma: Remove dead code in
 stm32_mdma_irq_handler()
Content-Language: en-US
To:     Alexey Khoroshilov <khoroshilov@ispras.ru>,
        Vinod Koul <vkoul@kernel.org>,
        Amelie Delaunay <amelie.delaunay@st.com>
CC:     <dmaengine@vger.kernel.org>,
        <linux-stm32@st-md-mailman.stormreply.com>,
        <linux-kernel@vger.kernel.org>, <ldv-project@linuxtesting.org>
References: <1655072638-9103-1-git-send-email-khoroshilov@ispras.ru>
From:   Amelie Delaunay <amelie.delaunay@foss.st.com>
In-Reply-To: <1655072638-9103-1-git-send-email-khoroshilov@ispras.ru>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi Alexey,

On 6/13/22 00:23, Alexey Khoroshilov wrote:
> Local variable chan is initialized by an address of element of chan array
> that is part of stm32_mdma_device struct, so it does not make sense to
> compare chan with NULL.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Signed-off-by: Alexey Khoroshilov <khoroshilov@ispras.ru>
> Fixes: a4ffb13c8946 ("dmaengine: Add STM32 MDMA driver")
> ---
>   drivers/dma/stm32-mdma.c | 5 -----
>   1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c
> index caf0cce8f528..b11927ed4367 100644
> --- a/drivers/dma/stm32-mdma.c
> +++ b/drivers/dma/stm32-mdma.c
> @@ -1328,12 +1328,7 @@ static irqreturn_t stm32_mdma_irq_handler(int irq, void *devid)
>   		return IRQ_NONE;
>   	}
>   	id = __ffs(status);
> -
>   	chan = &dmadev->chan[id];
> -	if (!chan) {
> -		dev_warn(mdma2dev(dmadev), "MDMA channel not initialized\n");
> -		return IRQ_NONE;
> -	}
>   
>   	/* Handle interrupt for the channel */
>   	spin_lock(&chan->vchan.lock);

Thanks for your patch,

Reviewed-by: Amelie Delaunay <amelie.delaunay@foss.st.com>