Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp568306iog; Wed, 15 Jun 2022 07:54:42 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vrjJL97FX9E0cBYSSHFEe2+WHTdC+aztci7JiPqLyBDhi3cZQSHzr3SRaLPHydKyr1LRhS X-Received: by 2002:a05:6402:3224:b0:42d:e68c:2fd with SMTP id g36-20020a056402322400b0042de68c02fdmr154516eda.282.1655304882572; Wed, 15 Jun 2022 07:54:42 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655304882; cv=none; d=google.com; s=arc-20160816; b=EWfm5gDjMzccBN6d4c4wRi678dTuY0xnP5bEoAumts7x5JUEsc/lNF6Zj/4esPhY38 2l/SZHFVPNOH4vmxukv5q0ZK3+Ar0/CSzL+SrR5nB+Ya3ECfSTlrMAcQXvW7KgcqTynT 0WqpNND85EJ+gDdnBwtCB/2LNnLZSmMaTN1VY/rCyeLDxO1H1jTHYyskvgnBG9thEmYX qYCfA5dnM1O2MggOGKWQ3mVi1T7Q4yuNA9fKHXh+pTmuWf7tTiS3z+gAkb2w2QfK0u80 /WJTh0RPPO+fpbulrMIeNcSWkGZE4ZUmci+ie8yc1ZgIcVHsIb0p7SBNjvpuPAmahmAb Zekw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=83JGc98WsScowPIY7ZO27KJQP1VWWsaM4yST4jBTRzM=; b=gRc8cFIj9pi7Yum6dx/hqezdyzczhGw7ThddLkdqbJMvgJuyZCbJtdhTHrs0Ap2nwk JgphxrqHYhMskG1o/zj9wkg+sFFdZEY352XV4JslpnafNqAyJ2aZJWvwqrrU3C6MTC1u eN5XYowEg1jUGcBw3oI6Frlw3ev/wlSPK4DPHhTgx7h6uwtsTYQCzc1tg4BPPXA8igRW AaItHFTMZzFWwF5D9UzndrQxRt8qwXmxrEUCt12xPh+17G9JDxVfBkrq62i8mlWMkTJ2 1bkYXwHXeXN+qLgt2qld5Pyxa6Mg2J9/09Dwid0S5MLCcQe0mZc54yRBsieQV+gypckb C/gQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id e20-20020a056402191400b0042df0b0c01esi17968972edz.43.2022.06.15.07.54.17; Wed, 15 Jun 2022 07:54:42 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1353695AbiFOOox (ORCPT + 99 others); Wed, 15 Jun 2022 10:44:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59470 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1353179AbiFOOow (ORCPT ); Wed, 15 Jun 2022 10:44:52 -0400 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id CE6F03632C; Wed, 15 Jun 2022 07:44:50 -0700 (PDT) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id B77CC153B; Wed, 15 Jun 2022 07:44:50 -0700 (PDT) Received: from pierre123.arm.com (unknown [10.57.5.38]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id A244C3F73B; Wed, 15 Jun 2022 07:44:47 -0700 (PDT) From: Pierre Gondois To: linux-kernel@vger.kernel.org Cc: Ionela.Voinescu@arm.com, Lukasz.Luba@arm.com, Dietmar.Eggemann@arm.com, Pierre Gondois , "Rafael J. Wysocki" , Viresh Kumar , Andy Gross , Bjorn Andersson , Dmitry Baryshkov , Vladimir Zapolskiy , linux-pm@vger.kernel.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 1/4] cpufreq: qcom-hw: Reset cancel_throttle when policy is re-enabled Date: Wed, 15 Jun 2022 16:43:18 +0200 Message-Id: <20220615144321.262773-2-pierre.gondois@arm.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220615144321.262773-1-pierre.gondois@arm.com> References: <20220615144321.262773-1-pierre.gondois@arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org If LMH (Limits Management Hardware) is available, when a policy is disabled by unplugging the last online CPU of policy->cpus, qcom_cpufreq_hw_cpu_offline() sets cancel_throttle=true. cancel_throttle is not reset when the policy is re-enabled with any of the CPU in policy->cpus being plugged in. So reset it. This patch also adds an early exit check. Fixes: a1eb080a0447 ("cpufreq: qcom-hw: provide online/offline operations") Signed-off-by: Pierre Gondois --- drivers/cpufreq/qcom-cpufreq-hw.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c index 0253731d6d25..8aba73698eda 100644 --- a/drivers/cpufreq/qcom-cpufreq-hw.c +++ b/drivers/cpufreq/qcom-cpufreq-hw.c @@ -442,6 +442,13 @@ static int qcom_cpufreq_hw_cpu_online(struct cpufreq_policy *policy) struct platform_device *pdev = cpufreq_get_driver_data(); int ret; + if (data->throttle_irq < 0) + return 0; + + mutex_lock(&data->throttle_lock); + data->cancel_throttle = false; + mutex_unlock(&data->throttle_lock); + ret = irq_set_affinity_hint(data->throttle_irq, policy->cpus); if (ret) dev_err(&pdev->dev, "Failed to set CPU affinity of %s[%d]\n", -- 2.25.1