Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220613150653.1310029-1-zhengbin13@huawei.com>
In-Reply-To: <20220613150653.1310029-1-zhengbin13@huawei.com>
From:   Robert Foss <robert.foss@linaro.org>
Date:   Wed, 15 Jun 2022 18:31:02 +0200
Message-ID: <CAG3jFysx_sS2QAdh2G9xivD8OjNXRPn1H0zVq=1V4P7yi7UoOw@mail.gmail.com>
Subject: Re: [PATCH -next] drm/bridge: it6505: Add missing CRYPTO_HASH dependency
To:     Zheng Bin <zhengbin13@huawei.com>
Cc:     andrzej.hajda@intel.com, narmstrong@baylibre.com,
        Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        angelogioacchino.delregno@collabora.com,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        gaochao49@huawei.com
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, 13 Jun 2022 at 16:54, Zheng Bin <zhengbin13@huawei.com> wrote:
>
> The driver uses crypto hash functions so it needs to select CRYPTO_HASH.
> This fixes build errors:
>
> drivers/gpu/drm/bridge/ite-it6505.o: in function `it6505_hdcp_wait_ksv_list':
> ite-it6505.c:(.text+0x4c26): undefined reference to `crypto_alloc_shash'
> ite-it6505.c:(.text+0x4c6d): undefined reference to `crypto_shash_digest'
> ite-it6505.c:(.text+0x4c7d): undefined reference to `crypto_destroy_tfm'
> ite-it6505.c:(.text+0x4d69): undefined reference to `crypto_destroy_tfm'
>
> Fixes: b5c84a9edcd4 ("drm/bridge: add it6505 driver")
> Signed-off-by: Zheng Bin <zhengbin13@huawei.com>
> ---
>  drivers/gpu/drm/bridge/Kconfig | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/Kconfig b/drivers/gpu/drm/bridge/Kconfig
> index 8ffd601e68f9..1afe99dac0ff 100644
> --- a/drivers/gpu/drm/bridge/Kconfig
> +++ b/drivers/gpu/drm/bridge/Kconfig
> @@ -94,6 +94,8 @@ config DRM_ITE_IT6505
>          select DRM_KMS_HELPER
>          select DRM_DP_HELPER
>          select EXTCON
> +        select CRYPTO
> +        select CRYPTO_HASH
>          help
>            ITE IT6505 DisplayPort bridge chip driver.
>
> --
> 2.31.1
>

Reviewed-by: Robert Foss <robert.foss@linaro.org>

Applied to drm-misc-next