Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220522162802.208275-1-luca@z3ntu.xyz> <20220522162802.208275-11-luca@z3ntu.xyz>
In-Reply-To: <20220522162802.208275-11-luca@z3ntu.xyz>
From:   Loic Poulain <loic.poulain@linaro.org>
Date:   Wed, 15 Jun 2022 19:11:25 +0200
Message-ID: <CAMZdPi82+xW2yoKQrg61Mj_-kLCBbp=VDQNDDccQpv5=i_V6Vw@mail.gmail.com>
Subject: Re: [RFC PATCH 10/14] i2c: qcom-cci: add msm8974 compatible
To:     Luca Weiss <luca@z3ntu.xyz>
Cc:     linux-arm-msm@vger.kernel.org,
        ~postmarketos/upstreaming@lists.sr.ht, phone-devel@vger.kernel.org,
        Robert Foss <robert.foss@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Todor Tomov <todor.too@gmail.com>,
        Andy Gross <agross@kernel.org>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-i2c@vger.kernel.org, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
        matti.lehtimaki@gmail.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Sun, 22 May 2022 at 18:28, Luca Weiss <luca@z3ntu.xyz> wrote:
>
> From: Matti Lehtim=C3=A4ki <matti.lehtimaki@gmail.com>
>
> MSM8974 CCI is the same as MSM8916 except it has two masters.
>
> Signed-off-by: Matti Lehtim=C3=A4ki <matti.lehtimaki@gmail.com>
> Signed-off-by: Luca Weiss <luca@z3ntu.xyz>

Reviewed-by: Loic Poulain <loic.poulain@linaro.org>

> ---
> To note, the cci_v1_5_data variable name is just a bit arbitrary and
> isn't meant to reflect IP version "1.5". I'd be happy to change the
> variable name to something else.
>
>  drivers/i2c/busses/i2c-qcom-cci.c | 35 +++++++++++++++++++++++++++++++
>  1 file changed, 35 insertions(+)
>
> diff --git a/drivers/i2c/busses/i2c-qcom-cci.c b/drivers/i2c/busses/i2c-q=
com-cci.c
> index 5c7cc862f08f..a68f17eb9dd0 100644
> --- a/drivers/i2c/busses/i2c-qcom-cci.c
> +++ b/drivers/i2c/busses/i2c-qcom-cci.c
> @@ -725,6 +725,40 @@ static const struct cci_data cci_v1_data =3D {
>         },
>  };
>
> +static const struct cci_data cci_v1_5_data =3D {
> +       .num_masters =3D 2,
> +       .queue_size =3D { 64, 16 },
> +       .quirks =3D {
> +               .max_write_len =3D 10,
> +               .max_read_len =3D 12,
> +       },
> +       .cci_clk_rate =3D  19200000,
> +       .params[I2C_MODE_STANDARD] =3D {
> +               .thigh =3D 78,
> +               .tlow =3D 114,
> +               .tsu_sto =3D 28,
> +               .tsu_sta =3D 28,
> +               .thd_dat =3D 10,
> +               .thd_sta =3D 77,
> +               .tbuf =3D 118,
> +               .scl_stretch_en =3D 0,
> +               .trdhld =3D 6,
> +               .tsp =3D 1
> +       },
> +       .params[I2C_MODE_FAST] =3D {
> +               .thigh =3D 20,
> +               .tlow =3D 28,
> +               .tsu_sto =3D 21,
> +               .tsu_sta =3D 21,
> +               .thd_dat =3D 13,
> +               .thd_sta =3D 18,
> +               .tbuf =3D 32,
> +               .scl_stretch_en =3D 0,
> +               .trdhld =3D 6,
> +               .tsp =3D 3
> +       },
> +};
> +
>  static const struct cci_data cci_v2_data =3D {
>         .num_masters =3D 2,
>         .queue_size =3D { 64, 16 },
> @@ -773,6 +807,7 @@ static const struct cci_data cci_v2_data =3D {
>
>  static const struct of_device_id cci_dt_match[] =3D {
>         { .compatible =3D "qcom,msm8916-cci", .data =3D &cci_v1_data},
> +       { .compatible =3D "qcom,msm8974-cci", .data =3D &cci_v1_5_data},
>         { .compatible =3D "qcom,msm8996-cci", .data =3D &cci_v2_data},
>         { .compatible =3D "qcom,sdm845-cci", .data =3D &cci_v2_data},
>         { .compatible =3D "qcom,sm8250-cci", .data =3D &cci_v2_data},
> --
> 2.36.0
>