Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220615160116.528c324b@canb.auug.org.au> <1f8095db-a08f-7b6b-2cee-f530d914b9f8@infradead.org>
In-Reply-To: <1f8095db-a08f-7b6b-2cee-f530d914b9f8@infradead.org>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Wed, 15 Jun 2022 19:10:53 +0200
Message-ID: <CAK8P3a2mQiWKyVux+bfAJiRH=72q76UTLZnBbPCLVFVoXpGfaw@mail.gmail.com>
Subject: Re: linux-next: Tree for Jun 15 (drivers/dma/apple-admac.c)
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        =?UTF-8?Q?Martin_Povi=C5=A1er?= <povik+lin@cutebit.org>,
        linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
        dmaengine@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Wed, Jun 15, 2022 at 6:28 PM Randy Dunlap <rdunlap@infradead.org> wrote:
>
>
>
> On 6/14/22 23:01, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20220614:
> >
>
> on i386:
>
> ../drivers/dma/apple-admac.c: In function 'admac_cyclic_write_one_desc':
> ../drivers/dma/apple-admac.c:213:22: warning: right shift count >= width of type [-Wshift-count-overflow]
>   writel_relaxed(addr >> 32,       ad->base + REG_DESC_WRITE(channo));
>                       ^

This should probably use lower_32_bits()/upper_32_bits() then.

       Arnd