Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 15 Jun 2022 13:51:13 -0400
From:   Peter Xu <peterx@redhat.com>
To:     Mike Kravetz <mike.kravetz@oracle.com>
Cc:     linux-kernel@vger.kernel.org, linux-mm@kvack.org,
        Muchun Song <songmuchun@bytedance.com>,
        Michal Hocko <mhocko@suse.com>,
        Naoya Horiguchi <naoya.horiguchi@linux.dev>,
        James Houghton <jthoughton@google.com>,
        Mina Almasry <almasrymina@google.com>,
        "Aneesh Kumar K . V" <aneesh.kumar@linux.vnet.ibm.com>,
        Anshuman Khandual <anshuman.khandual@arm.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        Christian Borntraeger <borntraeger@linux.ibm.com>,
        Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC PATCH 1/3] hugetlb: skip to end of PT page mapping when pte
 not present
Message-ID: <YqocEWUWkr09RLuk@xz-m1.local>
References: <20220527225849.284839-1-mike.kravetz@oracle.com>
 <20220527225849.284839-2-mike.kravetz@oracle.com>
 <YpUhe6BSfflOVz7b@xz-m1.local>
 <e9456223-c26a-4d49-2920-9a597a817190@oracle.com>
 <YqoWfcZXJ7NfJaYJ@monkey>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <YqoWfcZXJ7NfJaYJ@monkey>
Precedence: bulk

On Wed, Jun 15, 2022 at 10:27:25AM -0700, Mike Kravetz wrote:
> In many cases, the hugetlb specific page table routines are the same as
> the generic routines.  But, there are a few exceptions.  IMO, it would
> be better to first try to cleanup and unify those routines.  That would
> make changes to the walker routines less invasive and easier to
> maintain.  I believe is other code that would benefit from such a
> cleanup.  Unless there are strong objections, I suggest we move forward
> with the optimization here and move the cleanup and possible walker
> changes to a later series.

No objection on my side, thanks Mike for trying to look into it.

-- 
Peter Xu