Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <9ff7adc6-570f-8089-c93d-b10fcafc02b6@kali.org>
Date:   Wed, 15 Jun 2022 13:03:24 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH 2/2] drm/msm: Don't overwrite hw fence in hw_init
Content-Language: en-US
To:     Rob Clark <robdclark@gmail.com>, dri-devel@lists.freedesktop.org
Cc:     freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
        Rob Clark <robdclark@chromium.org>,
        Abhinav Kumar <quic_abhinavk@quicinc.com>,
        Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Akhil P Oommen <quic_akhilpo@quicinc.com>,
        Jonathan Marek <jonathan@marek.ca>,
        =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>,
        Dan Carpenter <dan.carpenter@oracle.com>,
        open list <linux-kernel@vger.kernel.org>
References: <20220615150107.2969593-1-robdclark@gmail.com>
 <20220615150107.2969593-2-robdclark@gmail.com>
From:   Steev Klimaszewski <steev@kali.org>
In-Reply-To: <20220615150107.2969593-2-robdclark@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 6/15/22 10:01 AM, Rob Clark wrote:
> From: Rob Clark <robdclark@chromium.org>
>
> Prior to the last commit, this could result in setting the GPU
> written fence value back to an older value, if we had missed
> updating completed_fence prior to suspend.  This was mostly
> harmless as the GPU would eventually overwrite it again with
> the correct value.  But we should just not do this.  Instead
> just leave a sanity check that the fence looks plausible (in
> case the GPU scribbled on memory).
>
> Reported-by: Steev Klimaszewski <steev@kali.org>
> Fixes: 95d1deb02a9c ("drm/msm/gem: Add fenced vma unpin")
> Signed-off-by: Rob Clark <robdclark@chromium.org>
> ---
>   drivers/gpu/drm/msm/adreno/adreno_gpu.c | 11 ++++++++---
>   drivers/gpu/drm/msm/msm_gpu.c           |  2 +-
>   2 files changed, 9 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/msm/adreno/adreno_gpu.c b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> index e1aef4875e2f..dd044d557c7c 100644
> --- a/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> +++ b/drivers/gpu/drm/msm/adreno/adreno_gpu.c
> @@ -498,10 +498,15 @@ int adreno_hw_init(struct msm_gpu *gpu)
>   
>   		ring->cur = ring->start;
>   		ring->next = ring->start;
> -
> -		/* reset completed fence seqno: */
> -		ring->memptrs->fence = ring->fctx->completed_fence;
>   		ring->memptrs->rptr = 0;
> +
> +		/* Detect and clean up an impossible fence, ie. if GPU managed
> +		 * to scribble something invalid, we don't want that to confuse
> +		 * us into mistakingly believing that submits have completed.
> +		 */
> +		if (fence_before(ring->fctx->last_fence, ring->memptrs->fence)) {
> +			ring->memptrs->fence = ring->fctx->last_fence;
> +		}
>   	}
>   
>   	return 0;
> diff --git a/drivers/gpu/drm/msm/msm_gpu.c b/drivers/gpu/drm/msm/msm_gpu.c
> index b61078f0cd0f..8c00f9187c03 100644
> --- a/drivers/gpu/drm/msm/msm_gpu.c
> +++ b/drivers/gpu/drm/msm/msm_gpu.c
> @@ -430,7 +430,7 @@ static void recover_worker(struct kthread_work *work)
>   		 * one more to clear the faulting submit
>   		 */
>   		if (ring == cur_ring)
> -			fence++;
> +			ring->memptrs->fence = ++fence;
>   
>   		msm_update_fence(ring->fctx, fence);
>   	}

Tested on the Lenovo Yoga C630

Tested-by: Steev Klimaszewski <steev@kali.org>