Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220615180213.760756-1-e.velu@criteo.com> <YqonwfjE8BL6Xowf@kbusch-mbp>
In-Reply-To: <YqonwfjE8BL6Xowf@kbusch-mbp>
From:   Erwan Velu <erwanaliasr1@gmail.com>
Date:   Wed, 15 Jun 2022 20:52:35 +0200
Message-ID: <CAL2Jzux0ZnrJRocxj3X8YVwAb56krPtHUtKDnNqCURUJzgPoag@mail.gmail.com>
Subject: Re: [PATCH] nvme: Report model,sn,fw,pci device information during init
To:     Keith Busch <kbusch@kernel.org>
Cc:     Erwan Velu <e.velu@criteo.com>, Jens Axboe <axboe@fb.com>,
        Christoph Hellwig <hch@lst.de>,
        Sagi Grimberg <sagi@grimberg.me>,
        "open list:NVM EXPRESS DRIVER" <linux-nvme@lists.infradead.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

[...]

> The PCI_ID: print is misleading. That format usually indicates VID:DID, but
> you're printing VID:SSVID.
True.

> This is also very similar to the recently introduced nvme_print_device_info(),
> but that one removes the annoying trailing spaces if they exist. I guess if
> we're going this direction, just use that print, but change it from dev_err to
> dev_info, and remove the call on global id collision detection.
Oh I missed it.
Shall I provide a patch for nvme-5.19 or wait until the next window ?