Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Kechen Lu <kechenl@nvidia.com>
To:     Chao Gao <chao.gao@intel.com>
CC:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "seanjc@google.com" <seanjc@google.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        Somdutta Roy <somduttar@nvidia.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [RFC PATCH v3 7/7] KVM: selftests: Add tests for VM and vCPU cap
 KVM_CAP_X86_DISABLE_EXITS
Thread-Topic: [RFC PATCH v3 7/7] KVM: selftests: Add tests for VM and vCPU cap
 KVM_CAP_X86_DISABLE_EXITS
Thread-Index: AQHYgFW05l6dlnrEPEaeZiMoTvE3oK1Py00AgAD6S2A=
Date:   Wed, 15 Jun 2022 18:21:53 +0000
Message-ID: <DM6PR12MB3500F48AD42562C7DB7A3DEACAAD9@DM6PR12MB3500.namprd12.prod.outlook.com>
References: <20220615011622.136646-1-kechenl@nvidia.com>
 <20220615011622.136646-8-kechenl@nvidia.com> <20220615031407.GC7808@gao-cwp>
In-Reply-To: <20220615031407.GC7808@gao-cwp>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?fLTEybJjv6+dL2qnlVaechPxudw7pX+sVG9xgkKjSMM5UlFtwjLZJhqQ199Q?=
 =?us-ascii?Q?PWiDklIeApNZ0UG4TUtR6I5iA1/PjR4VpkcgoP4/oabBYgJP2GWNQEFZEsON?=
 =?us-ascii?Q?A7qZDOtuyGqWyNieymBPEzmwY7k8QqDe+YG7+vzWpy+VEjG9wC1KRzBiyDQn?=
 =?us-ascii?Q?6YC4uFYTzrP9qpZMFokF12pPfHDqnlbliZ8CKlVLvrFHhS2Go4ICnbmxrjyQ?=
 =?us-ascii?Q?kx5eF8MQbaZ2D8t4SiHoS8dj4ehQVlXJcxli0DTaY22RZFBBtDHIhvLsUAYD?=
 =?us-ascii?Q?MJG2pvDR8Utbs3bKivwvygxCGbDKWPwiJH7FNvnT5V1AqG68EkUkKuhCykUp?=
 =?us-ascii?Q?dbk+s2VeOQYfZVxGy9y/9zQ6vJCx50p08Dv5WsoBTMBmmGYqb1sfBDzHI2nV?=
 =?us-ascii?Q?xyshLQF/FkO9NNZDegns4bOnEJwJ4HlTGYYOpE/NuuxJX1XWhJpoGkCupgZ/?=
 =?us-ascii?Q?twcPAHWiUMBtVn0QSAL41PRfl0gfDwo1vIXP4ns1nGHHcEdlmKoQ5bVjGf21?=
 =?us-ascii?Q?K+LGLz8S624DQlovtCvtlvHJ+N6J/IOc+LnMgauSSbLBCwPgRfXJ3EP1I/QJ?=
 =?us-ascii?Q?ZEOAwLwAi6X78HSdEvzTuCK+dlST5BqsMM2vllay0Mkz/KYa3JdETcwWpJiQ?=
 =?us-ascii?Q?APfT4RIUK6ITyMBbX9Cv7zNCzoIMcaMsqcDVgmXRqW+mUF+KTCBbw8LRMueT?=
 =?us-ascii?Q?Yksc3BUhqYovn+gD/BAnaoUy/WkvxlxEFnb+Dk1686oW4LX7zLshkYf2CZdJ?=
 =?us-ascii?Q?u6DJAB+10qCv/c/YfxwzU/u6OO5SG0TVG95aED1z1f+Tb9X2S4URZjcf/BtV?=
 =?us-ascii?Q?X68wvL3qX96umMS8aDF8e9uUHiMw3V5ukGho2BHQi1ZUuLX9NaaG/mvgG0dq?=
 =?us-ascii?Q?ohBO6izFPTtkNr4yGx62RDtCTfeISSyZTQtBk1ucaZfoEzIUoIWdSYU8yhQ4?=
 =?us-ascii?Q?T1kgiXyZYq4HPz0i8ljzETxf8cOuplE0wteZYPNYjaAv0aRyXk6xMQZ+fgeu?=
 =?us-ascii?Q?y0IPBhh1K2ySmmcR1sobjJdJWc+TnOwlJOBb6YUPN+wZWng/np3paMHx2Um0?=
 =?us-ascii?Q?uoHBsYpGXHMokCj2kBJqBN6kum8JLntCC6UjL0RYV9Vq9qwo/5A6rHlGCDVe?=
 =?us-ascii?Q?bmsrjgMFILADCFrWUL5Es7Uo2KaNFm6Me4IQNo2IL8OWZqi2asa08WaK4yzX?=
 =?us-ascii?Q?D//G5UnJS/dhaB1VcGfae+u8bKVf0NA8Ey8+4Iyzl6si0wQsZW+4TQQdUXml?=
 =?us-ascii?Q?LJ5XrzdnqRRahLNBsQO7bTAiuSCDvXIFB1fruCB2IFDdDtSJWZI/gDLFP8r9?=
 =?us-ascii?Q?KhtihFlGV+kG1GZiMdFJ1Lco7vmKPyrEAi67I9lX4xqMYpnu/LvQYJ8yEyI6?=
 =?us-ascii?Q?KoChmkY5woCibCTwzJwpaipRbAclX0+Qsap9JtsqkpltC1WQeRv6Ppbbuumb?=
 =?us-ascii?Q?BWvhTo9W9PP4BvVLJHfj/wXSRV6fCPhM5vnO6YtEeBLqxHfeyrVca9BuZn12?=
 =?us-ascii?Q?oiRLr/kfXsICRWnBlZqtVJr2UeGSKrqAi0HopD9HKfPQOl9jyu4W4bjdhQp5?=
 =?us-ascii?Q?waKjpblY+lbLXcF4cf5I/ZAPduU+T61Lw0q2c0W6CoeXK2s17Mo5GoeiFx/K?=
 =?us-ascii?Q?Hqfk7hZqDpYZpebn+1oMs49jCOccsDEVH7nPO16FHvTR7tINtuHZPdICfAOc?=
 =?us-ascii?Q?qWNtvkRJLzXHuEEBCMdHNDWtMHCvKWeJeIgYXw4FLHfGhCptaPFc3lgWzFz4?=
 =?us-ascii?Q?6sAmYiP1Yg=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3500.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 8567fef0-5e29-4c58-7dd0-08da4efbec37
X-MS-Exchange-CrossTenant-originalarrivaltime: 15 Jun 2022 18:21:53.2851
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mAb8eqW7q4b99m51iSWdXUm5elOpVDTXJYJq2zcFoIxbaxlBkqSxWEENW90vAugNz1sY9jrycAPebt18LOr3vA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR12MB3156
X-Spam-Status: No, score=-2.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_NONE,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Chao,

> -----Original Message-----
> From: Chao Gao <chao.gao@intel.com>
> Sent: Tuesday, June 14, 2022 8:14 PM
> To: Kechen Lu <kechenl@nvidia.com>
> Cc: kvm@vger.kernel.org; pbonzini@redhat.com; seanjc@google.com;
> vkuznets@redhat.com; Somdutta Roy <somduttar@nvidia.com>; linux-
> kernel@vger.kernel.org
> Subject: Re: [RFC PATCH v3 7/7] KVM: selftests: Add tests for VM and vCPU
> cap KVM_CAP_X86_DISABLE_EXITS
>=20
> External email: Use caution opening links or attachments
>=20
>=20
> >+/* Set debug control for trapped instruction exiting to userspace */
> >+static void vcpu_set_debug_exit_userspace(struct kvm_vm *vm, int
> vcpuid,
> >+              struct kvm_guest_debug *debug) {
>=20
> The debug argument looks pointless. Probably you can remove it.

Makes sense. Thanks for pointing out. Will remove it.

BR,
Kechen

>=20
> >+      memset(debug, 0, sizeof(*debug));
> >+      debug->control =3D KVM_GUESTDBG_ENABLE |
> KVM_GUESTDBG_EXIT_USERSPACE;
> >+      vcpu_set_guest_debug(vm, VCPU_ID_1, debug); }