Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 15 Jun 2022 22:09:30 +0100
From:   Jonathan Cameron <jic23@kernel.org>
To:     "Sa, Nuno" <Nuno.Sa@analog.com>
Cc:     Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        Alexandru Ardelean <aardelean@deviqon.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Lars-Peter Clausen <lars@metafoo.de>
Subject: Re: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper
 header files
Message-ID: <20220615220930.710ed42d@jic23-huawei>
In-Reply-To: <PH0PR03MB6786A019FB9A1BA810DDE2BC99AD9@PH0PR03MB6786.namprd03.prod.outlook.com>
References: <20220615120803.41350-1-andriy.shevchenko@linux.intel.com>
        <PH0PR03MB6786A019FB9A1BA810DDE2BC99AD9@PH0PR03MB6786.namprd03.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Wed, 15 Jun 2022 12:15:48 +0000
"Sa, Nuno" <Nuno.Sa@analog.com> wrote:

> Hi Andy,
>=20
> > -----Original Message-----
> > From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Sent: Wednesday, June 15, 2022 2:08 PM
> > To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>;
> > Alexandru Ardelean <aardelean@deviqon.com>; linux-
> > iio@vger.kernel.org; linux-kernel@vger.kernel.org
> > Cc: Jonathan Cameron <jic23@kernel.org>; Lars-Peter Clausen
> > <lars@metafoo.de>
> > Subject: [PATCH v1 1/1] iio: adc: intel_mrfld_adc: explicitly add proper
> > header files
> >=20
> > [External]
> >=20
> > Do not trust the fact that iio.h includes of.h which in turn includes
> > all the headers we are relying on.
> >=20
> > The ultimate goal is to actually drop of.h from iio.h.
> >=20
> > Signed-off-by: Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com>
> > ---
> >=20
> > Jonathan, this should be squeezed before we remove of.h in iio.h
> > I think Nuno somehow missed this =20
>=20
> Yes, I did (compile) tested this on arm and arm64 as I said in the cover.
> I guess this one won't be enabled on those archs :).
>=20
> I was planning to send this on v2 (I did noticed the kernel test bot
> emails) but yeah, this should actually be included with the other
> patches before removing of.h from iio. Thanks!
>=20
> Reviewed-by: Nuno S=C3=A1 <nuno.sa@analog.com>

Applied.  Oddly didn't show up in my normal x86 build test.

As suggested, slotted in before the of.h removal patch.

Thanks,

Jonathan

>=20