Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp896541iog; Wed, 15 Jun 2022 15:05:01 -0700 (PDT) X-Google-Smtp-Source: AGRyM1vlJZxCLKyeiD6LVkqYlhBKld53hnXPe80xQvfg0zcTNoELeuSHY31GSRHN5NVIqBYXeVMT X-Received: by 2002:a63:6a43:0:b0:3fd:913e:9b02 with SMTP id f64-20020a636a43000000b003fd913e9b02mr1680958pgc.540.1655330701052; Wed, 15 Jun 2022 15:05:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655330701; cv=none; d=google.com; s=arc-20160816; b=eq5IjrM7iKPeTNP397YvO81TmXTvf9DlN9VTfE2ipEF9JupQHLzFL25vdV7U/iXPxI ZxW4QrjsHwT53bn4oTqm4iFnyEi1F9632ONI6FA0CV6a8tvBAfyQI60CAw+w5HWLqYG6 0gCPhr/hqM6ojntk1mk23l9J8GNUbaDGvN1KKquGKfxdP1wa1rnn1Qz9kkBJNQCdhSYD uPw3HgdK70Prf29zlNE+mphhlWqrbn6ltCr2nWBFt/cza2K6lKWFi8oq5z9ZGDFWORHV 6QA57WM3dJHXoa3m/fKIdsL2r9t96dHEZalqy07Jhijgk3ooGcS6vdJWoWqojmhnjDIj uyHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=gZ3udpFK2SaT9vmCeYN/wpvWhWsIcBFwQfLTZsfUbnc=; b=mZ163ebgJUXvBqGfciDXeaJx1yc59usPANGQGZ8XcOuLCf6G7APDdN/0Y9ZCyKZgp8 ucWsnXfTCZl75qK9KbsdFnt+DEApSk7szUaXqIe70dUZbhz81Li9C9Iun1WSoiaMIIfu vTPCG3w/VkWAHzqdrKkJRLAlzIK2SrIYeWBdnZitL9U/SaMj68z4lowasPwO0JnGRSTX 2v9IA7ZpjJbuyCtrGfmFP1iTqCBuC8fMz4mhcMoWPZ2JMnP/fglAvadG0NqQCPCvpk7i sET36+OzelhuFjIVqc+wy/hdk9efliIWqOhiJLG8JhuPA2w/Y85l0SVxci8ibcbHu5+c v7lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C3ad6DKQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id s12-20020a632c0c000000b003fe0466ea39si138721pgs.868.2022.06.15.15.04.20; Wed, 15 Jun 2022 15:05:01 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=C3ad6DKQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347019AbiFOVoK (ORCPT + 99 others); Wed, 15 Jun 2022 17:44:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36638 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241445AbiFOVoI (ORCPT ); Wed, 15 Jun 2022 17:44:08 -0400 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 432DA31931 for ; Wed, 15 Jun 2022 14:44:08 -0700 (PDT) Received: by mail-pj1-x1034.google.com with SMTP id y13-20020a17090a154d00b001eaaa3b9b8dso3245448pja.2 for ; Wed, 15 Jun 2022 14:44:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=gZ3udpFK2SaT9vmCeYN/wpvWhWsIcBFwQfLTZsfUbnc=; b=C3ad6DKQHGNJK4jz3m6jxUEqWb680HAOKQA466+BxsDOB1m0gXHK5Vx6KI2rYILqMa upDdvO0Qc4ZWYw9C/78Vg6pJFI/djX6YJpJRyYQHOjokBwIWUERWWDDGjUptbm1dw91Z vriyGs9Mzp891tyKVDuMfVKFX3d9LEGVg0yw2NMrQJcXfwfaZMyiCXIlyVd0x80b+03P hd5RNg5ZyEeN1hr2ixSV3Nl2lA2QMjDIR4ACuoVzuc2iGz4vixcDbTLhkJat+Zp7c3MJ 3rHiFF78Kdm1l+OKUr6krR9jtshunqBVgr0ydrygYJ0bikFwDzJmA9r861lpYfBWF3sn bIjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=gZ3udpFK2SaT9vmCeYN/wpvWhWsIcBFwQfLTZsfUbnc=; b=eAjNRWCjBf3YwkY19G6MgCQlZKvV2o4nqe251IcWlbV/7xncMnMUs5YHQlFvIg7a1T NM0cRvaga25H+XGoHctFWzmjJD1M7ocIqbcPBqYLQ8G/Lk5mB8fbg9i4RU4lxpwRQ+J0 5KF9R0hGtLsY6P5tjfvLW2yhgVc1qaPrS074jjFzqjG71Ewisyo8GAqAd9923XC9L+ob 0q0Zc3grsor/6Lqzsg80notpPlHZcXqUCjfzi+GcP9XOytJyfxf6QCndmZND8E48luZU 84jMRqz6mYzBGYvlRLqH3zAXsgyOVpBzSRHHV9bCPCj5eL7wFyT5XaD9F9/ZwRlNqRYi hkNw== X-Gm-Message-State: AJIora8vvIwL1V03EiOOJMYBDWG3bAWPjMMdwDHw1V8rQtZ4UN3Gf1mw s44H4lge9pe9IsRfFA852Ts1Dw== X-Received: by 2002:a17:90a:5ae1:b0:1db:d0a4:30a4 with SMTP id n88-20020a17090a5ae100b001dbd0a430a4mr1554816pji.128.1655329447759; Wed, 15 Jun 2022 14:44:07 -0700 (PDT) Received: from google.com ([192.77.111.2]) by smtp.gmail.com with ESMTPSA id i66-20020a62c145000000b00518950bfc82sm134050pfg.10.2022.06.15.14.44.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 14:44:07 -0700 (PDT) Date: Wed, 15 Jun 2022 22:44:05 +0100 From: Lee Jones To: Miaoqian Lin Cc: Mallikarjun Kasoju , Krzysztof Kozlowski , Laxman Dewangan , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mfd: max77620: Fix refcount leak in max77620_initialise_fps Message-ID: References: <20220601043222.64441-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220601043222.64441-1-linmq006@gmail.com> X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 01 Jun 2022, Miaoqian Lin wrote: > of_get_child_by_name() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: 327156c59360 ("mfd: max77620: Add core driver for MAX77620/MAX20024") > Signed-off-by: Miaoqian Lin > --- > drivers/mfd/max77620.c | 2 ++ > 1 file changed, 2 insertions(+) Applied, thanks. -- Lee Jones [李琼斯] Principal Technical Lead - Developer Services Linaro.org │ Open source software for Arm SoCs Follow Linaro: Facebook | Twitter | Blog