Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp927432iog; Wed, 15 Jun 2022 15:55:04 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uMWWSD6601XsO5hNx2U4AAEJnFff93gnCEpT4y4LTlILkrUW40z09YN4EAjL475+fySzrv X-Received: by 2002:a05:6402:2925:b0:42d:d019:1716 with SMTP id ee37-20020a056402292500b0042dd0191716mr2719449edb.110.1655333704464; Wed, 15 Jun 2022 15:55:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655333704; cv=none; d=google.com; s=arc-20160816; b=YJ+018HxTCVjprLCoRTmvFiDbYIJV2dRyzOzfYb4+nX4fWSoQiRnj7mEzqiHAWSsU4 9tiRxc8v3VztT6Sr3vP9yc9tThw16ncrZMNzproYFsyXjLU0fUwKjSbW7LyLn9nldPep Ael0w+ApUSZkz81uXhKHLs131vWeI5BzP2ZwGBsCs10agzYOeGqc8ICj2vF3Vi1wLSkB 1L/X8pY9AbiW8y+MR6jI9yhakGeN/FiE+AquPc0MPcWTJ0Lq6jzzIeBFGqHmHUKEciM7 qFkYrWswzn3U9U+T3N2GgO4kuqDctkWAGQiBdU9HjIVJXLsQSTc7C9ZFO9/cIDPXqswf iiPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=tPsP8lL9NuXNrNI5NEN8Nvv2AZwUgDAprPUJsytkX4Q=; b=Bj5Lre/RNyfjYodNzAkH0oePOGqoiCsWI4/PBkmRdHfKLU9e3SMWKaXNylbUbP2hkL rBU/FGdE0rhhazPAF+ECsw4gIc9003LiZvHM9RlGZ/V3ro+g41uIlmsxvv+fuXvNEkuW RmFxFlC6/Ty1c0xwWze3bGGBDonsa/XiH9P+9KrJBjMcWBuYrbBa6yjVmW2JsWJDWVDY 1ZK6D+U3e6OSJoexyKRTkoCLLt3rqDcRGzClemd+H0W4P0Ppo3g4DBBoJyUU/Df2e+mn CDAXdL7gP08FMoe+w3mMKO+2bomeUwO9wfvaw6bR0Ukqw10jVGR9f4PgAw2zNX5WM5pP exjA== ARC-Authentication-Results: i=1; mx.google.com; dkim=temperror (no key for signature) header.i=@pqrs.dk header.s=google header.b=NcSgiVPd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id bs1-20020a056402304100b004335e08d790si564418edb.124.2022.06.15.15.54.39; Wed, 15 Jun 2022 15:55:04 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=temperror (no key for signature) header.i=@pqrs.dk header.s=google header.b=NcSgiVPd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349840AbiFOWvc (ORCPT + 99 others); Wed, 15 Jun 2022 18:51:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S245662AbiFOWvb (ORCPT ); Wed, 15 Jun 2022 18:51:31 -0400 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2144F56413 for ; Wed, 15 Jun 2022 15:51:28 -0700 (PDT) Received: by mail-ed1-x52c.google.com with SMTP id b8so18189367edj.11 for ; Wed, 15 Jun 2022 15:51:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pqrs.dk; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tPsP8lL9NuXNrNI5NEN8Nvv2AZwUgDAprPUJsytkX4Q=; b=NcSgiVPdPKjLcBoPu9yqS5k5D/0TkxyvnlV4DWpuVcmi/omtnGP4bwkaF5leTdeyEw rIxlHryw5qgyoPRsUeIy/0cv1c4bQpKgg2KbZc3x7L7EqBIF8Rvsf5BRtn5UFm5GXCHH iMU2yO+bNsOq4fWQ6kg4PX2qMRJk+Z9wChrdA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=tPsP8lL9NuXNrNI5NEN8Nvv2AZwUgDAprPUJsytkX4Q=; b=ujmXkj0UO1rgf9QWomHDi+g61o/GBTMiV/aU5B9QKKyP/hpM7A+y9yE5gc0Sb48BbE jeVMGL82+h467DOvkI4ujmSPCDfiPSF1S88W7MZ1xnawRf4XTp5rNq5zoLUbqY4ZBohi Fgh7McqBQlMz5xtDRGjF/O6AsuQwMwn2qpQj4sQVdxblYnzIG3KHM11UH9EDjifK561t NIAMN4DdG9YyfDBHQ8KzL3Lvk02EtmcQXTgmNKGh1UrNE8THgKjHl5jjuKVPs3I2bMWn F2lMR7Kj1x85jVe6t2GZXGjrlRbACJ3ds+XqjEvmTJ//+9AxFOyM6OCf7XCeqAL0ZMdB QG2w== X-Gm-Message-State: AJIora8pyqp5o6wqNVZHGxwNQFyyoncdC05sSxlcISBdSKIIPJxcvSry N6DCKiLK8zfJ+/bSu7rx0MoZ+A== X-Received: by 2002:a05:6402:2381:b0:42d:c8fe:d7fe with SMTP id j1-20020a056402238100b0042dc8fed7femr2695591eda.248.1655333486710; Wed, 15 Jun 2022 15:51:26 -0700 (PDT) Received: from localhost.localdomain (80.71.142.18.ipv4.parknet.dk. [80.71.142.18]) by smtp.gmail.com with ESMTPSA id h23-20020aa7c617000000b0042e21f8c412sm371506edq.42.2022.06.15.15.51.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jun 2022 15:51:25 -0700 (PDT) From: =?UTF-8?q?Alvin=20=C5=A0ipraga?= To: hauke@hauke-m.de, Linus Walleij , =?UTF-8?q?Alvin=20=C5=A0ipraga?= , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Russell King Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 0/5] net: dsa: realtek: rtl8365mb: improve handling of PHY modes Date: Thu, 16 Jun 2022 00:51:10 +0200 Message-Id: <20220615225116.432283-1-alvin@pqrs.dk> X-Mailer: git-send-email 2.36.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Alvin Šipraga This series introduces some minor cleanup of the driver and improves the handling of PHY interface modes to break the assumption that CPU ports are always over an external interface, and the assumption that user ports are always using an internal PHY. Changes v2 -> v3: - rebased on net-next - no code change - patch 5: reworded the last paragraph based on Russel's feedback; hopefully it is clear now that my intent is just to fix the semantics, and that the new "feature" of treating ports with external interfaces as user ports, or ports with internal PHY as CPU ports, is just a side-effect of this fix - I make no claim as to the utility of such configurations and just note that they are permissible as far as the hardware is concerned - patch 5: added Luiz and Russel's Acked-by Changes v1 -> v2: - patches 1-4: no code change - add Luiz' reviewed-by to some of the patches - patch 5: put the chip_infos into a static array and get rid of the switch in the detect function; also remove the macros for various chip ID/versions and embed them directly into the array - patch 5: use array of size 3 rather than flexible array for extints in the chip_info struct; gcc complained about initialization of flexible array members in a nested context, and anyway, we know that the max number of external interfaces is 3 Alvin Šipraga (5): net: dsa: realtek: rtl8365mb: rename macro RTL8367RB -> RTL8367RB_VB net: dsa: realtek: rtl8365mb: remove port_mask private data member net: dsa: realtek: rtl8365mb: correct the max number of ports net: dsa: realtek: rtl8365mb: remove learn_limit_max private data member net: dsa: realtek: rtl8365mb: handle PHY interface modes correctly drivers/net/dsa/realtek/rtl8365mb.c | 299 ++++++++++++++++------------ 1 file changed, 177 insertions(+), 122 deletions(-) -- 2.36.1