Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Wed, 15 Jun 2022 16:04:46 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Marek Szyprowski <m.szyprowski@samsung.com>,
        Yu Zhao <yuzhao@google.com>
Cc:     Mel Gorman <mgorman@techsingularity.net>,
        Nicolas Saenz Julienne <nsaenzju@redhat.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Michal Hocko <mhocko@kernel.org>,
        Hugh Dickins <hughd@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>
Subject: Re: [PATCH 7/7] mm/page_alloc: Replace local_lock with normal
 spinlock
Message-Id: <20220615160446.be1f75fd256d67e57b27a9fc@linux-foundation.org>
In-Reply-To: <e1c73640-3f29-bf57-b98d-84b1800cf4e3@samsung.com>
References: <20220613125622.18628-1-mgorman@techsingularity.net>
        <20220613125622.18628-8-mgorman@techsingularity.net>
        <CGME20220615224855eucas1p1ea6d90c23ec9423dfe04b267f6dddd2a@eucas1p1.samsung.com>
        <e1c73640-3f29-bf57-b98d-84b1800cf4e3@samsung.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Thu, 16 Jun 2022 00:48:55 +0200 Marek Szyprowski <m.szyprowski@samsung.com> wrote:

> In the logs I see lots of errors like:
> 
> BUG: sleeping function called from invalid context at 
> ./include/linux/sched/mm.h:274
> 
> BUG: scheduling while atomic: systemd-udevd/288/0x00000002
> 
> BUG: sleeping function called from invalid context at mm/filemap.c:2647
> 
> however there are also a fatal ones like:
> 
> Unable to handle kernel paging request at virtual address 00000000017a87b4
> 
> 
> The issues seems to be a bit random. Looks like memory trashing. 
> Reverting $subject on top of current linux-next fixes all those issues.
> 
> 

This?

--- a/mm/page_alloc.c~mm-page_alloc-replace-local_lock-with-normal-spinlock-fix
+++ a/mm/page_alloc.c
@@ -183,8 +183,10 @@ static DEFINE_MUTEX(pcp_batch_high_lock)
 	type *_ret;							\
 	pcpu_task_pin();						\
 	_ret = this_cpu_ptr(ptr);					\
-	if (!spin_trylock_irqsave(&_ret->member, flags))		\
+	if (!spin_trylock_irqsave(&_ret->member, flags)) {		\
+		pcpu_task_unpin();					\
 		_ret = NULL;						\
+	}								\
 	_ret;								\
 })
 

I'll drop Mel's patch for next -next.