Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220613125622.18628-1-mgorman@techsingularity.net> <20220613125622.18628-8-mgorman@techsingularity.net>
In-Reply-To: <20220613125622.18628-8-mgorman@techsingularity.net>
From:   Yu Zhao <yuzhao@google.com>
Date:   Wed, 15 Jun 2022 16:43:03 -0600
Message-ID: <CAOUHufZwT+x3UG9guoyheUsR6rhvqMSH-n+-zWzdFUiO4_ZtCQ@mail.gmail.com>
Subject: Re: [PATCH 7/7] mm/page_alloc: Replace local_lock with normal spinlock
To:     Mel Gorman <mgorman@techsingularity.net>,
        Andrew Morton <akpm@linux-foundation.org>
Cc:     Nicolas Saenz Julienne <nsaenzju@redhat.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Vlastimil Babka <vbabka@suse.cz>,
        Michal Hocko <mhocko@kernel.org>,
        Hugh Dickins <hughd@google.com>,
        LKML <linux-kernel@vger.kernel.org>,
        Linux-MM <linux-mm@kvack.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Jun 13, 2022 at 8:54 AM Mel Gorman <mgorman@techsingularity.net> wrote:
...

> +#define pcpu_spin_trylock_irqsave(type, member, ptr, flags)            \
> +({                                                                     \
> +       type *_ret;                                                     \
> +       pcpu_task_pin();                                                \
> +       _ret = this_cpu_ptr(ptr);                                       \
> +       if (!spin_trylock_irqsave(&_ret->member, flags))                \
> +               _ret = NULL;                                            \

I'm getting "BUG: sleeping function called from invalid context" with
mm-everything-2022-06-14-19-05.

Perhaps missing a pcpu_task_unpin() here?

> +       _ret;                                                           \
> +})