Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 16 Jun 2022 02:16:15 +0300
From:   "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>
To:     Dave Hansen <dave.hansen@intel.com>
Cc:     tglx@linutronix.de, mingo@redhat.com, bp@alien8.de,
        luto@kernel.org, peterz@infradead.org, ak@linux.intel.com,
        dan.j.williams@intel.com, david@redhat.com, hpa@zytor.com,
        linux-kernel@vger.kernel.org,
        sathyanarayanan.kuppuswamy@linux.intel.com, seanjc@google.com,
        thomas.lendacky@amd.com, x86@kernel.org
Subject: Re: [PATCHv4 3/3] x86/tdx: Handle load_unaligned_zeropad()
 page-cross to a shared page
Message-ID: <20220615231615.w57gatnfc2c55cvs@black.fi.intel.com>
References: <20220614120135.14812-1-kirill.shutemov@linux.intel.com>
 <20220614120135.14812-4-kirill.shutemov@linux.intel.com>
 <2a6e0dbb-89e3-9735-de20-132992d699b4@intel.com>
 <20220615223251.bm4q24pnwkv37w2q@black.fi.intel.com>
 <184456a7-fd03-c3c6-3d4f-4f770e2e8b31@intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <184456a7-fd03-c3c6-3d4f-4f770e2e8b31@intel.com>
Precedence: bulk

On Wed, Jun 15, 2022 at 03:36:02PM -0700, Dave Hansen wrote:
> On 6/15/22 15:32, Kirill A. Shutemov wrote:
> >>>         /*
> >>>          * Reject EPT violation #VEs that split pages.
> >>>          *
> >>>          * MMIO accesses are supposed to be naturally aligned and therefore
> >>>          * never cross page boundaries. Seeing split page accesses indicates
> >>>          * a bug or a load_unaligned_zeropad() that stepped into an MMIO page.
> >>>          *
> >>>          * load_unaligned_zeropad() will recover using exception fixups.
> >>>          */
> > Looks good, thanks.
> 
> I've got that snippet and a few other things staged here:
> 
> > https://git.kernel.org/pub/scm/linux/kernel/git/daveh/devel.git/log/?h=testme
> 
> Could you take a quick look through before I push them somewhere for real?

Looks good to me. Could you fold in the off-by-one fix? 

-- 
 Kirill A. Shutemov