Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: UL4PpwRmcR2yvN4Tetot1MZeUM0lmWKNr/gxdOojTCkq1FByfXYOySVKYbu4RSRuzF063ps916
 mcm9DiQgcaq9yz9w8GW5qtmvgrfEliDiTt/6JeK7kZbdnqeTcBRf/hoGSe73F5WqQ7KWCOcaR8
 dcM67NAhEfAvLBTSVvrtwY+aCwrofwL20pZ1WDhTidGzngu7ZdTSrzNcOHnjiopQCsa+Q1xgyz
 hF1/GtPHdmkCXiJqG4+qA2ugmhF9xkirUE1c94MDDuH58FyW+toVJaUzrtp22qssS5jECCnMQQ
 VoNTPNvrw2z3xteeJSgFQC5t
IronPort-SDR: FelsHwCUvpbydmJrvbL3BZ/TzYej6hstgk/+JxRPymGpvEVMXYQ9CSE8IG7SWnacNAVC+9Etov
 fjudXF677M1bu0eUS5W+nmKQiybc09IL8FmDUcHrrOS8V43GfusRuyj4vcCHuQC3ZcnpiWdvqL
 xMktv4jBm1gFHFnxG7r5iu0stevwJxip4bmBKndaOHWJ4LGDwpS2w3a+MwQh/FFKE9bFHLbT+Q
 UPEj/zNVhvw7ag1dbbnYWO5nOjrmQe3azpIiNJHRNzbNyr5BelGFWkKxFxDslgMUbrgIrcx4Zc
 VCo=
WDCIronportException: Internal
Message-ID: <5f1edbd8-018a-bcd0-10f2-94767f341b45@opensource.wdc.com>
Date:   Thu, 16 Jun 2022 09:33:22 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH v4 19/23] ata: ahci: Add DWC AHCI SATA controller support
Content-Language: en-US
To:     Serge Semin <fancer.lancer@gmail.com>
Cc:     Serge Semin <Sergey.Semin@baikalelectronics.ru>,
        Hans de Goede <hdegoede@redhat.com>,
        Jens Axboe <axboe@kernel.dk>, Hannes Reinecke <hare@suse.de>,
        Alexey Malahov <Alexey.Malahov@baikalelectronics.ru>,
        Pavel Parkhomenko <Pavel.Parkhomenko@baikalelectronics.ru>,
        Rob Herring <robh+dt@kernel.org>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
References: <20220610081801.11854-1-Sergey.Semin@baikalelectronics.ru>
 <20220610081801.11854-20-Sergey.Semin@baikalelectronics.ru>
 <52c9ca79-769f-4426-db94-7aad05a68258@opensource.wdc.com>
 <20220615214802.ke6owp5cuv5l77hu@mobilestation>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220615214802.ke6owp5cuv5l77hu@mobilestation>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/06/16 6:48, Serge Semin wrote:
[...]
>> MODULE_LICENSE("GPL v2");
>>
>> To match the file header SPDX.
> 
> No. Please see the commit bf7fbeeae6db ("module: Cure the
> MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") and what checkpatch.pl
> says should the "GPL v2" string is used in the module license block.
> More info regarding this macro and the possible license values are
> described here:
> Documentation/process/license-rules.rst

ah ! OK. I was not 100% sure. Doing a quick grep, there is still a lot of (half
?) of "GPL v2" vs "GPL".

Ignore this then.

> 
> -Sergey
> 
>>
>>> diff --git a/drivers/ata/ahci_platform.c b/drivers/ata/ahci_platform.c
>>> index 9b56490ecbc3..8f5572a9f8f1 100644
>>> --- a/drivers/ata/ahci_platform.c
>>> +++ b/drivers/ata/ahci_platform.c
>>> @@ -80,9 +80,7 @@ static SIMPLE_DEV_PM_OPS(ahci_pm_ops, ahci_platform_suspend,
>>>  static const struct of_device_id ahci_of_match[] = {
>>>  	{ .compatible = "generic-ahci", },
>>>  	/* Keep the following compatibles for device tree compatibility */
>>> -	{ .compatible = "snps,spear-ahci", },
>>>  	{ .compatible = "ibm,476gtr-ahci", },
>>> -	{ .compatible = "snps,dwc-ahci", },
>>>  	{ .compatible = "hisilicon,hisi-ahci", },
>>>  	{ .compatible = "cavium,octeon-7130-ahci", },
>>>  	{ /* sentinel */ }
>>
>>
>> -- 
>> Damien Le Moal
>> Western Digital Research
> 


-- 
Damien Le Moal
Western Digital Research