Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: W60rhDafPdg/SMBXdozMH7r6dWww9ENmwR0nav36gVtXsCbOuXg903kDdYYZmddQGjPSjxaSdM
 HTUIK8PtiPij1qW+sLlGnaA+ifszxi2l7+PpNYIw7O0wsGwUloHYLDQHKWItI0/n5d1TAzl/R9
 sjQGXbSq7czZ5OA+A4Kua3vLEzOXSGxLtej8h9LfGz155qJOP7E1/V0PcNdcNynBiavUWTaYpw
 GN9FfcKwgmOnCKxaYBBe/kQpZp83Q29iFb2CQ6MW4H04Ibap6LXL/Ca8w4r9Zv5rcZGx0vOIeS
 QVxE7ZlBLk7wUlJTNsjmNrAU
IronPort-SDR: fjdGzWcCx0v7IHlWBXaWZOev6EY2A8OLPxBDelBln8kn96Tl/KmjY//EIvhn0RpWVrqGhjsxPI
 /47J+TvDkb/ffGTqLdJvtcdoXHmcKTkjIJC9ZmPAinhx6Fvm9tiuO4jNQKHOxt2PWTRL08r3xH
 kUrtx3XIiAOaiFEEcflPn70TemhSUpwS/0wxTMk8OPGwFPitgRGvbKaUOwZhVOeJCVRDZELWD2
 9WOnMNTEkrJk/m+BTfMUERoIVqurFNBrglcs98oWfW40xbwD/EHk6uD2CmZLnmcDIn9n8WZVaS
 UGM=
WDCIronportException: Internal
Message-ID: <6082771c-6bf7-bb34-4d2c-5199024dc4cc@opensource.wdc.com>
Date:   Thu, 16 Jun 2022 09:34:56 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.10.0
Subject: Re: [PATCH] ata: libata: add qc->flags in ata_qc_complete_template
 tracepoint
Content-Language: en-US
To:     Edward Wu <edwardwu@realtek.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, Hannes Reinecke <hare@suse.de>,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220616001615.11636-1-edwardwu@realtek.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220616001615.11636-1-edwardwu@realtek.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/06/16 9:16, Edward Wu wrote:
> Add flags value to check the result of ata completion
> 
> Signed-off-by: Edward Wu <edwardwu@realtek.com>
> ---
>  include/trace/events/libata.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
>  		__entry->hob_feature	= qc->result_tf.hob_feature;
>  		__entry->nsect		= qc->result_tf.nsect;
>  		__entry->hob_nsect	= qc->result_tf.hob_nsect;
> +		__entry->flags		= qc->flags;
>  	),
>  
>  	TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \

Doesn't this need a Fixes tag ?

-- 
Damien Le Moal
Western Digital Research