Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220611022314.21593-1-linmiaohe@huawei.com> <8b34a515-e5fd-731a-4164-9080c275d4e9@google.com>
 <7c363619-4159-8a21-d55a-535e21b5c8b4@arm.com>
In-Reply-To: <7c363619-4159-8a21-d55a-535e21b5c8b4@arm.com>
From:   Yang Shi <shy828301@gmail.com>
Date:   Wed, 15 Jun 2022 17:40:23 -0700
Message-ID: <CAHbLzkq=M=yMj-w95R5uCy_YqELRJhdKPjZ=qR5Ticacve8b-g@mail.gmail.com>
Subject: Re: [PATCH] mm/shmem.c: use helper transhuge_vma_enabled()
To:     Anshuman Khandual <anshuman.khandual@arm.com>
Cc:     Hugh Dickins <hughd@google.com>, Miaohe Lin <linmiaohe@huawei.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, Jun 14, 2022 at 10:02 PM Anshuman Khandual
<anshuman.khandual@arm.com> wrote:
>
>
>
> On 6/11/22 08:44, Hugh Dickins wrote:
> > On Sat, 11 Jun 2022, Miaohe Lin wrote:
> >
> >> Use helper transhuge_vma_enabled() to check whether transhuge is enable
> >> on vma. Minor readability improvement.
> >>
> >> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> >
> > No thanks, that's a readability regression, forcing reader
> > to go and look up what transhuge_vma_enabled() actually means.
> >
> > What you call a helper, I call an obfuscator - as I implied in
> > b9e2faaf6fa0 ("huge tmpfs: revert shmem's use of transhuge_vma_enabled()")
>
> The same reasoning should also be applicable for other calls sites
> for transhuge_vma_enabled(). Should not they be dropped as well ?

Yes, the only caller was hugepage_vma_check(). It was changed to
open-code and the helper was removed by series:
https://lore.kernel.org/linux-mm/20220615172926.546974-1-shy828301@gmail.com/T/#m7610c2a4e5dda753cbc850986d5486f59a821c1a

>
> >
> > Hugh
> >
> >> ---
> >>  mm/shmem.c | 3 +--
> >>  1 file changed, 1 insertion(+), 2 deletions(-)
> >>
> >> diff --git a/mm/shmem.c b/mm/shmem.c
> >> index 133c67057d41..59cc2e980c95 100644
> >> --- a/mm/shmem.c
> >> +++ b/mm/shmem.c
> >> @@ -480,8 +480,7 @@ bool shmem_is_huge(struct vm_area_struct *vma,
> >>              return false;
> >>      if (shmem_huge == SHMEM_HUGE_DENY)
> >>              return false;
> >> -    if (vma && ((vma->vm_flags & VM_NOHUGEPAGE) ||
> >> -        test_bit(MMF_DISABLE_THP, &vma->vm_mm->flags)))
> >> +    if (vma && !transhuge_vma_enabled(vma, vma->vm_flags))
> >>              return false;
> >>      if (shmem_huge == SHMEM_HUGE_FORCE)
> >>              return true;
> >> --
> >> 2.23.0
> >
>