Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <62074230-52d9-83b7-df64-c00aea016150@gmail.com>
Date:   Thu, 16 Jun 2022 08:31:31 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v2] Documentation: highmem: Use literal block for
 *kmap_local_folio() example
Content-Language: en-US
To:     Ira Weiny <ira.weiny@intel.com>
Cc:     linux-doc@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>,
        "Matthew Wilcox (Oracle)" <willy@infradead.org>,
        "Fabio M. De Francesco" <fmdefrancesco@gmail.com>,
        Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
        linux-mm@kvack.org, linux-kernel@vger.kernel.org
References: <20220615101509.516520-1-bagasdotme@gmail.com>
 <YqnyJ/5/ZLiNI+5v@iweiny-server> <YqnyiuaeQz6aSNUL@iweiny-server>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <YqnyiuaeQz6aSNUL@iweiny-server>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/15/22 21:54, Ira Weiny wrote:
>> Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> 
> My bad...
> 
>> Tested-by: Ira Weiny <ira.weiny@intel.com>
>>
>>> Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>
>>> Cc: "Fabio M. De Francesco" <fmdefrancesco@gmail.com>
>>> Cc: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>>> Cc: linux-mm@kvack.org
>>> Cc: linux-kernel@vger.kernel.org
>>> Signed-off-by: Bagas Sanjaya <bagasdotme@gmail.com>
>>> ---
>>>  Changes since v1 [1]:
>>>    - Point that the code example is for kmap_atomic() (suggested by
>>>      Matthew Wilcox)
> 
> As Willy pointed out you did not do this.  I was mistaken to believe this
> statement.

My bad too...

I forget editing patch subject. I guess the subject and description could
just say "code example in *kmap_local_folio() comment" somewhere.

Willy, what do you think? Any suggestion?

-- 
An old man doll... just what I always wanted! - Clara