Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <20220523093346.28493-9-rex-bc.chen@mediatek.com>
References: <20220523093346.28493-1-rex-bc.chen@mediatek.com> <20220523093346.28493-9-rex-bc.chen@mediatek.com>
Subject: Re: [RESEND v8 08/19] clk: mediatek: reset: Support inuput argument index mode
From:   Stephen Boyd <sboyd@kernel.org>
Cc:     p.zabel@pengutronix.de, angelogioacchino.delregno@collabora.com,
        nfraprado@collabora.com, chun-jie.chen@mediatek.com,
        wenst@chromium.org, runyang.chen@mediatek.com,
        linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        Project_Global_Chrome_Upstream_Group@mediatek.com,
        Rex-BC Chen <rex-bc.chen@mediatek.com>
To:     Rex-BC Chen <rex-bc.chen@mediatek.com>,
        krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com,
        mturquette@baylibre.com, robh+dt@kernel.org
Date:   Wed, 15 Jun 2022 18:51:59 -0700
User-Agent: alot/0.10
Message-Id: <20220616015201.6D848C3411A@smtp.kernel.org>
Precedence: bulk

Quoting Rex-BC Chen (2022-05-23 02:33:35)
> There is a large number of mediatek infra reset bits, but we do not use
> all of them. In addition, the proper input argement of reset controller
> soulde be index.
> Therefore, to be compatible with previous drivers and usage, we add
> description variables to store the ids which can mapping to index.
>=20
> To use this mode, we need to put the id in rst_idx_map to map from
> index to ids. For example, if we want to input index 1 (this index
> is used to set bank 1 bit 14) for svs, we need to declare the reset
> controller like this:
>=20
> In drivers:
> static u16 rst_ofs[] =3D {
>         0x120, 0x130, 0x140, 0x150, 0x730,
> };
>=20
> static u16 rst_idx_map[] =3D {
>         0 * 32 + 0,
>         1 * 32 + 14,
>         ....
> };
>=20
> static const struct mtk_clk_rst_desc clk_rst_desc =3D {
>         .version =3D MTK_RST_SET_CLR,
>         .rst_bank_ofs =3D rst_ofs,
>         .rst_bank_nr =3D ARRAY_SIZE(rst_ofs),
>         .rst_idx_map =3D rst_idx_map,
>         .rst_idx_map_nr =3D ARRAY_SIZE(rst_idx_map),
> };
>=20
> In dts:
> svs: {
>         ...
>         resets =3D <&infra 1>;
>         ...
> };
>=20
> Signed-off-by: Rex-BC Chen <rex-bc.chen@mediatek.com>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collab=
ora.com>
> Reviewed-by: N=C3=ADcolas F. R. A. Prado <nfraprado@collabora.com>
> Tested-by: N=C3=ADcolas F. R. A. Prado <nfraprado@collabora.com>
> ---

Applied to clk-next