Received: by 2002:a6b:fb09:0:0:0:0:0 with SMTP id h9csp1038003iog; Wed, 15 Jun 2022 19:08:07 -0700 (PDT) X-Google-Smtp-Source: AGRyM1uIJPYVnpokUMs733BC5RAztpcoSVbQoPLjCA+1YuYGhwbPlvX2yAapQoOhLRFzqbUOlDGY X-Received: by 2002:a05:6a00:1894:b0:522:d414:61f7 with SMTP id x20-20020a056a00189400b00522d41461f7mr2472350pfh.18.1655345287506; Wed, 15 Jun 2022 19:08:07 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1655345287; cv=none; d=google.com; s=arc-20160816; b=MWuYu511qZ7sHhA0O/R81MVn1gTpJCOoMLkzpapOHnFp361GKK9DlGobp/aHuCXkjS LdprZ8WKdWHqCrTGtw41MWb0TZ2BsJQoZdjFV48MJcw8AskYaou693B+YuWtUyF/5veg 9COd7GV6rTbqwSJS/2J6XebAN04msKh0rKhPeYuOGwzap+Ugmm1hcNpxMiJE5UYYfTQ9 vT+zMJ3HwRpw4MTGZLeAktDNOZJZhRsjW2LoRCR6N+Q7QOGczQyQTNmLwKjnE4QjkFIf eqXmpimqSAKPyeuzzQuKYUWk4ToPfMW/5mKjf2oQAgXouw2h+XuJhD91f/Fy34xa7Qvy sMMg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:message-id:user-agent:date:to:cc:from:subject :references:in-reply-to:content-transfer-encoding:mime-version :dkim-signature; bh=mF0NndCR6m2d49GRqn5l9HYgTOrCNWb0rl8SH0KCYY4=; b=ursK//f43yELG3Hz8XOr041nQ69GRplHO6jtjpzOQMdSDNjReVuEA2+J6pcFnzpkvD 3tny+qdCrCzWNb0PImFzxKX33vT2PvyMt4TFeCHtDf7UBkKn62wF0Ic3rNfngsWQi71/ XEvhOON74aumsXKS8ZNdRPJbvFm5tSx3U0qU+1pkyd6ukLQXRGPFmRARbvkujiESaUxu ppEzFAxXhei11LpTR96UlKwtXJ8Coe39+SWGkhBp4UEQd8UzphzDljEGevzvvezvNIeR Nygc3FUzkXNrjV+3jxhYeP0J62kVM6SpTJUe2k97t3LQIzLgcftrOyMUVRLHWPyL9L4h moTg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=opLJdMyu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id pm6-20020a17090b3c4600b001df3d491cb1si3961478pjb.161.2022.06.15.19.07.55; Wed, 15 Jun 2022 19:08:07 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=opLJdMyu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346367AbiFPBvD (ORCPT + 99 others); Wed, 15 Jun 2022 21:51:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53682 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350856AbiFPBui (ORCPT ); Wed, 15 Jun 2022 21:50:38 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9CFA2583AB; Wed, 15 Jun 2022 18:50:32 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id E942F61CF6; Thu, 16 Jun 2022 01:50:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CC31C3411E; Thu, 16 Jun 2022 01:50:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1655344231; bh=mF0NndCR6m2d49GRqn5l9HYgTOrCNWb0rl8SH0KCYY4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=opLJdMyu8LUgCovtfIzecb3R3SgxjUiw3Rv1gfluPdDdXn1T+IVznD78Vg1Jq/O7h v5MKxaYs96WBoPOLxfwEmZgPmb2X2dSmCeh79wkVLGWvNBy5GYe8e2j0ivltoCNlZm iBAJmRdSGtO4tg4BmQ5gOpTBhOUsBFx/7hpXhj8f+HO0Kc2HORVRvIh4ycwklkVpp2 DWECHtysvSumzPdhLruMeOYXYo4DDcfbQoDARgW8YVnAPNCPpWGTV1D7Z+0WMyntD2 FImowNT/ADNvC2zdFJg8sq4Qtva9qfQVPtHLW2YLhqFNcWVJVHtBOANargIEElDbzh I+BS2zylGFcQg== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <20220523093346.28493-3-rex-bc.chen@mediatek.com> References: <20220523093346.28493-1-rex-bc.chen@mediatek.com> <20220523093346.28493-3-rex-bc.chen@mediatek.com> Subject: Re: [RESEND v8 02/19] clk: mediatek: reset: Fix written reset bit offset From: Stephen Boyd Cc: p.zabel@pengutronix.de, angelogioacchino.delregno@collabora.com, nfraprado@collabora.com, chun-jie.chen@mediatek.com, wenst@chromium.org, runyang.chen@mediatek.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Project_Global_Chrome_Upstream_Group@mediatek.com, Rex-BC Chen To: Rex-BC Chen , krzysztof.kozlowski+dt@linaro.org, matthias.bgg@gmail.com, mturquette@baylibre.com, robh+dt@kernel.org Date: Wed, 15 Jun 2022 18:50:28 -0700 User-Agent: alot/0.10 Message-Id: <20220616015031.4CC31C3411E@smtp.kernel.org> X-Spam-Status: No, score=-8.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Quoting Rex-BC Chen (2022-05-23 02:33:29) > Original assert/deassert bit is BIT(0), but it's more resonable to modify > them to BIT(id % 32) which is based on id. >=20 > This patch will not influence any previous driver because the reset is > only used for thermal. The id (MT8183_INFRACFG_AO_THERM_SW_RST) is 0. >=20 > Fixes: 64ebb57a3df6 ("clk: reset: Modify reset-controller driver") > Signed-off-by: Rex-BC Chen > Reviewed-by: Chen-Yu Tsai > Reviewed-by: AngeloGioacchino Del Regno > Reviewed-by: N=C3=ADcolas F. R. A. Prado > Tested-by: N=C3=ADcolas F. R. A. Prado > --- Applied to clk-next