Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: Zt1fHJb98hysiyoDvYQGfCcRMIZcV0bmUg+wrOu0GsYatvLEbVQ+D3kBGQGWKGcrRtxCakzEdd
 X3fZqzQ63p4NRxj+CSUVXAPgyFpbOwIotM83Za+EBEuDlKF1sKl+/zCw8TKZkC8UYe5azfZqsi
 g4HehwPLtylmZcC7rU+VUL03dkrjAvz0xHw5otl/vL8ufWcb4ZyW6VppnkfDHm4dF9FRMTayje
 jxib9Y1wXkdOJH8oinT7yk+XdELUneeq9Id7X7I3Zqrw8SSFX0OElCFxp22i1zx+zKAN/0Hj7I
 OMIgpIsOszH01P4UEu+uNFsj
IronPort-SDR: ZFu/oUYMbyi174ondwZF20oddk4B7DaZIT7bGG7Ykpx6bB5A5A0+329qagC/ZqAzSKwIy2NT4R
 v93cpne0XX8uqfhG4GxZWRAleL7IiSaAbHV3zTa//94rni5OnU8v5A3DVc+6GrzU9eqatjBWNg
 WrY7DwJcldl81JluR3rCmlBzQq1YwtkDr+emdWJhgIbEuIKrqTMZt0+Ip98XyNHqw2egIf7Jtv
 T70iAZTm+CMMz5ws09qWSfq5Efo5FHGiUqF/dtqak6ZJcc69PFAbCysXD8OffmfX0B6v7TqJ2I
 3QQ=
WDCIronportException: Internal
Message-ID: <bcd06ab1-6ead-985b-eff8-cbc526a8aa84@opensource.wdc.com>
Date:   Thu, 16 Jun 2022 11:55:15 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH v2] ata: libata: add qc->flags in ata_qc_complete_template
 tracepoint
Content-Language: en-US
To:     Edward Wu <edwardwu@realtek.com>,
        Steven Rostedt <rostedt@goodmis.org>,
        Ingo Molnar <mingo@redhat.com>, Hannes Reinecke <hare@suse.de>,
        Tejun Heo <tj@kernel.org>, linux-ide@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20220616001615.11636-1-edwardwu@realtek.com>
 <20220616004803.12145-1-edwardwu@realtek.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220616004803.12145-1-edwardwu@realtek.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/16/22 09:48, Edward Wu wrote:
> Add flags value to check the result of ata completion
> 
> Fixes: 255c03d15a29 ("libata: Add tracepoints")
> Link: https://lkml.kernel.org/r/20220616001615.11636-1-edwardwu@realtek.com

What is this Link tag for ? I do not think it is needed.
And please add:

Cc: stable@vger.kernel.org

> Signed-off-by: Edward Wu <edwardwu@realtek.com>
> ---
> v2:
> - Add Fixes tag
> 
>   include/trace/events/libata.h | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/include/trace/events/libata.h b/include/trace/events/libata.h
> index d4e631aa976f..6025dd8ba4aa 100644
> --- a/include/trace/events/libata.h
> +++ b/include/trace/events/libata.h
> @@ -288,6 +288,7 @@ DECLARE_EVENT_CLASS(ata_qc_complete_template,
>   		__entry->hob_feature	= qc->result_tf.hob_feature;
>   		__entry->nsect		= qc->result_tf.nsect;
>   		__entry->hob_nsect	= qc->result_tf.hob_nsect;
> +		__entry->flags		= qc->flags;
>   	),
>   
>   	TP_printk("ata_port=%u ata_dev=%u tag=%d flags=%s status=%s " \


-- 
Damien Le Moal
Western Digital Research